From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#42324: 26.3; Doc string of `seq-concatenate' Date: Wed, 26 Aug 2020 11:14:52 -0700 (PDT) Message-ID: References: <> <> <> <<83a6yi3q0p.fsf@gnu.org>> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39850"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 42324@debbugs.gnu.org, stefan@marxist.se To: Eli Zaretskii , Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 26 20:18:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAzzv-000AEz-TT for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 Aug 2020 20:18:12 +0200 Original-Received: from localhost ([::1]:46434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAzzu-00078x-VF for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 Aug 2020 14:18:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53142) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAzzm-00078Y-Qj for bug-gnu-emacs@gnu.org; Wed, 26 Aug 2020 14:18:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57438) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kAzzm-0006Ou-Gu for bug-gnu-emacs@gnu.org; Wed, 26 Aug 2020 14:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kAzzm-0007sc-Cr for bug-gnu-emacs@gnu.org; Wed, 26 Aug 2020 14:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Aug 2020 18:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42324 X-GNU-PR-Package: emacs Original-Received: via spool by 42324-submit@debbugs.gnu.org id=B42324.159846582430197 (code B ref 42324); Wed, 26 Aug 2020 18:18:02 +0000 Original-Received: (at 42324) by debbugs.gnu.org; 26 Aug 2020 18:17:04 +0000 Original-Received: from localhost ([127.0.0.1]:40745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAzyq-0007qz-6e for submit@debbugs.gnu.org; Wed, 26 Aug 2020 14:17:04 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:48858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAzyn-0007qR-QQ for 42324@debbugs.gnu.org; Wed, 26 Aug 2020 14:17:03 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07QIFJf3161162; Wed, 26 Aug 2020 18:16:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=rYuc/w3T+LeeI17wB/MNSC2CiOWC378w35EEDFOgs7w=; b=ifESNoMHmE/Wb+Kj9/nzoSAXU4F4Nwt9DqW0Nwve1GzTR1HYGzCh8rS0xYh/DYKrT1pQ fwpjxl1kNOgHsyTNE0IFxe0Wi+LoPlhkQAErgWfD9o9gACxnuVhYnO5qwo8MmPX7Nchl Suc166s6ARy+JeI5tmQRtiWwqkPyt7MYh+g5n+gAHYfq1o5IWdab+gaPWYcHtlpdsPq/ N/NG3NcS1Xy+P2+fwgWGoilO9wvcmG7kbAEEjHEEwjGnZivnvJkezji8XdHIbCE2+N0m tDWz4lMiGl8MpdnHxNpx2Wg8r+KNMM26laeKLibD7T/jIlHRhO1VTKSd7KfrhWcSGJHr Rg== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 333w6u0m8g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 26 Aug 2020 18:16:56 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07QIBN8K193040; Wed, 26 Aug 2020 18:14:55 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 333r9m8qc5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 26 Aug 2020 18:14:55 +0000 Original-Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 07QIErjJ009919; Wed, 26 Aug 2020 18:14:53 GMT In-Reply-To: <<83a6yi3q0p.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5044.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9725 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 suspectscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008260135 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9725 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 impostorscore=0 mlxlogscore=999 suspectscore=0 phishscore=0 malwarescore=0 spamscore=0 priorityscore=1501 clxscore=1015 mlxscore=0 lowpriorityscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008260136 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186459 Archived-At: > > In Emacs 26.3, this is the definition of `seq-concatenate': > > > > (cl-defgeneric seq-concatenate (type &rest sequences) > > "Concatenate SEQUENCES into a single sequence of type TYPE. > > TYPE must be one of following symbols: vector, string or list. > > > > \n(fn TYPE SEQUENCE...)" > > (apply #'cl-concatenate > > type > > (seq-map #'seq-into-sequence sequences))) >=20 > If the bug report is about the doc string, please don't show the > implementation as your evidence. The issue is (or should be) with the > text of the doc string. You took that out of context. The context was the (apparent) change since 26.3, when the bug was reported. And the bug report is (only) about the doc, including differences `seq-concatenate' vs `cl-concatenate'. IF those are now the same thing, and that's said in the doc (which it apparently is), then #2 of this bug report disappears. And #1 is the same as bug #42323. See also #3. > > I'd say, overall, that I don't understand the behavior > > by reading the doc string. >=20 > Which part(s) of the doc string's text are unclear? The text is short > and IMO very clear, so I'm puzzled by this bug report to begin with. >=20 > In general, it sounds like what you are after is to understand the > implementation, and that can only be done by reading the code. In > that case, I see no bug to report here. All of #1, #2, and #3 are only about the doc string. In any case, the real difficulty is #1, which is bug #42323. If that gets fixed properly, AND if `seq-concatenate' is now exactly the same as `cl-concatenate' and that's stated in the doc, then things should be clear. What's discussed in this thread is, however, relevant to bug #42323, I think. Including if the behavior can change depending on SEQUENCES, as seems to be the case from looking at the code and `cl-defgeneric'. The bug report is not about the implementation at all. It's about the doc specifying the behavior.