From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#33992: 27.0.50; xref-find-definitions wastes too much space Date: Sat, 6 Apr 2019 02:20:02 +0300 Message-ID: References: <87muoe7jrs.fsf@mail.linkov.net> <87a7hp43a5.fsf@mail.linkov.net> <205acda7-07a3-d85c-378c-c178f9f76b55@yandex.ru> <87o95l4ht4.fsf@mail.linkov.net> <64f42172-460f-a633-1c80-23d34b5c0d07@yandex.ru> <87lg0ou6q7.fsf@ulti.tmit.bme.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="125070"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.0a1 Cc: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , Juri Linkov To: Felician Nemeth , 33992@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 06 01:21:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hCY92-000WQA-8N for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Apr 2019 01:21:12 +0200 Original-Received: from localhost ([127.0.0.1]:48133 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCY91-0000Xk-5C for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Apr 2019 19:21:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51586) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCY8u-0000XU-Ad for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2019 19:21:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hCY8t-0002ve-DM for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2019 19:21:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32818) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hCY8s-0002uR-Fw for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2019 19:21:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hCY8s-0006yG-1s for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2019 19:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Apr 2019 23:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33992-submit@debbugs.gnu.org id=B33992.155450641726721 (code B ref 33992); Fri, 05 Apr 2019 23:21:01 +0000 Original-Received: (at 33992) by debbugs.gnu.org; 5 Apr 2019 23:20:17 +0000 Original-Received: from localhost ([127.0.0.1]:46362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCY86-0006ws-O8 for submit@debbugs.gnu.org; Fri, 05 Apr 2019 19:20:15 -0400 Original-Received: from mail-lf1-f52.google.com ([209.85.167.52]:40207) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCY84-0006wb-QB for 33992@debbugs.gnu.org; Fri, 05 Apr 2019 19:20:13 -0400 Original-Received: by mail-lf1-f52.google.com with SMTP id a28so5505332lfo.7 for <33992@debbugs.gnu.org>; Fri, 05 Apr 2019 16:20:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4MrZpRuRFHWzvKmygmbytJ0AeZGGeGceSG6SqDocmcE=; b=Hw3hdbFoAKwTQaSpKudLPg8UVAqoZmUfan77+bBkej992E8B/3DBrWCjldV1RBoxCL XpJYO+HuVGKa2P7xXlZw10njOVbU6VVo6GGHVrqJnirMWkklIIRmz3N/+nyhT9bTh4Hr FhIFOQKUtvar09isfSa5PXURmG5MZH2xEJQe0QuuBoD9WTodMQbw1vrP+kW0VPxRYTqq D8Rjg1geod+y+evhKEeQCW9ckntn9SSypDJYbYlJru9gbnucYI9jCEzGo1A8Qgu4y877 RwhfSwv1aX6n76MYPRdf0Vr30Px2sBDUTDt/+uo5hXES6ow8lATgI9og46KRBI1RADjK op0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4MrZpRuRFHWzvKmygmbytJ0AeZGGeGceSG6SqDocmcE=; b=ax4i3URWnO2wJxQieQ4WBz/8EUN0E1FJc7tAqqxxlnEaQsAz1uodCUULdxoANQiVQL 0gHHHv4pyzSyvrBhAzHGXliwxzFV4EF3qTPN6X1UTLXyq+01h7CncmIsT4cBWE6a+mwF cUJuMSs2d7Ib4mnlKx34LJF7ryOPreQBlkyZvtS27N8OQp5AYzLKoqT9VXDMMlW0SGdr rnFGLq9tvyVP+2VWHv2lrL5CwGmJEtsLo2kPS0+vipPVniOgfhIEckwhKq1BI3ieluWq tHHfc68e4nVXZ1tcVFkn8dNiBi25qwEScCJnVedvfC2AyqnDfu6OEmj8Fou3lkkOdHwn dTOg== X-Gm-Message-State: APjAAAUvtrbx39DAbHerSnqpoAYr/XAfdUf07OvRsl0dhbll+F6vkH5O IOs8LLZlfIRUdO2C6CfDQbo= X-Google-Smtp-Source: APXvYqydHmBrK0nUXEYD0OTzPbxLt3OxDZ0MuyKBkE5lf2ePBDvsKnKtkN+qsCKGz2eda5DxCgeWkA== X-Received: by 2002:a19:f81a:: with SMTP id a26mr8504082lff.34.1554506406914; Fri, 05 Apr 2019 16:20:06 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id m28sm5167792lfc.54.2019.04.05.16.20.04 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 05 Apr 2019 16:20:05 -0700 (PDT) In-Reply-To: <87lg0ou6q7.fsf@ulti.tmit.bme.hu> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157240 Archived-At: On 05.04.2019 12:44, Felician Nemeth wrote: > (Sorry for replying late, I've just read this bug report.) > > I thought that I didn't need to see the list of the xref results and the > xrefs' window shrank the view of the code I wanted to study. So, I came > up with the defun below. It presents the xref results without showing > the xref window. I think this idea can be further developed. For instance, by not calling xref--show-xref-buffer right away, and instead storing the arguments. And then maybe calling it later if the user types 'm'. You won't be able to use previous/next-error for such an implementation, though. > xref-show--xrefs-buffer could have an 'm' key binding that "minimizes" > its window by switching to xref-show-xrefs-without-buffer (below) and > that function can "maximize" back with the same 'm' key. A customizable > variable could define the initial behavior. I'm not a fan of this interface, personally. It's good that it's available, though. We will make xref-show-xrefs-function a defcustom sooner or later, when we're sure that it doesn't need to be changed much. > Also, I think we can enhance xref-pulse-momentarily to use a different > face if there's only one xref to present. Yes, but I'm not sure the user will quickly understand the meaning of the different face. Anyway, we can make the exact face name a defcustom (it's currently 'next-error'), and you'd be able to change it via 'let'.