From: Dmitry Gutov <dgutov@yandex.ru>
To: Jacob Faibussowitsch <jacob.fai@gmail.com>
Cc: Randy Taylor <dev@rjt.dev>, Yuan Fu <casouri@gmail.com>,
61655@debbugs.gnu.org
Subject: bug#61655: [Tree sitter] [Feature Request] font-lock function calls, definitions, separately
Date: Wed, 22 Feb 2023 01:24:48 +0200 [thread overview]
Message-ID: <a0a7637d-a1ff-e22d-c6b5-b292b712b0e0@yandex.ru> (raw)
In-Reply-To: <56C0998E-3053-49F3-BAE3-46D6432B16F5@gmail.com>
On 21/02/2023 17:31, Jacob Faibussowitsch wrote:
> but maybe a better default is to leave these faces totally blank and
> just purely `:inherit` from `font-lock-function-name-face`
I believe so.
> +(defface font-lock-function-call-face
> + '((t :inherit font-lock-function-name-face :foreground "royalblue1"))
> + "Font Lock mode face used to highlight function calls."
> + :group 'font-lock-faces)
This one I was thinking of as well.
> +(defface font-lock-member-function-call-face
> + '((t :inherit font-lock-function-name-face :foreground "brightred"))
> + "Font Lock mode face used to highlight member function calls."
> + :group 'font-lock-faces)
What's a "member function"? Is it like a method? If people want this
distinction, we can add such face. But I'm curious whether some other
editors use different colors for these cases.
I'm also wondering what face we're supposed to use for "receiver-less"
method calls, such as calls to the methods defined in the same class, in
e.g. Ruby and Java. Or C++/C#. They don't use 'this'.
I think more importantly, we need a new face for variables.
font-lock-variable-ref-face ?
I also wonder whether we'll need to separate faces for properties:
definitions vs. uses. That one we could use to do early, to keep the
names uniform, e.g. we'd have:
font-lock-function-name-face
font-lock-function-call-face
font-lock-variable-name-face
font-lock-variable-ref-face
font-lock-property-name-face
font-lock-property-ref-face
next prev parent reply other threads:[~2023-02-21 23:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 15:54 bug#61655: [Tree sitter] [Feature Request] font-lock function calls, definitions, separately Jacob Faibussowitsch
2023-02-20 17:03 ` Eli Zaretskii
2023-02-20 20:24 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-20 20:45 ` Jacob Faibussowitsch
2023-02-21 8:28 ` Yuan Fu
2023-02-21 9:55 ` Dmitry Gutov
2023-02-21 15:31 ` Jacob Faibussowitsch
2023-02-21 23:24 ` Dmitry Gutov [this message]
2023-02-22 18:07 ` Jacob Faibussowitsch
2023-02-22 21:39 ` Dmitry Gutov
2023-02-22 20:45 ` Yuan Fu
2023-02-22 21:38 ` Dmitry Gutov
2023-02-23 18:15 ` Eli Zaretskii
2023-02-24 2:31 ` Dmitry Gutov
2023-02-24 7:56 ` Eli Zaretskii
2023-02-24 11:31 ` Dmitry Gutov
2023-02-24 11:44 ` Eli Zaretskii
2023-02-24 14:24 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-25 1:06 ` Randy Taylor
2023-02-25 2:28 ` Dmitry Gutov
2023-02-25 3:59 ` Randy Taylor
2023-02-25 13:05 ` Dmitry Gutov
2023-02-28 2:09 ` Dmitry Gutov
2023-02-25 8:05 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0a7637d-a1ff-e22d-c6b5-b292b712b0e0@yandex.ru \
--to=dgutov@yandex.ru \
--cc=61655@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=dev@rjt.dev \
--cc=jacob.fai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.