From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Invoking gdb hangs after tweak in comint.el Date: Mon, 18 Mar 2019 17:47:29 -0700 Organization: UCLA Computer Science Department Message-ID: References: <5C878139.4050903@gmx.at> <48c720eddbcc3f378465cdd47813a2ff49da2004.camel@acm.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------D2C458AF0A632BE98ED5A52D" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="190654"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 To: =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= , martin rudalics , emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 19 01:48:42 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h62vp-000nUH-0i for ged-emacs-devel@m.gmane.org; Tue, 19 Mar 2019 01:48:41 +0100 Original-Received: from localhost ([127.0.0.1]:49563 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h62vo-0005K0-2A for ged-emacs-devel@m.gmane.org; Mon, 18 Mar 2019 20:48:40 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h62uw-0005IK-Hy for emacs-devel@gnu.org; Mon, 18 Mar 2019 20:47:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h62us-0007Gr-Az for emacs-devel@gnu.org; Mon, 18 Mar 2019 20:47:46 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:43484) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h62um-00079q-UG for emacs-devel@gnu.org; Mon, 18 Mar 2019 20:47:39 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id AF2FC1615DC; Mon, 18 Mar 2019 17:47:30 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id x3dqcJa3c2Km; Mon, 18 Mar 2019 17:47:29 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 89D531615E7; Mon, 18 Mar 2019 17:47:29 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id GAYmDZUv0FM3; Mon, 18 Mar 2019 17:47:29 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 6E4E11615D0; Mon, 18 Mar 2019 17:47:29 -0700 (PDT) Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECH In-Reply-To: <48c720eddbcc3f378465cdd47813a2ff49da2004.camel@acm.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234346 Archived-At: This is a multi-part message in MIME format. --------------D2C458AF0A632BE98ED5A52D Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 3/12/19 5:07 AM, Mattias Engdeg=C3=A5rd wrote: > > A comint expert needs to look at it, but since the loop never worked, > perhaps it could be removed entirely? Stefan would be a good person to look at it since he wrote the code. In the meantime I installed the attached, with a commit message that I hope explains things. --------------D2C458AF0A632BE98ED5A52D Content-Type: text/x-patch; name="0001-Remove-buggy-regexp-use-in-comint-output-filter.patch" Content-Disposition: attachment; filename*0="0001-Remove-buggy-regexp-use-in-comint-output-filter.patch" Content-Transfer-Encoding: quoted-printable >From 8bd3aa929a0ce6510d7c7550070f569caa65ec5e Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Mon, 18 Mar 2019 17:44:21 -0700 Subject: [PATCH] Remove buggy regexp use in comint-output-filter MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit This reverts commit 2012-07-02T16:18:02!monnier@iro.umontreal.ca which perhaps could be rethought and recommitted, and perhaps it=E2=80=99s no longer needed now that comint-use-prompt-regexp is almost always nil. * lisp/comint.el (comint-output-filter): Don=E2=80=99t try to skip repeated prompts, since comint-prompt-regexp typically begins with "^" and the resulting "^^" in the regular expression does not have the desired effect. Noted by Mattias Engdeg=C3=A5rd in: https://lists.gnu.org/r/emacs-devel/2019-03/msg00380.html --- lisp/comint.el | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/lisp/comint.el b/lisp/comint.el index a71821baa5..d21cc1378f 100644 --- a/lisp/comint.el +++ b/lisp/comint.el @@ -2072,20 +2072,6 @@ comint-output-filter (goto-char (process-mark process)) (set-marker comint-last-output-start (point)) =20 - ;; Try to skip repeated prompts, which can occur as a result= of - ;; commands sent without inserting them in the buffer. - (let ((bol (save-excursion (forward-line 0) (point)))) ;No f= ields. - (when (and (not (bolp)) - (looking-back comint-prompt-regexp bol)) - (let* ((prompt (buffer-substring bol (point))) - (prompt-re (concat "\\`" (regexp-quote prompt)))) - (while (string-match prompt-re string) - (setq string (substring string (match-end 0))))))) - (while (string-match (concat "\\(^" comint-prompt-regexp - "\\)\\1+") - string) - (setq string (replace-match "\\1" nil nil string))) - ;; insert-before-markers is a bad thing. XXX ;; Luckily we don't have to use it any more, we use ;; window-point-insertion-type instead. --=20 2.20.1 --------------D2C458AF0A632BE98ED5A52D--