From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349) Date: Wed, 31 Aug 2022 13:35:25 +0300 Message-ID: References: <166171593185.16640.41619657947456727@vcs2.savannah.gnu.org> <20220828194533.23A6BC00889@vcs2.savannah.gnu.org> <87r10znm0y.fsf@gnus.org> <83fshfvvyn.fsf@gnu.org> <999d1cb2-6b7f-8020-5202-e919278d895e@yandex.ru> <877d2pnqup.fsf@yahoo.com> <86zgfknc9a.fsf@mail.linkov.net> <87sflc91q7.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13625"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Cc: Po Lu , "Alfred M. Szmidt" , eliz@gnu.org, emacs-devel@gnu.org To: Lars Ingebrigtsen , Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 31 12:37:55 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oTL6Z-0003Ls-3k for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Aug 2022 12:37:55 +0200 Original-Received: from localhost ([::1]:41708 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oTL6Y-000201-61 for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Aug 2022 06:37:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTL4j-0000iU-Ky for emacs-devel@gnu.org; Wed, 31 Aug 2022 06:36:04 -0400 Original-Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]:33648) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oTL4h-00087Y-S8; Wed, 31 Aug 2022 06:36:01 -0400 Original-Received: by mail-wr1-x42d.google.com with SMTP id k9so17706308wri.0; Wed, 31 Aug 2022 03:35:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc; bh=6sCLbtIzpoNtSfq88g8HaeKJgI43Vo+Wef3pW7+8gcM=; b=frr4AOdanfKDspWLT7vT6LYpsM0XnpirX6nhiB3HZc0VwLrfL9wzuk/3+4UtDh0Mda uCgqMP1VjvqKrKgxD/qZW5Pvken4w1GmvQUenFqvm4pAmJD4Pk6u4XlPOLN5kPIxW9bt /93oPh3wNcqGSVi6bihMs64nUjqg0eHVg1hYENjJi7kPwWV1cloEnngiMEZNmEsH/+cp dRHh8FbvPCf6uR6PZlsEIjqE7RXH+vm2Pm477JYwug9OkVw9QzZWBw1XukE805W3rExX R73fodVAhPYSAHdXvFP9hrsFqFdHfw8z6+lmgwW218Iur3Zs1g2p0AIjCjyUCDG0lp0s buzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc; bh=6sCLbtIzpoNtSfq88g8HaeKJgI43Vo+Wef3pW7+8gcM=; b=r42oygPgRQKcUG08hdMN66qsHVwpDWFEhDqOPGOQaOT++yF6jUzR+L8YNFRiIPH3qQ /M+Dt2hxgxb6jF8Lz4Pm8PG1pEqycU8bbAgBaBR15NlUBNRQEof9uu7tRuRSOVyymaf0 rnD0zeXeXtzV3X151uY+XgEdUiv4RUVRW3i7xWX2EASzaxODXXjQ30cXC6hZi/y/xTJ5 zpifTfi5qmX8zlLlqZsGhZ/XicEB7BxfGrm70ZuMKuV4jkTau+ZIyLZPktWPXh4hpgyu V9Qf95c/1H+djYBTBdNid4+hN/PVLZJIlt1Hkbvqj7C2+RcFC7wu/bH25QowVUU+hqmF vcfA== X-Gm-Message-State: ACgBeo2LPNG4CTdYXLt6JcU4F77FF7ZhFkJ2TMowQMl066yER7OflPi8 QaCUxnM7YArzpRXZTfUE2nSkPbb+cEY= X-Google-Smtp-Source: AA6agR588xvtuQNv/Py+dpr/91nMK7AEpKw6Vs1b5l5vSHiAVcuczZI18j0aGbReFEZSs2CAfokPig== X-Received: by 2002:a5d:5391:0:b0:225:55cc:84fd with SMTP id d17-20020a5d5391000000b0022555cc84fdmr11930117wrv.719.1661942127613; Wed, 31 Aug 2022 03:35:27 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id m15-20020a7bcb8f000000b003a83b066401sm1669646wmi.31.2022.08.31.03.35.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Aug 2022 03:35:27 -0700 (PDT) Content-Language: en-US In-Reply-To: <87sflc91q7.fsf@gnus.org> Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=raaahh@gmail.com; helo=mail-wr1-x42d.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, GAPPY_SUBJECT=0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294409 Archived-At: On 31.08.2022 12:55, Lars Ingebrigtsen wrote: > Juri Linkov writes: > >>> Might use some extra polish, though, if people also encounter the one weird >>> error about "buffer already killed" that I saw a few times but then stopped >>> after a restart. >> >> Thanks, looks universal enough to handle all backends. > > I hope that the already-implemented safe version for Git doesn't get > lost, though. Definitely not. It's simpler, faster and, by design, more reliable. > Emacs' number one job is to never lose people's data, and the current > code is safe in that regard. This new, more general code, does not look > safe: If something goes wrong (like the computer going down) in the > middle of this operation, we lose people's files, and that's not > acceptable. Those files have been copied to a directory, so they should always be recoverable, no? > And that's not unlikely, because a checkin in some VCs means talking > over the network, so anything can fail (or hang), basically.