From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Cl=c3=a9ment_Pit-Claudel?= Newsgroups: gmane.emacs.devel Subject: Re: Patch upstream Git for Elisp diff hunk headings Date: Thu, 11 Feb 2021 14:13:45 -0500 Message-ID: References: <87czx68y4i.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13540"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 11 21:00:05 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lAI8D-0003Pp-A3 for ged-emacs-devel@m.gmane-mx.org; Thu, 11 Feb 2021 21:00:05 +0100 Original-Received: from localhost ([::1]:48110 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lAI8C-00005r-5E for ged-emacs-devel@m.gmane-mx.org; Thu, 11 Feb 2021 15:00:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50182) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAHPT-0007S1-AO for emacs-devel@gnu.org; Thu, 11 Feb 2021 14:13:51 -0500 Original-Received: from mail-qt1-x82f.google.com ([2607:f8b0:4864:20::82f]:42236) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lAHPR-0002TX-Iz for emacs-devel@gnu.org; Thu, 11 Feb 2021 14:13:51 -0500 Original-Received: by mail-qt1-x82f.google.com with SMTP id e15so4963442qte.9 for ; Thu, 11 Feb 2021 11:13:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=1YOlc0WiGVyGR6RET2Hn/vBIuXIxb8iqcFKhNFUrvgU=; b=Ncpl8wr0YHWHrpAV/lc6dLpQh4sVeDQkIFjli8MlMFXAUjURgYYlsjyWloX2I8Kt1P pcrmf576kolwlKyFYIxQwhk4qPLjQhTwpy7+NA6JrCNo01lMk4mPJGbwhE0Qi4qR5roC D9yRQYMufWGkwNwXyD32R0h6CcUqQloPoTKWiymOXQ2BPyKJ7uoI898iAo3W05uEdd5D tRUTjRIpVYZEpmHcqurU2NEO8XuDnw3rYvnEz09nC7234V7eAAyLW6GQExEQd6PZCuDW BiFFkuHjiDH1dwXGeJc3tsgGQ6su/j9+DzsXyDEQNIz3+Kdprogsxh28p4Hf6AF7rG15 1i0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1YOlc0WiGVyGR6RET2Hn/vBIuXIxb8iqcFKhNFUrvgU=; b=mKsCLpwk55LjhQmyxfZYZIvVE9j93RaH8idx+TI8lHSFKf9w1P7fSHM72rP0z33fHm JBdoyKpZrjixPlT7UKOG2f9c8NeVWg+sxRyBRZJgyEfC2hdgFrn4+tq4UBbVwCwvnAZE yMxdY7j/M/oI50NKltU3YKPpAR6oQt/Mwf60v3HZBNtbAzZWkm0b9vw9L3/gS270iD6/ +v2s2PXj77lO9PpnvZR8EzV6iB7I/zposYSQP/stu0YBlsNvsb/PVMTyWPNchQexF1xt I5rZ5Wzo2zJ5Xkd6Sr8ORULufW4/GV3A0uJEISGv3FvxoSuFQD80gWz6LWSEhjBfGTRD shXg== X-Gm-Message-State: AOAM5329q3jU7AZ0a7LJTRM+nGZ37WSuKmXGg7oh4eEYD69q6NOwkEyD qi3wj22Z77ijIlhXy+yLa1e0+zXA1os= X-Google-Smtp-Source: ABdhPJwdoBL5SwcaFlh8qhg5zxgOUfrkfI9t8hXIkv52ii3mrzKcdZLi9wEhdosZmMnYZ+ZINsRdwQ== X-Received: by 2002:ac8:ecd:: with SMTP id w13mr8911342qti.91.1613070826332; Thu, 11 Feb 2021 11:13:46 -0800 (PST) Original-Received: from [192.168.1.6] (c-24-61-240-80.hsd1.ma.comcast.net. [24.61.240.80]) by smtp.googlemail.com with ESMTPSA id o64sm4552308qka.43.2021.02.11.11.13.45 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Feb 2021 11:13:46 -0800 (PST) In-Reply-To: Content-Language: en-GB Received-SPF: pass client-ip=2607:f8b0:4864:20::82f; envelope-from=cpitclaudel@gmail.com; helo=mail-qt1-x82f.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.119, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:264433 Archived-At: On 2/11/21 1:27 PM, Adam Spiers wrote: > While of course no one is claiming that this is technically correct in > all cases, I don't think I can actually recall ever seeing a single > instance of a top-level form which *was* indented. This heuristic is going to break for `eval-and-compile` forms, which are reasonably common. Maybe combine both heuristics and detect both `(def` at any indentation and `(` in column 0?