From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel Subject: Re: MPS: dangling markers Date: Mon, 01 Jul 2024 21:08:07 +0000 Message-ID: <_nyaStUr9UjwGJZ-bqaGNyxgCMuh-bglMdWw2rpGNja9pdNct6lfF2QXthIQFfjn2-n-T3R4WCuHMLdmIuoRzzAfuHrw0Q1rq3V-5oFLzDE=@protonmail.com> References: <87v81u85hv.fsf@localhost> <1osQTI7Swoo72EJbCzzi4zqVXuC5hSlYEXwLtnal8_pyYL7oRCNSJg20XgBRjffZ344Wj7lwFDc9JSMsQ-3su6uXQ8hYSfYleRn-4GRrykI=@protonmail.com> <868qyldjqi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_gJUc4seOM5IBVDpen1i1hHYQMEL4viX6LfiPAUDll8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16375"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, yantar92@posteo.net, monnier@iro.umontreal.ca, emacs-devel@gnu.org, eller.helmut@gmail.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 02 04:24:06 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sOTBe-0003y8-1f for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Jul 2024 04:24:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sOTAz-0002Nr-Nz; Mon, 01 Jul 2024 22:23:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOOG4-0005xO-Fe for emacs-devel@gnu.org; Mon, 01 Jul 2024 17:08:21 -0400 Original-Received: from mail-4322.protonmail.ch ([185.70.43.22]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOOG2-0008WR-D4; Mon, 01 Jul 2024 17:08:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1719868092; x=1720127292; bh=dt7braKfP7DSuXm0ZXwKNrZSdstvQehl0pq4Vtjkvhc=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=caqS4BIbBUaLFtqnUH85Uflt111ztwerNVscpU4bVWcXvEorDpBS947IGmU9G58LE fLqicuLalOzP6J8hSAyISLnK33yPLOcDoNj38Q3nIeadQXwEZKBfFjCmpaZU53Uujf 7/Kaq6bPe7dZgxY2n9rHQWOgudwXb0aDW1uQ9fDAPj3HMUAd1FEnZQ9swxYkUt68c9 vDbjB6ii4kja2jWaQW1dOsSy7V0lsqGtOGK4uVL51HNmPzLRqF1KPUIv/29hKAF7vo MsuhRqG9EHqUFwQHV0x7K6mxT4WAeLX1FyDh9kr9zM7kzTLRy+gnZQcgvRhGNr6S+Y 8TaqOEz7OnEbQ== In-Reply-To: <868qyldjqi.fsf@gnu.org> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 73dd3837da9aa78b34826efe8518c83a61979a79 Received-SPF: pass client-ip=185.70.43.22; envelope-from=pipcet@protonmail.com; helo=mail-4322.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 01 Jul 2024 22:23:14 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321083 Archived-At: This is a multi-part message in MIME format. --b1_gJUc4seOM5IBVDpen1i1hHYQMEL4viX6LfiPAUDll8 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Monday, July 1st, 2024 at 18:56, Eli Zaretskii wrote: > The 32-bit build of the branch is now broken: dumping dies with Sorry, it took me a while to reproduce this because the default build worke= d fine, I had to --enable-checking to get something like your error, though= in my case it was clearly the set_weak_hash_hash_value call that was to bl= ame. I incorrectly assumed sxhash, Fsxhash, and the hash value in an equal-based= hash table were all the same number; in reality, sxhash is 32 bits on a 32= -bit system, 64 bits on a 64-bit system, Fsxhash is 30 bits on a 32-bit sys= tem, 62 bits on a 64-bit system, and the hash value is 32 bits on all syste= ms. Long story short, would you be able to try this patch and see whether you g= et a clean dump? I do here... diff --git a/src/lisp.h b/src/lisp.h index 0f5a5410081..75146bd7715 100644 --- a/src/lisp.h +++ b/src/lisp.h @@ -2997,7 +2997,7 @@ SXHASH_REDUCE (EMACS_UINT x) reduce_emacs_uint_to_hash_hash (EMACS_UINT x) { verify (sizeof x <=3D 2 * sizeof (hash_hash_t)); - return (sizeof x =3D=3D sizeof (hash_hash_t) + return 0x1fffffff & (sizeof x =3D=3D sizeof (hash_hash_t) =09 ? x =09 : x ^ (x >> (8 * (sizeof x - sizeof (hash_hash_t))))); } Obviously that's not a permanent fix. Thanks Pip --b1_gJUc4seOM5IBVDpen1i1hHYQMEL4viX6LfiPAUDll8 Content-Type: text/x-patch; name=0004-mps-weak-hash-tables.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0004-mps-weak-hash-tables.patch ZGlmZiAtLWdpdCBhL3NyYy9saXNwLmggYi9zcmMvbGlzcC5oCmluZGV4IDBmNWE1NDEwMDgxLi43 NTE0NmJkNzcxNSAxMDA2NDQKLS0tIGEvc3JjL2xpc3AuaAorKysgYi9zcmMvbGlzcC5oCkBAIC0y OTk3LDcgKzI5OTcsNyBAQCBTWEhBU0hfUkVEVUNFIChFTUFDU19VSU5UIHgpCiByZWR1Y2VfZW1h Y3NfdWludF90b19oYXNoX2hhc2ggKEVNQUNTX1VJTlQgeCkKIHsKICAgdmVyaWZ5IChzaXplb2Yg eCA8PSAyICogc2l6ZW9mIChoYXNoX2hhc2hfdCkpOwotICByZXR1cm4gKHNpemVvZiB4ID09IHNp emVvZiAoaGFzaF9oYXNoX3QpCisgIHJldHVybiAweDFmZmZmZmZmICYgKHNpemVvZiB4ID09IHNp emVvZiAoaGFzaF9oYXNoX3QpCiAJICA/IHgKIAkgIDogeCBeICh4ID4+ICg4ICogKHNpemVvZiB4 IC0gc2l6ZW9mIChoYXNoX2hhc2hfdCkpKSkpOwogfQo= --b1_gJUc4seOM5IBVDpen1i1hHYQMEL4viX6LfiPAUDll8--