From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#71178: Batch ert wrongly aborts a test run, and wrongly fails to say why. Date: Mon, 28 Oct 2024 18:10:43 +0000 Message-ID: References: <87ikz0xrew.fsf@neverwas.me> <871q5moycr.fsf@neverwas.me> <877cf3nily.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30028"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acm@muc.de, Stefan Monnier , 71178@debbugs.gnu.org To: "J.P." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 28 19:11:48 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t5UDT-0007al-Hp for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Oct 2024 19:11:47 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t5UDC-0005Ex-Oa; Mon, 28 Oct 2024 14:11:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t5UD8-0005Ef-5i for bug-gnu-emacs@gnu.org; Mon, 28 Oct 2024 14:11:26 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t5UD7-0002Nc-Jw for bug-gnu-emacs@gnu.org; Mon, 28 Oct 2024 14:11:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=From:In-Reply-To:MIME-Version:References:Date:To:Subject; bh=Wv1a+xRBFLnbcz2UnJtmwFiOcU459ngRdx+Fb0lWmFM=; b=mDvZEHHB68YoxHiVIwmQM5iLOoZR/nnGJ/9Kss5dLwN/OEw9Adid765u2dpTqc15WQIIB6BhoRyLVilHFndauSKhNZ20AB6MJz0zhrEFR0D/Qqmd43rlPWRoHl2G1LKRLWs2LALG5/NLcD/Dtt1zQ1Y+zEWeX3EDlkPdjzQGTVokvyG1ukYy16AIhmx8UP20HLjQhjl4I7UEp37wdefSlr162MMsfeE14t5qf+DnXJxGyav/nTCP3g57YGItDwVnWaQIw7+iMqXMfScveDpdOyd2543ZxHUOGX0Vlnd0PKVfFFlfbdE9cjJrEgVu+W2sZTPD3NlUFmmHlEGdOPT//Q==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t5UDh-00056W-OW for bug-gnu-emacs@gnu.org; Mon, 28 Oct 2024 14:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Oct 2024 18:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71178 X-GNU-PR-Package: emacs Original-Received: via spool by 71178-submit@debbugs.gnu.org id=B71178.173013909119580 (code B ref 71178); Mon, 28 Oct 2024 18:12:01 +0000 Original-Received: (at 71178) by debbugs.gnu.org; 28 Oct 2024 18:11:31 +0000 Original-Received: from localhost ([127.0.0.1]:54669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t5UDD-00055j-0N for submit@debbugs.gnu.org; Mon, 28 Oct 2024 14:11:31 -0400 Original-Received: from mail.muc.de ([193.149.48.3]:28177) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t5UDB-00055S-8E for 71178@debbugs.gnu.org; Mon, 28 Oct 2024 14:11:30 -0400 Original-Received: (qmail 36944 invoked by uid 3782); 28 Oct 2024 19:10:44 +0100 Original-Received: from muc.de (p4fe15284.dip0.t-ipconnect.de [79.225.82.132]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Mon, 28 Oct 2024 19:10:44 +0100 Original-Received: (qmail 14054 invoked by uid 1000); 28 Oct 2024 18:10:43 -0000 Content-Disposition: inline In-Reply-To: <877cf3nily.fsf@neverwas.me> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294448 Archived-At: Hello, J.P. On Wed, Jun 05, 2024 at 15:13:29 -0700, J.P. wrote: > "J.P." writes: > >> I think I'd rather the test should stay there a bit longer. It > >> highlights problems in pcase.el and ert.el which might get fixed sooner > >> if the test is still there. _MIGHT_ (here's hoping!). > > Good point. I've added a FIXME to remind myself or some future person to > > delete the test once things have settled. > The issue of the large pcase expansion appears to have been addressed by > 16fc5b6c0c7 * pcase.el (\`): Try and handle large patterns better > I have therefore deleted the offending test. > I'm leaving this bug open because its main concern is the absence of > adequate reporting under certain failure conditions. Thanks. Back in the springtime, I identified the cause of my particular bug, namely the backtrace function trying to print a copy of the too big structure which triggered the bug in the first place. This led to a recursive error signalling. Stefan Monnier amended pcase earlier on this year better to handle "big" structures, and I think you deleted the ert test which triggered the bug anyway. The circumstances which triggered this bug don't seem to have occurred in the last few months. So it seems it is now time to close this bug. Would you have anything against me closing it as "won't fix"? Thanks! -- Alan Mackenzie (Nuremberg, Germany).