From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#71934: comp--spill-lap-function and closure (wad: bug#71934: 31.0.50; edebug--called-interactively-skip vs. new fun objects) Date: Sat, 6 Jul 2024 14:27:02 +0000 Message-ID: References: <87bk3b8h2n.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11820"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acm@muc.de, Eli Zaretskii , Andrea Corallo , Stefan Monnier , 71934@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 06 16:28:16 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sQ6Od-0002kN-WD for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Jul 2024 16:28:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sQ6OQ-0007JD-8w; Sat, 06 Jul 2024 10:28:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQ6ON-0007H5-Ow for bug-gnu-emacs@gnu.org; Sat, 06 Jul 2024 10:27:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sQ6OM-0005kZ-51 for bug-gnu-emacs@gnu.org; Sat, 06 Jul 2024 10:27:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sQ6OP-0002Vq-Ih for bug-gnu-emacs@gnu.org; Sat, 06 Jul 2024 10:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Jul 2024 14:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71934 X-GNU-PR-Package: emacs Original-Received: via spool by 71934-submit@debbugs.gnu.org id=B71934.17202760359586 (code B ref 71934); Sat, 06 Jul 2024 14:28:01 +0000 Original-Received: (at 71934) by debbugs.gnu.org; 6 Jul 2024 14:27:15 +0000 Original-Received: from localhost ([127.0.0.1]:46528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQ6Nf-0002UX-2I for submit@debbugs.gnu.org; Sat, 06 Jul 2024 10:27:15 -0400 Original-Received: from mail.muc.de ([193.149.48.3]:13709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQ6Nc-0002UI-Dg for 71934@debbugs.gnu.org; Sat, 06 Jul 2024 10:27:13 -0400 Original-Received: (qmail 8350 invoked by uid 3782); 6 Jul 2024 16:27:03 +0200 Original-Received: from muc.de (p4fe15482.dip0.t-ipconnect.de [79.225.84.130]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 06 Jul 2024 16:27:02 +0200 Original-Received: (qmail 2991 invoked by uid 1000); 6 Jul 2024 14:27:02 -0000 Content-Disposition: inline In-Reply-To: <87bk3b8h2n.fsf@web.de> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288499 Archived-At: Hello, Michael. On Sat, Jul 06, 2024 at 03:06:24 +0200, Michael Heerdegen wrote: > Alan Mackenzie writes: > > > > All very clever arguments, no doubt, but in the end it means you > > > > cannot native compile foo. > > > To obey the docstring, .... > > Forget that doc string, just do what is right, expected, and convenient > > for Emacs users, and adjust the doc string afterwards. > We are actually trying to do that, but we don't understand the code > because of the lacking or wrong documentation. Would that code be comp--spill-lap-function, perhaps? There are currently three functions with that name, each for a different type of argument. It's apparent that the one that used to work, (cl-defmethod comp--spill-lap-function ((form list)) , no longer works since function forms were converted to a different format in March. It needs modifying to handle the new format. > Maybe we already had introduced a regression because of that. And now > three people try to guess what the code does. Our time is also > valuable, Alan. This documentation is important. I don't really see where the problem is: comp--spill-lap-function, all versions, isolates the Lisp source form, passes it to the byte compiler and receives the intermediate compiled form in the hash table byte-to-native-lambdas-h. This intermediate form is then fed to the native compilation engine. Or am I not understanding what you're asking? > Michael. -- Alan Mackenzie (Nuremberg, Germany).