From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#71934: comp--spill-lap-function and closure (wad: bug#71934: 31.0.50; edebug--called-interactively-skip vs. new fun objects) Date: Fri, 5 Jul 2024 16:48:21 +0000 Message-ID: References: <87sewo5vym.fsf@web.de> <87zfqwh1gb.fsf@web.de> <86o77c75jd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4397"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Michael Heerdegen , acm@muc.de, Eli Zaretskii , Andrea Corallo , 71934@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 05 18:49:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sPm7c-00011P-IA for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Jul 2024 18:49:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPm7J-0007YL-4h; Fri, 05 Jul 2024 12:49:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPm7H-0007Y6-FY for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2024 12:48:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPm7H-0003n0-6u for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2024 12:48:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sPm7J-0004R1-UT for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2024 12:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jul 2024 16:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71934 X-GNU-PR-Package: emacs Original-Received: via spool by 71934-submit@debbugs.gnu.org id=B71934.172019811317014 (code B ref 71934); Fri, 05 Jul 2024 16:49:01 +0000 Original-Received: (at 71934) by debbugs.gnu.org; 5 Jul 2024 16:48:33 +0000 Original-Received: from localhost ([127.0.0.1]:44891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPm6r-0004QL-Eo for submit@debbugs.gnu.org; Fri, 05 Jul 2024 12:48:33 -0400 Original-Received: from mail.muc.de ([193.149.48.3]:41080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPm6q-0004Q8-DA for 71934@debbugs.gnu.org; Fri, 05 Jul 2024 12:48:32 -0400 Original-Received: (qmail 75644 invoked by uid 3782); 5 Jul 2024 18:48:23 +0200 Original-Received: from muc.de (pd953a1ab.dip0.t-ipconnect.de [217.83.161.171]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 05 Jul 2024 18:48:22 +0200 Original-Received: (qmail 15642 invoked by uid 1000); 5 Jul 2024 16:48:21 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288428 Archived-At: Hello, Stefan. On Fri, Jul 05, 2024 at 11:48:10 -0400, Stefan Monnier wrote: > >> >> Andrea, can you take a look at this, please? > >> > Yep, I believe that code does not require to be changed, the input of > >> > comp--spill-lap-function is a form not an interpred function. > >> But then why does it check for `closure`? > > Back in 2023, one of the forms this function found itself unable to > > compile was a closure. So I fixed this for bug #64646. > But there is no such thing as a *form* that looks like > (closure ...), so if we found such a thing either it was a bug or it > means that other function values like byte-code (or the new > `interpreted-function`s) could appear there and should arguably be > handled as well. Not sure what you mean by "no such thing as a form ... like a closure". I bumped into one last summer. In particular (in my development repo fixing bug #64646) I put this into *scratch*: (defconst foo (lambda (baz) (car baz))) , evaluated it with C-x C-e and then M-: (native-compile foo). This threw the error "Cannot native-compile, form is not a lambda". The value of foo had been turned into a form (closure ....). So I fixed comp--spill-lap-function (form version) so as to compile that form. I've no idea how Emacs would handle that defconst now. > Stefan -- Alan Mackenzie (Nuremberg, Germany).