From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#69525: 30.0.50; MacOS: New warnings on stderr Date: Tue, 5 Mar 2024 12:59:30 +0000 Message-ID: References: <86a5nfnuxl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2641"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69525@debbugs.gnu.org, Eli Zaretskii To: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 05 14:01:28 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rhUQC-0000Tp-9L for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Mar 2024 14:01:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rhUPj-0001gs-VD; Tue, 05 Mar 2024 08:01:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhUPK-0001e5-5r for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2024 08:00:37 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rhUPI-0003Wd-5I for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2024 08:00:33 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rhUPm-0008Vy-Al for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2024 08:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Mar 2024 13:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69525 X-GNU-PR-Package: emacs Original-Received: via spool by 69525-submit@debbugs.gnu.org id=B69525.170964361325215 (code B ref 69525); Tue, 05 Mar 2024 13:01:02 +0000 Original-Received: (at 69525) by debbugs.gnu.org; 5 Mar 2024 13:00:13 +0000 Original-Received: from localhost ([127.0.0.1]:46918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhUOz-0006XZ-Bn for submit@debbugs.gnu.org; Tue, 05 Mar 2024 08:00:13 -0500 Original-Received: from dane.soverin.net ([185.233.34.150]:33973) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhUOu-0005sl-SI for 69525@debbugs.gnu.org; Tue, 05 Mar 2024 08:00:12 -0500 Original-Received: from smtp.soverin.net (c04smtp-lb01.int.sover.in [10.10.4.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dane.soverin.net (Postfix) with ESMTPS id 4Tpwd01g8zz56; Tue, 5 Mar 2024 12:59:32 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [10.10.4.99]) by soverin.net (Postfix) with ESMTPSA id 4Tpwcz2tl8z3v; Tue, 5 Mar 2024 12:59:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1709643572; bh=nXAeF1glnaBN0VIc6flpg1pJGQ7yFbciL9+RctP0LiE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XGOWjCxjHifiQT9IdyIBBu7INAT2fWMG9U5PPuLTtCfTDKncVcjJ79kRZl/rdf3GI nCvDrJMhRNa95nRGfSR5IKtpeeqHkNHuAD6hXDVY++iZaPIvdZvRPZXtnVC12r86cN xTCXU3MW66k9VSPCICHZk8QsTwJJ10GtwQuyyLCy6jVWmY5bz6zd0agGvsvnghMika +auAQWNK4baKGVkysj+zgwJTmvYDw070zWyfjgRskmcu+3mOLT/Zo8iwxMdLf1hgs4 Suc/ok7C0YaT/wk3usyC68FmgBElPCAFhRtelsL/8XI1LgzpjUcmFS0CxpbVVtkabZ pkkFi5YHqfZtA== Original-Received: from alan by faroe.holly.idiocy.org with local (Exim 4.96) (envelope-from ) id 1rhUOI-001nWg-0a; Tue, 05 Mar 2024 12:59:30 +0000 Mail-Followup-To: Alan Third , Gerd =?UTF-8?Q?M=C3=B6llmann?= , Eli Zaretskii , 69525@debbugs.gnu.org Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281048 Archived-At: On Tue, Mar 05, 2024 at 05:38:26AM +0100, Gerd Möllmann wrote: > Alan Third writes: > > > I wonder if this is something we're doing (like makeKeyAndOrderFront > > being called on the new frame and it not checking canBecomeKeyWindow) > > or if there's some other step we need to take to prevent this. I'm > > fairly sure that I've never seen these warnings so presumably they're > > new since 10.14. > > You are thinking of this in nsterm.m? > > - (void)makeKeyAndOrderFront:(id)sender > { > NSTRACE ("[EmacsWindow makeKeyAndOrderFront:]"); > > if ([self parentWindow]) > { > [self orderFront:sender]; > [self makeKeyWindow]; > } > else > [super makeKeyAndOrderFront:sender]; > } Yes. I think it's the only place we actually call makeKeyWindow ourselves, so perhaps it should have a test. Could be worth it just to see if it makes the messages go away. So I guess just something like if ([self canBecomeKeyWindow]) [self makeKeyWindow]; -- Alan Third