From: Alan Third <alan@idiocy.org>
To: "Gerd Möllmann" <gerd.moellmann@gmail.com>
Cc: 69525@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#69525: 30.0.50; MacOS: New warnings on stderr
Date: Tue, 5 Mar 2024 12:59:30 +0000 [thread overview]
Message-ID: <ZecXMr3L_eosH2__@idiocy.org> (raw)
In-Reply-To: <m2edcpe1j1.fsf@Pro.fritz.box>
On Tue, Mar 05, 2024 at 05:38:26AM +0100, Gerd Möllmann wrote:
> Alan Third <alan@idiocy.org> writes:
>
> > I wonder if this is something we're doing (like makeKeyAndOrderFront
> > being called on the new frame and it not checking canBecomeKeyWindow)
> > or if there's some other step we need to take to prevent this. I'm
> > fairly sure that I've never seen these warnings so presumably they're
> > new since 10.14.
>
> You are thinking of this in nsterm.m?
>
> - (void)makeKeyAndOrderFront:(id)sender
> {
> NSTRACE ("[EmacsWindow makeKeyAndOrderFront:]");
>
> if ([self parentWindow])
> {
> [self orderFront:sender];
> [self makeKeyWindow];
> }
> else
> [super makeKeyAndOrderFront:sender];
> }
Yes. I think it's the only place we actually call makeKeyWindow
ourselves, so perhaps it should have a test. Could be worth it just to
see if it makes the messages go away.
So I guess just something like
if ([self canBecomeKeyWindow])
[self makeKeyWindow];
--
Alan Third
next prev parent reply other threads:[~2024-03-05 12:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-03 16:18 bug#69525: 30.0.50; MacOS: New warnings on stderr Gerd Möllmann
2024-03-03 16:26 ` Eli Zaretskii
2024-03-03 17:33 ` Gerd Möllmann
2024-03-03 17:36 ` Gerd Möllmann
2024-03-03 18:06 ` Alan Third
2024-03-03 19:29 ` Gerd Möllmann
2024-03-04 9:12 ` Gerd Möllmann
2024-03-04 13:48 ` Gerd Möllmann
2024-03-04 14:43 ` Gerd Möllmann
2024-03-04 21:40 ` Alan Third
2024-03-05 4:38 ` Gerd Möllmann
2024-03-05 12:59 ` Alan Third [this message]
2024-03-05 14:31 ` Gerd Möllmann
2024-03-05 5:31 ` Gerd Möllmann
2024-07-26 10:33 ` Gerd Möllmann
2024-07-26 10:55 ` Eli Zaretskii
2024-07-26 11:02 ` Gerd Möllmann
2024-07-26 19:09 ` Alan Third
2024-07-26 19:24 ` Gerd Möllmann
2024-07-26 19:36 ` Alan Third
2024-07-27 3:56 ` Gerd Möllmann
2024-07-27 6:37 ` Eli Zaretskii
2024-07-30 6:00 ` Gerd Möllmann
2024-07-31 3:22 ` Gerd Möllmann
2024-07-31 13:51 ` Eli Zaretskii
2024-07-26 9:56 ` Gerd Möllmann
2024-07-26 18:38 ` Alan Third
2024-07-26 19:02 ` Gerd Möllmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZecXMr3L_eosH2__@idiocy.org \
--to=alan@idiocy.org \
--cc=69525@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=gerd.moellmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.