all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>, Po Lu <luangruo@yahoo.com>
Cc: jim@rees.org, 65116@debbugs.gnu.org
Subject: bug#65116: 29.1; query-replace-read-args fails reading second arg in detached minibuf
Date: Sat, 13 Jan 2024 13:47:32 +0000	[thread overview]
Message-ID: <ZaKUdDYD62ZAf0z4@ACM> (raw)
In-Reply-To: <ZaJWjuLIlcwOQzQX@ACM>

Hello again, Eli and Po.

On Sat, Jan 13, 2024 at 09:23:26 +0000, Alan Mackenzie wrote:
> On Sat, Jan 13, 2024 at 08:34:28 +0200, Eli Zaretskii wrote:
> > > Date: Fri, 12 Jan 2024 21:44:11 +0000
> > > Cc: 65116@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>, acm@muc.de
> > > From: Alan Mackenzie <acm@muc.de>

> > > On Fri, Jan 12, 2024 at 12:57:42 -0600, Jim Rees wrote:
> > > > Well that's a relief. I do have an unusual setup with detached minibuf and
> > > > focus follows mouse. There has been a lot of churn in replace.el and frame.c
> > > > lately and I keep hoping the bug will go away on its own. I don't really
> > > > understand all the focus changes in the code but I do see why they are
> > > > necessary.

> > > > I have a workaround, I have bound this to a key and use it to re-focus to
> > > > the minibuf so I can enter the 'to' text:

> > > > (select-frame-set-input-focus (window-frame (minibuffer-window)))

> > > > But that requires manual intervention so for now I'm sticking with 28.1.

> > > I've been playing with the setup for an hour or two.  It seems that
> > > performing some action in the minibuffer (say, M-x auto-revert-mode, but
> > > anything will do) causes M-% to work properly.  But then, the moment the
> > > mouse leaves the active frame or window (I'm not sure which), M-% no
> > > longer works properly, until the next minibuffer action.

> > > I know this isn't much help to you, but it should be a help to us,
> > > tracking down what's going wrong.

> > If this is WM-specific, maybe Po Lu (CC'ed) could help us understand
> > what happens here?  Perhaps some message we expect from X is not being
> > received in this scenario?

> I've got some more info which might be useful.  There are two calls to
> read_minibuf (the lowest level of minibuffer access in src/minibuf.c)
> during the query-replace processing.

> during the first access, the focus gets redirected to the minibuffer at
> L812 of minibuf.c, with

>   if (!EQ (mini_frame, selected_frame))
>       Fredirect_frame_focus (selected_frame, mini_frame);

> ..  [I don't know what undoes this focus redirection later.]  After the
> recursive edit, provided it wasn't aborted with C-g, the code moves the
> focus back to the main frame with, at L963,

>     call2 (Qselect_frame_set_input_focus, calling_frame, Qnil);

> ..  In the bug scenario, if this statement at L963 is commented out, the
> bug symptoms are no longer evident.

> So it seems something in the second read_minibuf call is preventing the
> Fredirect_frame_focus at L812 from working.

No, that is not the case.

> We can hardly avoid needing to use GDB, here.

I've done some GDBing, and what is happening in the bug case is that the
window manager, twm, is sending a focus-in event to Emacs when we start
trying to read characters.  This focus-in event switches the current
frame away from the minibuffer's frame to the main frame.

I don't know why this is happening, or why omitting the
select-frame-set-input-focus at the end of the first read_minibuf call
causes us to be spared this focus-in event on the second read_minibuf
call.

It is not clear whether the bug is in the Emacs master (with which I've
been testing) or twm.

Help from somebody more experienced with X-Windows would be welcome.

-- 
Alan Mackenzie (Nuremberg, Germany).


> -- 
> Alan Mackenzie (Nuremberg, Germany).





  reply	other threads:[~2024-01-13 13:47 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-06 17:18 bug#65116: 29.1; query-replace-read-args fails reading second arg in detached minibuf Jim Rees via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-07 15:57 ` Eli Zaretskii
2024-01-12  6:26   ` Jim Rees via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-12 12:00     ` Eli Zaretskii
2024-01-12 14:38       ` Jim Rees via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-12 15:25       ` Alan Mackenzie
2024-01-12 15:37 ` Alan Mackenzie
2024-01-12 15:59   ` Jim Rees via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-12 17:28     ` Alan Mackenzie
2024-01-12 18:57       ` Jim Rees via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-12 21:44         ` Alan Mackenzie
2024-01-13  6:34           ` Eli Zaretskii
2024-01-13  9:23             ` Alan Mackenzie
2024-01-13 13:47               ` Alan Mackenzie [this message]
2024-01-13 17:00                 ` Jim Rees via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-13 17:47                   ` Alan Mackenzie
2024-01-13 19:15                   ` Drew Adams
2024-01-13 20:18                     ` Alan Mackenzie
2024-01-13 21:19                       ` Drew Adams
2024-01-13 21:35                         ` Alan Mackenzie
2024-01-13 20:06                   ` Alan Mackenzie
2024-01-13 23:53                     ` Jim Rees via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-14  6:21                       ` Eli Zaretskii
2024-01-14 14:33                         ` Jim Rees via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-14 15:03                           ` Alan Mackenzie
2024-01-14 16:59                         ` Jim Rees via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-14 17:17                           ` Eli Zaretskii
2024-01-14 17:33                             ` Eli Zaretskii
2024-01-14 19:10                               ` Jim Rees via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-14 19:42                                 ` Eli Zaretskii
2024-01-15  0:27                                   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-15  1:29                                     ` Jim Rees via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-15  3:38                                       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-15  4:52                                         ` Jim Rees via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-15  6:31                                           ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-15 16:47                                             ` Jim Rees via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-14  0:27             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-14 14:14               ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZaKUdDYD62ZAf0z4@ACM \
    --to=acm@muc.de \
    --cc=65116@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=jim@rees.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.