From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#67568: Emacs master: Bug in byte compiler when there's an unused parameter. Date: Fri, 1 Dec 2023 16:34:18 +0000 Message-ID: References: <1c2d9219-093c-0726-13ce-2c952f6e33ba@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26006"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , acm@muc.de, 67568@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 01 17:35:05 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r96Tp-0006c7-Qy for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Dec 2023 17:35:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r96Tg-0005DS-Ba; Fri, 01 Dec 2023 11:34:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r96Td-0005Cj-SL for bug-gnu-emacs@gnu.org; Fri, 01 Dec 2023 11:34:54 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r96Td-0005TS-IW for bug-gnu-emacs@gnu.org; Fri, 01 Dec 2023 11:34:53 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r96Tm-0008WK-8k for bug-gnu-emacs@gnu.org; Fri, 01 Dec 2023 11:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Dec 2023 16:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67568 X-GNU-PR-Package: emacs Original-Received: via spool by 67568-submit@debbugs.gnu.org id=B67568.170144847732712 (code B ref 67568); Fri, 01 Dec 2023 16:35:02 +0000 Original-Received: (at 67568) by debbugs.gnu.org; 1 Dec 2023 16:34:37 +0000 Original-Received: from localhost ([127.0.0.1]:56037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r96TN-0008VY-1C for submit@debbugs.gnu.org; Fri, 01 Dec 2023 11:34:37 -0500 Original-Received: from mail.muc.de ([193.149.48.3]:53870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r96TK-0008VD-LM for 67568@debbugs.gnu.org; Fri, 01 Dec 2023 11:34:35 -0500 Original-Received: (qmail 99655 invoked by uid 3782); 1 Dec 2023 17:34:19 +0100 Original-Received: from acm.muc.de (p4fe15fc1.dip0.t-ipconnect.de [79.225.95.193]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 01 Dec 2023 17:34:18 +0100 Original-Received: (qmail 10750 invoked by uid 1000); 1 Dec 2023 16:34:18 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275335 Archived-At: Hello, Stefan. On Fri, Dec 01, 2023 at 10:40:55 -0500, Stefan Monnier wrote: > > I have a candidate for the buggy function, namely macroexp-parse-body. > Duh! > I think the patch below should fix it. It certainly will in the test case, yes. I think I understand the function better now, thanks. Are you going to commit your patch, or should I? :-) > Stefan > diff --git a/lisp/emacs-lisp/macroexp.el b/lisp/emacs-lisp/macroexp.el > index 6eb670d6dc1..6ed3e0c4896 100644 > --- a/lisp/emacs-lisp/macroexp.el > +++ b/lisp/emacs-lisp/macroexp.el > @@ -540,7 +540,9 @@ macroexp-parse-body > (while > (and body > (let ((e (car body))) > - (or (stringp e) > + (or (and (stringp e) > + ;; Only the first string can be a docstring. > + (not (delq nil (mapcar #'stringp decls)))) > (memq (car-safe e) > '(:documentation declare interactive cl-declare))))) > (push (pop body) decls))) -- Alan Mackenzie (Nuremberg, Germany).