From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#67116: byte-compile-let: reversing the order of evaluation of the clauses CAN make a difference Date: Mon, 13 Nov 2023 13:14:21 +0000 Message-ID: References: <2324648E-F860-4D57-A7A9-CF0F4F9DB57E@gmail.com> <90BD98E4-1026-4290-9D9F-7A413E670DCC@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4849"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67116@debbugs.gnu.org, acm@muc.de, Stefan Monnier To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 13 14:16:02 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r2WnJ-00018G-DJ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Nov 2023 14:16:01 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r2Wn4-0006eY-3B; Mon, 13 Nov 2023 08:15:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2Wmf-0006SX-JW for bug-gnu-emacs@gnu.org; Mon, 13 Nov 2023 08:15:23 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r2Wmf-00014X-7S for bug-gnu-emacs@gnu.org; Mon, 13 Nov 2023 08:15:21 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r2WnK-0004Sy-H6 for bug-gnu-emacs@gnu.org; Mon, 13 Nov 2023 08:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Nov 2023 13:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67116 X-GNU-PR-Package: emacs Original-Received: via spool by 67116-submit@debbugs.gnu.org id=B67116.169988131217084 (code B ref 67116); Mon, 13 Nov 2023 13:16:02 +0000 Original-Received: (at 67116) by debbugs.gnu.org; 13 Nov 2023 13:15:12 +0000 Original-Received: from localhost ([127.0.0.1]:57658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2WmW-0004RT-FM for submit@debbugs.gnu.org; Mon, 13 Nov 2023 08:15:12 -0500 Original-Received: from mail.muc.de ([193.149.48.3]:21183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2WmU-0004RC-Ox for 67116@debbugs.gnu.org; Mon, 13 Nov 2023 08:15:11 -0500 Original-Received: (qmail 17462 invoked by uid 3782); 13 Nov 2023 14:14:22 +0100 Original-Received: from acm.muc.de (pd953af3b.dip0.t-ipconnect.de [217.83.175.59]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Mon, 13 Nov 2023 14:14:22 +0100 Original-Received: (qmail 7173 invoked by uid 1000); 13 Nov 2023 13:14:21 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274253 Archived-At: Hello, Mattias. On Mon, Nov 13, 2023 at 12:19:27 +0100, Mattias Engdegård wrote: > > There's a bug here, will fix. > Now fixed on master. I'm very pleased that you reported this bug. > (Of course it didn't have anything to do with order of evaluation at > all but you already understood that.) Thanks for the fix! Yes, Stefan M. was right, here. I think it was caused by a (relatively) recent optimisation introduced into the compiler. > I didn't do a deep analysis of what code was affected by the bug but > measuring changes in the bytecode size, which is usually quite good, > only two places turned up: jit-lock--debug-fontify, which you already > noticed, and c-forward-sws in cc-engine.el, where the code > (c-put-in-sws rung-pos > (setq rung-pos (point) > last-put-in-sws-pos rung-pos))) > was probably affected here. (Obviously the bug was out to get you > personally, Alan.) I'll have a look at that, sometime. It somehow doesn't feel particularly urgent at the moment. -- Alan Mackenzie (Nuremberg, Germany).