From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#64646: Master: Native compiler doesn't always compile lambda forms. Date: Wed, 8 Nov 2023 20:59:42 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35891"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acm@muc.de, 64646-done@debbugs.gnu.org To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 08 22:00:52 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r0pfP-0009CN-Tp for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Nov 2023 22:00:51 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r0pfD-00084F-7M; Wed, 08 Nov 2023 16:00:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0pex-00083F-Vd for bug-gnu-emacs@gnu.org; Wed, 08 Nov 2023 16:00:25 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r0pex-0006mQ-Md for bug-gnu-emacs@gnu.org; Wed, 08 Nov 2023 16:00:23 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r0pfa-00056x-3M for bug-gnu-emacs@gnu.org; Wed, 08 Nov 2023 16:01:02 -0500 Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Nov 2023 21:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 64646 X-GNU-PR-Package: emacs Mail-Followup-To: 64646@debbugs.gnu.org, acm@muc.de, acm@muc.de Original-Received: via spool by 64646-done@debbugs.gnu.org id=D64646.169947723419576 (code D ref 64646); Wed, 08 Nov 2023 21:01:01 +0000 Original-Received: (at 64646-done) by debbugs.gnu.org; 8 Nov 2023 21:00:34 +0000 Original-Received: from localhost ([127.0.0.1]:46375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r0pf7-00055g-SO for submit@debbugs.gnu.org; Wed, 08 Nov 2023 16:00:34 -0500 Original-Received: from mail.muc.de ([193.149.48.3]:27694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r0pf3-00055P-6U for 64646-done@debbugs.gnu.org; Wed, 08 Nov 2023 16:00:32 -0500 Original-Received: (qmail 15465 invoked by uid 3782); 8 Nov 2023 21:59:44 +0100 Original-Received: from acm.muc.de (p4fe1584b.dip0.t-ipconnect.de [79.225.88.75]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 08 Nov 2023 21:59:43 +0100 Original-Received: (qmail 25924 invoked by uid 1000); 8 Nov 2023 20:59:42 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274015 Archived-At: Hello, Andrea. On Thu, Nov 02, 2023 at 13:32:21 -0400, Andrea Corallo wrote: > Alan Mackenzie writes: > > This bug doesn't seem to be moving, so .... > > On Wed, Jul 26, 2023 at 10:57:01 -0400, Andrea Corallo wrote: > >> Alan Mackenzie writes: > >> >> I'm not 100% convinced this behaviour is a bug tho. > >> > I don't understand that. Why might it be incorrect to compile that inner > >> > lambda natively? > >> Hi Alan, > >> I'm not saying it would be incorrect. I'm suggesting that if is not > >> specified what's the expected behaviour of compiling by name the outer > >> lambda it might not be a bug. > >> When we compile a whole compilation unit we indeed have to compile all > >> functions, in this case what we promised is I think not defined. > > I still don't understand that. The doc string for native-compile says: > > Compile FUNCTION-OR-FILE into native code. > > .. I can't see any reason not also to compile inner lambda functions > > natively. > > Anyhow, to fix this bug (if such it be) is easy: > > diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el > > index 181e5ca96a1..2360fbaa494 100644 > > --- a/lisp/emacs-lisp/comp.el > > +++ b/lisp/emacs-lisp/comp.el > > @@ -1359,7 +1359,12 @@ comp-add-func-to-ctxt > > (comp-ctxt-top-level-forms comp-ctxt) > > (list (make-byte-to-native-func-def :name function-name > > :c-name c-name))) > > - (comp-add-func-to-ctxt func)))) > > + (comp-add-func-to-ctxt func)) > > + ;; Handle any lambda functions in BYTE-CODE. > > + (maphash (lambda (key val) > > + (unless (eq key (aref byte-code 1)) > > + (comp-intern-func-in-ctxt key val))) > > + byte-to-native-lambdas-h))) > > (cl-defmethod comp-spill-lap-function ((form list)) > > "Byte-compile FORM, spilling data from the byte compiler." > > What do you say? > LGTM as long as indeed it does not regress any test. Speaking of which > with the patch I guess we want a test to cover this. Thanks. I've committed a patch for this, including two extra tests which test that a nested lambda function also gets native compiled. I'm closing the bug with this post. > > Incidentally, the code in the various comp-spill-lap-function methods > > together with comp-intern-func-in-ctxt appears to have some code > > duplication. Would it be possible to have the symbol and list methods of > > comp-spill-lap-function simply call comp-intern-func-in-ctxt the way the > > string method does? That would simplify those two methods quite a bit. > Mmmh maybe, I think one has to try to see if the result is satisfactory. I've done this refactoring too. The symbol and list methods for comp-spill-lap-function now have 17 and 15 lines respectively. I hope you like it! > Thanks > Andrea -- Alan Mackenzie (Nuremberg, Germany).