From: Patrice Dumas <pertusus@free.fr>
To: Gavin Smith <gavinsmith0123@gmail.com>
Cc: Ihor Radchenko <yantar92@posteo.net>,
Eli Zaretskii <eliz@gnu.org>,
help-texinfo@gnu.org, arash@gnu.org, emacs-devel@gnu.org
Subject: Re: @anchor on @item line (was: emacs-29 889a550ca08: ; Fix Texinfo warnings)
Date: Tue, 7 Nov 2023 11:29:24 +0100 [thread overview]
Message-ID: <ZUoRhJRNRsbU_NB5@free.fr> (raw)
In-Reply-To: <ZUk+rpOzuT9nrnQB@beigestar>
On Mon, Nov 06, 2023 at 07:29:50PM +0000, Gavin Smith wrote:
> On Sun, Nov 05, 2023 at 11:30:42AM +0000, Ihor Radchenko wrote:
> > May someone please explain the correct usage of @anchor in the above
> > example and why the warning is being thrown?
>
> I don't think there's really much wrong with it. We added more warnings
> for nested commands, trying to define which commands should occur in
> certain contexts. We have given the @item command a class of
> "contain_basic_inline", which excludes anchor commands, as well as
> the cross-reference commands.
>
> I don't remember, or never knew to start with, what the justification
> was for giving @item this class.
I agree that accepting @anchor and @*ref on @item in @*table line would
be ok.
> However, for whatever reason, this use of @anchor on an @item line
> didn't trigger the warning in earlier releases.
My guess is that the code has been fixed to really use the 'flags' of
item_LINE and not the flags of @item that appears in @itemize,
@enumerate and @multitable which alreay has no restrictions in its content.
> It would be easy, I expect, to remove this warning:
>
> diff --git a/tp/Texinfo/command_data.txt b/tp/Texinfo/command_data.txt
> index 7d07b8bd54..df63c6ccd7 100644
> --- a/tp/Texinfo/command_data.txt
> +++ b/tp/Texinfo/command_data.txt
> @@ -254,8 +254,8 @@ printindex line,formattable_line,close_paragraph,global,contain_pla
> listoffloats line,formattable_line,close_paragraph,global,contain_basic_inline LINE_line
> exdent line,formatted_line,close_paragraph LINE_line
> # or nobrace skipspace, depending on the context
> -item_LINE line,formatted_line,close_paragraph,contain_basic_inline LINE_line
> -itemx line,formatted_line,close_paragraph,contain_basic_inline LINE_line
> +item_LINE line,formatted_line,close_paragraph LINE_line
> +itemx line,formatted_line,close_paragraph LINE_line
> nodedescription line,close_paragraph LINE_line
> # in index entries
> subentry line,in_index,contain_basic_inline LINE_line
> 0$
>
> However, I would like to wait to see if anybody else has any comments first.
Looks good to me.
--
Pat
next prev parent reply other threads:[~2023-11-07 10:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <169796650463.2984.6470791064475342706@vcs2.savannah.gnu.org>
[not found] ` <20231022092145.0486AC09BDB@vcs2.savannah.gnu.org>
2023-10-22 10:30 ` emacs-29 889a550ca08: ; Fix Texinfo warnings Arash Esbati
2023-10-22 11:03 ` Eli Zaretskii
2023-10-23 10:36 ` Arash Esbati
2023-10-23 12:35 ` Ihor Radchenko
2023-10-23 12:44 ` Eli Zaretskii
2023-10-23 13:24 ` Ihor Radchenko
2023-10-23 14:27 ` Eli Zaretskii
2023-10-24 9:11 ` Ihor Radchenko
2023-10-24 11:48 ` Eli Zaretskii
2023-11-05 11:30 ` @anchor on @item line (was: emacs-29 889a550ca08: ; Fix Texinfo warnings) Ihor Radchenko
2023-11-06 19:29 ` Gavin Smith
2023-11-07 10:29 ` Patrice Dumas [this message]
2023-11-12 19:23 ` @anchor on @item line Gavin Smith
2023-11-14 21:58 ` Gavin Smith
2023-11-15 3:30 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUoRhJRNRsbU_NB5@free.fr \
--to=pertusus@free.fr \
--cc=arash@gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=gavinsmith0123@gmail.com \
--cc=help-texinfo@gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.