From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#64646: Master: Native compiler doesn't always compile lambda forms. Date: Sun, 29 Oct 2023 13:21:02 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20942"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64646@debbugs.gnu.org, acm@muc.de To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 29 14:22:04 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qx5jw-0005HI-CG for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Oct 2023 14:22:04 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qx5jX-0007ek-Q0; Sun, 29 Oct 2023 09:21:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qx5jO-0007dV-QH for bug-gnu-emacs@gnu.org; Sun, 29 Oct 2023 09:21:36 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qx5jO-0002vV-C8 for bug-gnu-emacs@gnu.org; Sun, 29 Oct 2023 09:21:30 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qx5ju-0002Rd-F9 for bug-gnu-emacs@gnu.org; Sun, 29 Oct 2023 09:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Oct 2023 13:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64646 X-GNU-PR-Package: emacs Original-Received: via spool by 64646-submit@debbugs.gnu.org id=B64646.16985857119378 (code B ref 64646); Sun, 29 Oct 2023 13:22:02 +0000 Original-Received: (at 64646) by debbugs.gnu.org; 29 Oct 2023 13:21:51 +0000 Original-Received: from localhost ([127.0.0.1]:40722 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qx5ji-0002RC-HU for submit@debbugs.gnu.org; Sun, 29 Oct 2023 09:21:50 -0400 Original-Received: from mail.muc.de ([193.149.48.3]:35930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qx5je-0002Qu-HY for 64646@debbugs.gnu.org; Sun, 29 Oct 2023 09:21:48 -0400 Original-Received: (qmail 87582 invoked by uid 3782); 29 Oct 2023 14:21:07 +0100 Original-Received: from acm.muc.de (p4fe15a23.dip0.t-ipconnect.de [79.225.90.35]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 29 Oct 2023 14:21:06 +0100 Original-Received: (qmail 4909 invoked by uid 1000); 29 Oct 2023 13:21:02 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273507 Archived-At: Hello, Andrea. This bug doesn't seem to be moving, so .... On Wed, Jul 26, 2023 at 10:57:01 -0400, Andrea Corallo wrote: > Alan Mackenzie writes: > > Hello, Andrea. > > On Mon, Jul 17, 2023 at 09:17:13 -0400, Andrea Corallo wrote: > >> Alan Mackenzie writes: > >> > In the master branch: > >> > (i) emacs -Q > >> > (ii) C-x b foo.el > >> > (iii) Insert into foo.el: > >> > ;; -*- lexical-binding:t -*- > >> > (iv) M-x emacs-lisp-mode > >> > (v) Insert into foo.el: > >> > (defun foo () "foo doc string" > >> > (lambda (bar) "lambda doc string" (car bar))) > >> > (vi) With point after the function, C-x C-e to evaluate it. > >> > (vii) M-: (native-compile 'foo) > >> > This returns # > >> > (viii) M-: (foo) > >> > This returns the lambda form as a byte-compiled function. This is a bug: > >> > it should return the lambda form as a native-compiled function. > >> > Note: this bug is also in the emacs-29 branch. > >> Hi Alan, > >> I can reproduce, (native-compile 'foo) compiles only foo, compiling the > >> whole compilation unit with eg `emacs-lisp-native-compile-and-load' > >> compiles as expected also the inner lambda. > > Why would compiling a .el file compile inner lambda forms, but > > native-compile doesn't? > >> I'm not 100% convinced this behaviour is a bug tho. > > I don't understand that. Why might it be incorrect to compile that inner > > lambda natively? > Hi Alan, > I'm not saying it would be incorrect. I'm suggesting that if is not > specified what's the expected behaviour of compiling by name the outer > lambda it might not be a bug. > When we compile a whole compilation unit we indeed have to compile all > functions, in this case what we promised is I think not defined. I still don't understand that. The doc string for native-compile says: Compile FUNCTION-OR-FILE into native code. .. I can't see any reason not also to compile inner lambda functions natively. Anyhow, to fix this bug (if such it be) is easy: diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el index 181e5ca96a1..2360fbaa494 100644 --- a/lisp/emacs-lisp/comp.el +++ b/lisp/emacs-lisp/comp.el @@ -1359,7 +1359,12 @@ comp-add-func-to-ctxt (comp-ctxt-top-level-forms comp-ctxt) (list (make-byte-to-native-func-def :name function-name :c-name c-name))) - (comp-add-func-to-ctxt func)))) + (comp-add-func-to-ctxt func)) + ;; Handle any lambda functions in BYTE-CODE. + (maphash (lambda (key val) + (unless (eq key (aref byte-code 1)) + (comp-intern-func-in-ctxt key val))) + byte-to-native-lambdas-h))) (cl-defmethod comp-spill-lap-function ((form list)) "Byte-compile FORM, spilling data from the byte compiler." What do you say? Incidentally, the code in the various comp-spill-lap-function methods together with comp-intern-func-in-ctxt appears to have some code duplication. Would it be possible to have the symbol and list methods of comp-spill-lap-function simply call comp-intern-func-in-ctxt the way the string method does? That would simplify those two methods quite a bit. > Andrea -- Alan Mackenzie (Nuremberg, Germany).