From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#66750: Unhelpful text in C-h v for variables with a lambda form as value Date: Sat, 28 Oct 2023 19:59:36 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17685"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66750@debbugs.gnu.org, Andrea Corallo , Stefan Kangas , acm@muc.de To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 28 22:01:03 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qwpUL-00048m-I3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Oct 2023 22:00:53 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qwpU1-0001tH-9e; Sat, 28 Oct 2023 16:00:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qwpTz-0001sv-C0 for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2023 16:00:31 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qwpTy-0006cb-7a for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2023 16:00:30 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qwpUU-0007rF-BH for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2023 16:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Oct 2023 20:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66750 X-GNU-PR-Package: emacs Original-Received: via spool by 66750-submit@debbugs.gnu.org id=B66750.169852321730134 (code B ref 66750); Sat, 28 Oct 2023 20:01:02 +0000 Original-Received: (at 66750) by debbugs.gnu.org; 28 Oct 2023 20:00:17 +0000 Original-Received: from localhost ([127.0.0.1]:39598 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qwpTk-0007px-Mj for submit@debbugs.gnu.org; Sat, 28 Oct 2023 16:00:17 -0400 Original-Received: from mail.muc.de ([193.149.48.3]:61907) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qwpTj-0007pk-0K for 66750@debbugs.gnu.org; Sat, 28 Oct 2023 16:00:15 -0400 Original-Received: (qmail 15705 invoked by uid 3782); 28 Oct 2023 21:59:37 +0200 Original-Received: from acm.muc.de (p4fe15319.dip0.t-ipconnect.de [79.225.83.25]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 28 Oct 2023 21:59:36 +0200 Original-Received: (qmail 20781 invoked by uid 1000); 28 Oct 2023 19:59:36 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273468 Archived-At: Hello, Stefan. On Sat, Oct 28, 2023 at 15:13:16 -0400, Stefan Monnier wrote: > >> I like the idea of keeping better track of the origin of lambda > >> expressions (tho, admittedly, the same problem occurs with other kinds > >> of data: I have several times been faced with a keymap or a char-table, > >> wondering where the heel it came from). > > Maybe something similar might be possible for those type of objects. > [ Hmm... food for thought... ] > >> I took a look at > >> git log -p main..origin/feature/named-lambdas > >> but that's 127kB, so ... could [you] briefly describe the overall design > >> (IOW, how it's seen by ELisp programmers, byte-compiler hackers, and > >> ELisp users)? > > Certainly. Each lambda expression has (usually) a defun within which it > > is defined. Sometimes it's in a defvar, or defcustom. That > > @dfn{defining symbol} is recorded in the lambda form in one of three > > ways: > > (i) For a cons form, it's (cadr form), a new field inserted between the > > symbol `lambda' and the argument list. > > (ii) For a byte-compiled form, it's (aref form 5), this new field going > > after the doc string and before any interactive form in the compiled > > form. > These two change the visible representation of functions, so I wouldn't > be surprised if they break some odd hack out there. There were a few in the test suite I had to amend. > For (i), do we actually care enough to keep that info (IME the > functions are usually compiled, and if they're not the code itself > usually makes it fairly easy to find the code's origin)? I considered that for some time, and in the end thought that on grounds of consistency it would be better to put the defining symbol into the list form as well. > For (ii), why did you choose slot 5, thus moving the interactive-form > slot? Because an interactive form of nil means "(interactive)" with no arguments. Only an absent (aref form 6) means there isn't an interactive form. So it had to stay as the last slot. > > There are lots of detailed changes in eval.c and bytecomp.el (and > > friends). Also the macro `lambda' in subr.el has been amended to insert > > the current global defining-symbol if there isn't already a non-nil > > symbol in that position. > So the source code can manually provide this extra symbol in `lambda`? > Where have you found that useful? The first few functions in debug-early.el and byte-run.el, for a start. There, there is not yet a defmacro macro. Also in comp-trampoline-compile, where there doesn't seem to be any other way to get the name of the primitive into the defining symbol. I think there'll be quite a few other places, too. > >> Also, what other approaches have you considered/tried and what were the > >> problems you've encountered, if any? > > feature/named-lambdas was originally intended for use in backtraces. > > For the current bug, I've considered individually replacing each lambda > > with a named defun, so that C-h v will show that name rather than an > Hmm... as a user, rather than the enclosing definition I think I'd > expect to get some kind of source information like FILE+LINE+COL. Possibly: either is a good deal better than what we have at the moment. > If we give up on keeping that extra info in interpreted functions, the > FILE+LINE+COL information is readily available to the byte-compiler, > thanks to that famous Alan guy. :-) > Actually, the bytecode functions can already keep the FILE info (in > the form of the (FILE . OFFSET) cons cell in the docstring slot of the > bytecode object), we just opt never to expose that FILE info to the user > (we only use it to fetch the actual docstring). That's the offset in the .elc file, though, not the source. > [ Tho, admittedly, it's also that the byte-compiler only uses such > (FILE . OFFSET) for named functions, but it wouldn't be hard to change. ] > As for how/where to store the LINE+COL, I guess (aref form 5) is still > an option, although, maybe we should store that info alongside the > docstring, like we already do for the arglist. Well, the doc string is at (aref form 4). :-) > The way we do it for the arglist is hideous and a pain in the rear (I > blame the maintainers who accepted my patch back then), so it would be > an opportunity to "do it right" this time. > Stefan -- Alan Mackenzie (Nuremberg, Germany).