From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: Question on https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d0b1e3647fb4e6d889f9f999388c53daf0e67f0d Date: Thu, 21 Sep 2023 18:29:04 +0100 Message-ID: References: <04a0c0f2-a3b6-47f3-b4da-fed2dadd0ee2@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35759"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Gerd =?iso-8859-1?Q?M=F6llmann?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 21 19:29:55 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qjNUw-00094F-QH for ged-emacs-devel@m.gmane-mx.org; Thu, 21 Sep 2023 19:29:54 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qjNUH-0006RR-KV; Thu, 21 Sep 2023 13:29:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjNUF-0006R5-Rm for emacs-devel@gnu.org; Thu, 21 Sep 2023 13:29:11 -0400 Original-Received: from dane.soverin.net ([2a10:de80:1:4092:b9e9:2295:0:1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qjNUD-0005ZT-RU for emacs-devel@gnu.org; Thu, 21 Sep 2023 13:29:11 -0400 Original-Received: from smtp.soverin.net (c04smtp-lb01.int.sover.in [10.10.4.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dane.soverin.net (Postfix) with ESMTPS id 4Rs2Sc6L8yz10Gf; Thu, 21 Sep 2023 17:29:04 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [10.10.4.99]) by soverin.net (Postfix) with ESMTPSA id 4Rs2Sc4PWTzKP; Thu, 21 Sep 2023 17:29:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1695317344; bh=CATkHwOOQnH2ZWHS2rNvTSZ4KzO22bNp+65XAAz2fUU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ouC8nRZTHlomZYB1n3CWNK5s3dcfl1qmzGXmaXW3MK9oPNTgTczVOSQuH2Ge/86aN DykecmaeV2drVczH+wHnSqe67kCZ/O/4w9qvV3PU/xtwx9LCook3Fxp/VFlF/qt2UF kCBDL0fHRbUXuq903+qgrkN5Yuqwx0gLugo9X7QBX7QAIdR58rjm6Jo/4e/TxtRhrF +vZKHIDLFWwDVgaHtmiDFLQ5OAGbdLgUmy8AceRbuLTCYQbW/qyVzD9Lj0klt+HrRK hashHvIB6qDeOLv19ENljpoNnlXNm+nSLw9c6gl07epIim9b+yhpJN/SlnM+MPP4Fb MxlOkHUQhIQ2w== Original-Received: from alan by faroe.holly.idiocy.org with local (Exim 4.96) (envelope-from ) id 1qjNU8-000DDX-0W; Thu, 21 Sep 2023 18:29:04 +0100 X-Soverin-Authenticated: true Mail-Followup-To: Alan Third , Gerd =?iso-8859-1?Q?M=F6llmann?= , emacs-devel@gnu.org Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=2a10:de80:1:4092:b9e9:2295:0:1; envelope-from=alan@idiocy.org; helo=dane.soverin.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310924 Archived-At: On Thu, Sep 21, 2023 at 07:06:20PM +0200, Gerd Möllmann wrote: > On 23-09-21 18:50 , Alan Third wrote: > > On Thu, Sep 21, 2023 at 10:46:56AM +0200, Gerd Möllmann wrote: > > > On 23-09-21 8:29 , Pedro Andres Aranda Gutierrez wrote: > > > > > I'm confused... > > > > > > I assume that is nextstep/Makefile.in. We want to cp the .pdmp file only if > > > we don't do a self-contained build (...=no). > > > > Now I'm confused! > > I suspect you're all trying to confuse me :-). > > > We only have to install the pdmp file in the app bundle when doing a > > self-contained build. > > > > If your other change in Makefile.in already does that, then this cp > > isn't needed at all. > > > My aim was to not change anything in the case the build is not > self-contained, because I can't test that. > > In nextstep/Makefile.in, the cp > - is not done in the self-contained case > - is done for the non-self-contained case > (This cp was formerly done for a naked make at toplevel, not only for a make > install. That was the problem resulting in an inconistent Emacs.app.) > > In the toplevel Makefile.in > - the install is done in the self-contained case, as a substitute for the > now missing cp in nextstep/Makefile.in > - nothing is changed for the non-self-contained case > (This happens when we make install.) OK. As the author of that line of code and the FIXME I would recommend removing the cp in nextstep/Makefile.in for the non-self-contained case as well, but I don't think I can prove that it's not going to break anything as I can't really test it either! :) I guess I can just remove it myself... -- Alan Third