From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: Question on https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d0b1e3647fb4e6d889f9f999388c53daf0e67f0d Date: Thu, 21 Sep 2023 17:50:54 +0100 Message-ID: References: <04a0c0f2-a3b6-47f3-b4da-fed2dadd0ee2@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16217"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Gerd =?iso-8859-1?Q?M=F6llmann?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 21 18:51:35 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qjMtq-00040g-Tz for ged-emacs-devel@m.gmane-mx.org; Thu, 21 Sep 2023 18:51:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qjMtL-0002Qd-Oe; Thu, 21 Sep 2023 12:51:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjMtK-0002QR-7L for emacs-devel@gnu.org; Thu, 21 Sep 2023 12:51:02 -0400 Original-Received: from dane.soverin.net ([185.233.34.150]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qjMtI-0007JQ-7S for emacs-devel@gnu.org; Thu, 21 Sep 2023 12:51:01 -0400 Original-Received: from smtp.soverin.net (c04smtp-lb01.int.sover.in [10.10.4.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dane.soverin.net (Postfix) with ESMTPS id 4Rs1cc2Sfyz102; Thu, 21 Sep 2023 16:50:56 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [10.10.4.100]) by soverin.net (Postfix) with ESMTPSA id 4Rs1cb4FSJzZ1; Thu, 21 Sep 2023 16:50:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1695315056; bh=JGLmbKu/lSx91jK6DYYm0TdgJPWTCFCQ893qS1nQpBY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BOF4ISW0mw6shbiboWQ86xWstE6zHJPn16Xv9FkjwpJGShrgEWxQ1lu5iBPTlWdE8 Pd6ZDeE4PyGws9QbGo2RybCetkBoFXtAVRLRb2dTvg7sPFVz/1cSzvGB9f9E7MhwsU aPtyLPjtjBYA1V2WmP68wb8Djpr4VIaXPTNvw4GLm83dIpC5pNU99RMZxUiWO9oxER kr7Ybx+MWLy8lqmGCBGsZ6XPYJNEpOoG3SGv+EK4sA2iSBK75lzR7pj+rAGCaRgO8R y0jWk9LOWy9xP+mk01WDB7F56i5Ip2Ju4LImSY06AKOm9AJ8zSDeDGBZ4WvkcXHtGE TkwP1g13ApMXw== Original-Received: from alan by faroe.holly.idiocy.org with local (Exim 4.96) (envelope-from ) id 1qjMtC-000D0M-24; Thu, 21 Sep 2023 17:50:54 +0100 X-Soverin-Authenticated: true Mail-Followup-To: Alan Third , Gerd =?iso-8859-1?Q?M=F6llmann?= , emacs-devel@gnu.org Content-Disposition: inline In-Reply-To: <04a0c0f2-a3b6-47f3-b4da-fed2dadd0ee2@gmail.com> Received-SPF: pass client-ip=185.233.34.150; envelope-from=alan@idiocy.org; helo=dane.soverin.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310922 Archived-At: On Thu, Sep 21, 2023 at 10:46:56AM +0200, Gerd Möllmann wrote: > On 23-09-21 8:29 , Pedro Andres Aranda Gutierrez wrote: > > Hi > > > > reading removed FIXME in the second hunk: > > > > # FIXME: Don't install the dump file into the app bundle when > > # self-contained install is disabled. > > > > I understand that we should install if self-contained is enabled. > > > > However, I see > > > > +ifeq (${ns_self_contained},no) > > > > Shouldn't that read as > > > > +ifeq (${ns_self_contained},yes) > > > > I'm confused... > > I assume that is nextstep/Makefile.in. We want to cp the .pdmp file only if > we don't do a self-contained build (...=no). Now I'm confused! We only have to install the pdmp file in the app bundle when doing a self-contained build. If your other change in Makefile.in already does that, then this cp isn't needed at all. -- Alan Third