all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: emacs-devel@gnu.org
Subject: Applying print-length to (length string) is suboptimal.
Date: Sun, 17 Sep 2023 19:57:07 +0000	[thread overview]
Message-ID: <ZQdaExfBV-Qf2jcz@ACM> (raw)

Hello, Emacs.

Also with reference to bug #65680.

In cl-print-object (lisp/emacs-lisp/cl-print.el), the version for
strings, print-length is taken as a bound on the length of the string to
be printed.

Why?

The whole idea of print-length (and print-level) is, as far as I can make
out, to prevent infinite printing when there's a circular list, for
example.  This cannot occur for strings.

This use of print-length is relatively recent, originating in this
commit:

    commit 8a7620955b4d859caecd9a5dc9f2a986baf994fd
    Author: Gemini Lasswell <gazally@runbox.com>
    Date:   Fri Jun 15 10:26:13 2018 -0700

        Add methods for strings to cl-print

print-length is not used in the function prin1 (as contrasted with
cl-prin1).

The problem with using print-length for the max. string length is that it
is not designed for this.  When print-length is, say, 50, almost any list
or vector can be printed in full, going up to several hundred printed
characters.  With a string, the string gets rudely truncated at a mere 50
characters, which is rarely wanted.  This is a problem with the error
message at the top of a backtrace, where cl-print-string-with-limit
limits print-length to a maximum of 50 (See bug #65680).

What do people think of removing this observance of print-length from the
string version of cl-print-object?

-- 
Alan Mackenzie (Nuremberg, Germany).



             reply	other threads:[~2023-09-17 19:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-17 19:57 Alan Mackenzie [this message]
2023-09-18  9:46 ` Applying print-length to (length string) is suboptimal Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZQdaExfBV-Qf2jcz@ACM \
    --to=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.