From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#65051: internal_equal manipulates symbols with position without checking symbols-with-pos-enabled. Date: Sun, 13 Aug 2023 13:52:35 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9980"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65051@debbugs.gnu.org, acm@muc.de To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 13 15:53:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qVBX4-0002Tg-GE for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Aug 2023 15:53:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qVBWk-0003MW-SH; Sun, 13 Aug 2023 09:53:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVBWg-0003Ly-OL for bug-gnu-emacs@gnu.org; Sun, 13 Aug 2023 09:53:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qVBWg-0005Lx-Gk for bug-gnu-emacs@gnu.org; Sun, 13 Aug 2023 09:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qVBWg-0001ca-1q for bug-gnu-emacs@gnu.org; Sun, 13 Aug 2023 09:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Aug 2023 13:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65051 X-GNU-PR-Package: emacs Original-Received: via spool by 65051-submit@debbugs.gnu.org id=B65051.16919347656206 (code B ref 65051); Sun, 13 Aug 2023 13:53:02 +0000 Original-Received: (at 65051) by debbugs.gnu.org; 13 Aug 2023 13:52:45 +0000 Original-Received: from localhost ([127.0.0.1]:58429 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qVBWO-0001c2-Ks for submit@debbugs.gnu.org; Sun, 13 Aug 2023 09:52:44 -0400 Original-Received: from mx3.muc.de ([193.149.48.5]:37279) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qVBWM-0001bn-Jz for 65051@debbugs.gnu.org; Sun, 13 Aug 2023 09:52:43 -0400 Original-Received: (qmail 77468 invoked by uid 3782); 13 Aug 2023 15:52:36 +0200 Original-Received: from acm.muc.de (p4fe152a2.dip0.t-ipconnect.de [79.225.82.162]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 13 Aug 2023 15:52:35 +0200 Original-Received: (qmail 22599 invoked by uid 1000); 13 Aug 2023 13:52:35 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267366 Archived-At: Hello, Stefan. On Sat, Aug 12, 2023 at 14:07:39 -0400, Stefan Monnier wrote: > > Streamline time decoding and conversion > > * src/lisp.h (lisp_h_BASE2_EQ, BASE2_EQ): New macros and functions. > > * src/timefns.c (tzlookup, Fdecode_time): Use them. > > (Ftime_convert): Convert to symbol once, instead of many times. <===== > > .. form, if a SWP, gets replaced by its bare symbol, so that the > > following comparisons can be done by BASE_EQ rather than EQ. It's an > > optimisation, though I can't really see why it's worthwhile. > > If you remove that SWP handling, as you are proposing, you'll need to > > set these BASE_EQ's back to EQ's, too. > I see, thanks. > It's kind of odd, tho: it's the only function that does that, AFAICT. > I also can't see why `time-convert` should accept SWPs in addition to > bare symbols. In my book, it seems like passing it an SWP would be > a mistake. Anything which can accept symbols should accept SWPs when symbols-with-pos-enabled is non-nil. It's just basic consistency. > Stefan -- Alan Mackenzie (Nuremberg, Germany).