all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "Mattias Engdegård" <mattias.engdegard@gmail.com>,
	65017@debbugs.gnu.org,
	"Eric Marsden" <eric.marsden@risk-engineering.org>
Subject: bug#65017: 29.1; Byte compiler interaction with cl-lib function objects, removes symbol-function
Date: Thu, 10 Aug 2023 14:50:03 +0000	[thread overview]
Message-ID: <ZNT5G7-aPp5t9vbe@ACM> (raw)
In-Reply-To: <jwvbkffwp31.fsf-monnier+emacs@gnu.org>

Hello, Stefan.

On Wed, Aug 09, 2023 at 23:41:56 -0400, Stefan Monnier wrote:
> >> > Are you sure?
> >> Yes.
> > What about two SWPs with the same symbol but different positions?  If
> > they aren't considered EQ here, there will never be a match for the
> > first arm of the cond form in cl--labels-convert; then
> > cl--labels-convert-cache will get written, but never used.

> Nope: when it gets written, the `function` macro returns:

>     (function <THESYMWITHPOS>)

> so the macro is immediately called again with the *exact* same
> <THESYMWITHPOS>, so the second time the `function` macro is called, the
> cache does hit (and it's the only case where it should hit), making the
> second call to the macro return the *exact* `eq`-same

>     (function <THESYMWITHPOS>)

> list which is the trick that stops the infinite macroexpansion loop.

OK, thanks, I think I've got that now.

> Next time the `function` macro is invoked with a "similar" sympos the
> cache should *not* match because we don't want to accidentally replace

>     (function <SOMESYMWITHPOS>)
> with
>     (function <THESYMWITHPOS>)

> > And if, somehow, it does get used (the current code, I think), then (as
> > you write below) the argument F will get replaced by an F with the wrong
> > position.  Am I right, here?

> That's right.

OK.  So perhaps binding symbols-with-pos-enabled to nil around that eq
call could be the way to go.

> > Why must the F get replaced by a different F?  There must surely be a
> > way, a simpler way than the current cl--labels-convert, to retain the
> > current F (hence, not corrupting its position)?

> There might.  The current hack is the best I could come up with.

I'm not criticising the hack, not at all!  But it could be better
commented, and the doc string for cl--labels-convert could be more
informative.  The "why" is missing - why is necessary to handle
`function' as a macro?  I think it's to inhibit the processing of
`function' as function somewhere else, but where and why?  I think you
explained it, at least partly, in an earlier post on this thread.

> >> > If cl--labels-convert-cache is being used
> >> > inside the byte compiler, it surely needs to consider #<symbol foo at
> >> > 42> and #<symbol foo at 60> as eq?
> >> No, it should not treat them equal (when it does, it introduces an
> >> incorrect sympos and can thus lead to error messages pointing at the
> >> wrong place).
> > Then isn't what is wrong here the introduction of the incorrect SWP
> > rather than treating the two SWPs as EQ?

> I can't see how to separate one from the other here: the introduction of
> the incorrect SWP is due to treating the two SWP as `eq`.

> > This is obscure, difficult code.  :-(

> Agreed.

> > We should think about committing a fix to the original bug,
> > sometime, too.

> I'm not completely sure we agree yet on what is "the original bug", but
> obviously I agree with  your sentence :-)

I meant bug #65017.  I committed a fix for it yesterday using the patch
I posted here on Sunday, and closed the bug.

>         Stefan

-- 
Alan Mackenzie (Nuremberg, Germany).





  reply	other threads:[~2023-08-10 14:50 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-02 10:28 bug#65017: 29.1; Byte compiler interaction with cl-lib function objects, removes symbol-function Eric Marsden
2023-08-03  9:39 ` Mattias Engdegård
2023-08-03 14:43   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-03 15:37     ` Mattias Engdegård
2023-08-03 16:36       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-03 16:53         ` Mattias Engdegård
2023-08-03 17:30           ` Mattias Engdegård
2023-08-03 16:43     ` Alan Mackenzie
2023-08-03 17:30       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-03 18:22         ` Alan Mackenzie
2023-08-03 21:00           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-03 21:10         ` Alan Mackenzie
2023-08-03 21:46           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-04  9:55             ` Alan Mackenzie
2023-08-05 22:45               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-04 10:14             ` Mattias Engdegård
2023-08-04 11:11               ` Alan Mackenzie
2023-08-04 13:41                 ` Mattias Engdegård
2023-08-05 22:40               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-06 10:47                 ` Mattias Engdegård
2023-08-08  2:33                   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-04  5:35           ` Eli Zaretskii
2023-08-04 14:16             ` Alan Mackenzie
2023-08-05 20:22             ` Alan Mackenzie
2023-08-06  4:49               ` Eli Zaretskii
2023-08-04 13:22     ` Alan Mackenzie
2023-08-04 14:04       ` Eli Zaretskii
2023-08-04 14:49         ` Alan Mackenzie
2023-08-04 15:22           ` Eli Zaretskii
2023-08-04 16:43             ` Alan Mackenzie
2023-08-04 17:54               ` Eli Zaretskii
2023-08-05 22:58             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-05 22:53       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-06 11:59         ` Alan Mackenzie
2023-08-08  2:44           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-08 16:56             ` Alan Mackenzie
2023-08-10  3:41               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-10 14:50                 ` Alan Mackenzie [this message]
2023-08-12  3:28                   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-12  9:59                     ` Mattias Engdegård
2023-08-12 18:21                       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-12 10:40                     ` Mattias Engdegård
2023-08-12 16:46                     ` Alan Mackenzie
2023-08-12 18:28                       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-13 10:10                         ` Alan Mackenzie
2023-08-13 16:12                           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-14 17:10                             ` Alan Mackenzie
2023-08-03 16:11   ` Alan Mackenzie
2023-08-03 16:41     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-03 18:48       ` Alan Mackenzie
2023-08-09 12:27 ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZNT5G7-aPp5t9vbe@ACM \
    --to=acm@muc.de \
    --cc=65017@debbugs.gnu.org \
    --cc=eric.marsden@risk-engineering.org \
    --cc=mattias.engdegard@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.