From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#65017: 29.1; Byte compiler interaction with cl-lib function objects, removes symbol-function Date: Fri, 4 Aug 2023 09:55:46 +0000 Message-ID: References: <8B08E514-B2D5-48F5-BA90-4F5A9492F8F9@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39043"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 65017@debbugs.gnu.org, Eric Marsden To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 04 11:56:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qRrXn-0009uc-SE for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Aug 2023 11:56:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qRrXQ-0003j4-Iy; Fri, 04 Aug 2023 05:56:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRrXO-0003ir-RK for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 05:56:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qRrXO-0006PD-6U for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 05:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qRrXO-0004Wd-2E for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 05:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Aug 2023 09:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65017 X-GNU-PR-Package: emacs Original-Received: via spool by 65017-submit@debbugs.gnu.org id=B65017.169114295717382 (code B ref 65017); Fri, 04 Aug 2023 09:56:02 +0000 Original-Received: (at 65017) by debbugs.gnu.org; 4 Aug 2023 09:55:57 +0000 Original-Received: from localhost ([127.0.0.1]:53447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRrXI-0004WI-Lc for submit@debbugs.gnu.org; Fri, 04 Aug 2023 05:55:56 -0400 Original-Received: from mx3.muc.de ([193.149.48.5]:48029) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRrXG-0004W3-HJ for 65017@debbugs.gnu.org; Fri, 04 Aug 2023 05:55:55 -0400 Original-Received: (qmail 20404 invoked by uid 3782); 4 Aug 2023 11:55:47 +0200 Original-Received: from acm.muc.de (pd953a874.dip0.t-ipconnect.de [217.83.168.116]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 04 Aug 2023 11:55:47 +0200 Original-Received: (qmail 5837 invoked by uid 1000); 4 Aug 2023 09:55:46 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266657 Archived-At: Hello, Stefan. On Thu, Aug 03, 2023 at 17:46:44 -0400, Stefan Monnier wrote: > > Sorry about my last post. I now see what the core problem is, namely > > that (equal 'equal #) is returning non-nil. > This is not really the core problem IIUC since `cl-macs.el` uses `eq` > rather than `equal` so changing `equal` won't make much of > a difference here. No, it wasn't the cause of this bug. It's a separate bug in its own right, though. > I'm not sure whether the above should return nil, or non-nil, or the value > of `symbols-with-pos-enabled`, to be honest, but I guess returning non-nil > has worked fine until now, so I think we'd be better off staying with that. I've lost the context, somewhat, but the key thing is that the notion of symbol with position isn't really defined when symbols-with-pos-enabled is nil. Returning non-nil for (equal 'foo #) in this case is like saying 'foo is equal to an undefined entity. This is asking for the sort of trouble we're seeing in this bug. > I'd even like it to try and replace uses of `eq/eql` with `equal` in > those cases where we want to overlook differences in symbol-positions, so > that we can eventually get rid of `symbols-with-pos-enabled` which > I consider as a wart. OK. I don't think you can do this, because you'd have to replace lots of eq's in macros with equal. We don't control all these macros. That's aside from the massive disruption this would cause to bytecomp.el and friends. I don't think you should do this, since symbols-with-pos-enabled, ugly though it may be, is working. Also, you'd have to be careful not to slow Emacs down. Now, let's diagnose bug#65017! > Stefan -- Alan Mackenzie (Nuremberg, Germany).