From: Alan Mackenzie <acm@muc.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "Mattias Engdegård" <mattias.engdegard@gmail.com>,
65017@debbugs.gnu.org,
"Eric Marsden" <eric.marsden@risk-engineering.org>
Subject: bug#65017: 29.1; Byte compiler interaction with cl-lib function objects, removes symbol-function
Date: Fri, 4 Aug 2023 13:22:58 +0000 [thread overview]
Message-ID: <ZMz7sp67JVRGJAjd@ACM> (raw)
In-Reply-To: <jwvmsz88aoo.fsf-monnier+emacs@gnu.org>
Hello, Stefan, Mattias, and Eric.
On Thu, Aug 03, 2023 at 10:43:16 -0400, Stefan Monnier wrote:
[ .... ]
> AFAICT the problem is that OT1H `symbols-with-pos-enabled` is
> non-nil while loading the second file, but OTOH positions aren't
> stripped from the resulting code.
> So in `cl--labels-convert` when we check
> (eq f (car cl--labels-convert-cache))
[ .... ]
> I don't know why `symbols-with-pos-enabled` is non-nil at that point (I
> thought we only enabled it wile byte-compiling), ....
This is not quite the case. symbols-with-pos-enabled gets erroneously
bound to t in internal-macroexpand-for-load (emacs-lisp/macroexp.el).
This is the cause of the bug; in cl--labels-convert it causes the first
eq to return non-nil when comparing 'equal to #<symbol equal at 194>.
Removing that binding fixes the problem. This does not affect make
bootstrap or make check.
The necessary patch is:
diff --git a/lisp/emacs-lisp/macroexp.el b/lisp/emacs-lisp/macroexp.el
index b05aba3e1a7..ea838f5b7b2 100644
--- a/lisp/emacs-lisp/macroexp.el
+++ b/lisp/emacs-lisp/macroexp.el
@@ -799,8 +799,7 @@ macroexp--debug-eager
(defun internal-macroexpand-for-load (form full-p)
;; Called from the eager-macroexpansion in readevalloop.
- (let ((symbols-with-pos-enabled t)
- (print-symbols-bare t))
+ (let ((print-symbols-bare t))
(cond
;; Don't repeat the same warning for every top-level element.
((eq 'skip (car macroexp--pending-eager-loads)) form)
Stefan, it would still be nice for cl--labels-convert-cache to get
initialised each time it gets used.
Please try out the patch, and if all is well I can commit it and close
the bug.
[ .... ]
> Stefan
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2023-08-04 13:22 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 10:28 bug#65017: 29.1; Byte compiler interaction with cl-lib function objects, removes symbol-function Eric Marsden
2023-08-03 9:39 ` Mattias Engdegård
2023-08-03 14:43 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-03 15:37 ` Mattias Engdegård
2023-08-03 16:36 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-03 16:53 ` Mattias Engdegård
2023-08-03 17:30 ` Mattias Engdegård
2023-08-03 16:43 ` Alan Mackenzie
2023-08-03 17:30 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-03 18:22 ` Alan Mackenzie
2023-08-03 21:00 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-03 21:10 ` Alan Mackenzie
2023-08-03 21:46 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-04 9:55 ` Alan Mackenzie
2023-08-05 22:45 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-04 10:14 ` Mattias Engdegård
2023-08-04 11:11 ` Alan Mackenzie
2023-08-04 13:41 ` Mattias Engdegård
2023-08-05 22:40 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-06 10:47 ` Mattias Engdegård
2023-08-08 2:33 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-04 5:35 ` Eli Zaretskii
2023-08-04 14:16 ` Alan Mackenzie
2023-08-05 20:22 ` Alan Mackenzie
2023-08-06 4:49 ` Eli Zaretskii
2023-08-04 13:22 ` Alan Mackenzie [this message]
2023-08-04 14:04 ` Eli Zaretskii
2023-08-04 14:49 ` Alan Mackenzie
2023-08-04 15:22 ` Eli Zaretskii
2023-08-04 16:43 ` Alan Mackenzie
2023-08-04 17:54 ` Eli Zaretskii
2023-08-05 22:58 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-05 22:53 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-06 11:59 ` Alan Mackenzie
2023-08-08 2:44 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-08 16:56 ` Alan Mackenzie
2023-08-10 3:41 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-10 14:50 ` Alan Mackenzie
2023-08-12 3:28 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-12 9:59 ` Mattias Engdegård
2023-08-12 18:21 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-12 10:40 ` Mattias Engdegård
2023-08-12 16:46 ` Alan Mackenzie
2023-08-12 18:28 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-13 10:10 ` Alan Mackenzie
2023-08-13 16:12 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-14 17:10 ` Alan Mackenzie
2023-08-03 16:11 ` Alan Mackenzie
2023-08-03 16:41 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-03 18:48 ` Alan Mackenzie
2023-08-09 12:27 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMz7sp67JVRGJAjd@ACM \
--to=acm@muc.de \
--cc=65017@debbugs.gnu.org \
--cc=eric.marsden@risk-engineering.org \
--cc=mattias.engdegard@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.