From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#65017: 29.1; Byte compiler interaction with cl-lib function objects, removes symbol-function Date: Sat, 5 Aug 2023 20:22:32 +0000 Message-ID: References: <8B08E514-B2D5-48F5-BA90-4F5A9492F8F9@gmail.com> <83leerwesd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26618"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mattias.engdegard@gmail.com, 65017@debbugs.gnu.org, monnier@iro.umontreal.ca, eric.marsden@risk-engineering.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 05 22:23:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qSNo0-0006jb-WD for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Aug 2023 22:23:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qSNnk-0007AD-R5; Sat, 05 Aug 2023 16:23:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSNnj-0007A5-Qh for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2023 16:23:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qSNnj-0006lt-Io for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2023 16:23:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qSNni-0006Ar-Ep for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2023 16:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Aug 2023 20:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65017 X-GNU-PR-Package: emacs Original-Received: via spool by 65017-submit@debbugs.gnu.org id=B65017.169126696423706 (code B ref 65017); Sat, 05 Aug 2023 20:23:02 +0000 Original-Received: (at 65017) by debbugs.gnu.org; 5 Aug 2023 20:22:44 +0000 Original-Received: from localhost ([127.0.0.1]:58254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSNnQ-0006AI-FE for submit@debbugs.gnu.org; Sat, 05 Aug 2023 16:22:44 -0400 Original-Received: from mx3.muc.de ([193.149.48.5]:51964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSNnL-0006A3-MZ for 65017@debbugs.gnu.org; Sat, 05 Aug 2023 16:22:43 -0400 Original-Received: (qmail 99437 invoked by uid 3782); 5 Aug 2023 22:22:33 +0200 Original-Received: from acm.muc.de (p4fe15973.dip0.t-ipconnect.de [79.225.89.115]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 05 Aug 2023 22:22:33 +0200 Original-Received: (qmail 19963 invoked by uid 1000); 5 Aug 2023 20:22:32 -0000 Content-Disposition: inline In-Reply-To: <83leerwesd.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266815 Archived-At: Hello, Eli On Fri, Aug 04, 2023 at 08:35:30 +0300, Eli Zaretskii wrote: > > Cc: acm@muc.de, 65017@debbugs.gnu.org, > > Eric Marsden > > Date: Thu, 3 Aug 2023 21:10:56 +0000 > > From: Alan Mackenzie > Thanks, but when you have a solution in hand, please also check its > effect on performance. AFAIR, this part was tuned for optimal > performance, back when symbols with positions were introduced; it > would be a pity to lose performance due to fixing this bug, if that > can be avoided. This should really be in bug #65051, but: I've run time src/emacs -Q -batch --eval '(let ((a 1) (b 1) (times 10000000)) (while (> times 0) (equal a b) (setq times (1- times))))' with different values for a and b (and slightly different quoting syntax, sometimes). I get the following results, reporting the "user: time" from GNU/Linux: New code: a, b = 1, 1: 1.760s 1.760s 1,746s a, b = 1, 3: 1.796s 1,772s 1.777s 1.0, 1.0: 1,757s 1.776s 1.751s 1.0, 1.1: 1.792s 1.760s 1.779s '(a b c), '(a b c): 2.041s 2.042s 2.039s '(a b c), '(a b d): 2.096s 2.071s 2.084s "1", "1": 1.841s 1.860s 1.845s "1", "3": 1.865s 1.846s 1.869s Old code: a, b = 1, 1: 1.744s 1.757s 1.762s a, b = 1, 3: 1.755s 1,777s 1.759s 1.0, 1.0: 1.787s 1.748s 1.775s 1.0, 1.1: 1.762s 1.770s 1.774s '(a b c), '(a b c): 2.021s 2.057s 2.019s '(a b c), '(a b d): 2.046s 2.090s 2.100s "1", "1": 1.854s 1.900s 1.884s "1", "3": 1.849s 1.833s 1.838s I think it's fair to say that the new code is not slower than the old code, to within the measuring limits of these simple tests. Any differences, such as they are, are in the second and third decimal places, and vary more between different measurements, than between the Old code and New code. They are surely too small to matter. -- Alan Mackenzie (Nuremberg, Germany).