all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-devel@gnu.org
Subject: Re: Should `indirect-function' be preferred over `fboundp'?
Date: Thu, 20 Jul 2023 13:02:34 +0000	[thread overview]
Message-ID: <ZLkwapYDzB9QwIli@ACM> (raw)
In-Reply-To: <87h6pzxdof.fsf@localhost>

Hello, Ihor.

On Thu, Jul 20, 2023 at 07:08:48 +0000, Ihor Radchenko wrote:
> Hi,

> I have recently stumbled upon the common Elisp pattern
> (when (fboundp func) (funcall func)) failing.

> This is happening when a symbol is declared as function alias to
> non-existing function:

> (defalias 'yant/foo 'yant/bar)
> (fboundp 'yant/foo) ; => t
> (funcall 'yant/foo) ; => ERROR: Symbol function definition is void: yant/foo

I don't think it affects the point you are making, but why are you using
funcall in the last line, rather than just calling the funcion as

  (yant/foo)

?  I initially got confused and thought you were doing

  (funcall yant/foo)

, which would have been an obvious error.

> In contrast, `indirect-function' does a better job determining whether a
> given symbol can be called as a function:

> (indirect-function 'yant/foo) ; => nil

> Is it something widely known?
> Is it something to worry about?
> (I can see that `fboundp' is used all over Emacs git sources, while
> `indirect-function' is rarely used)

> -- 
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at <https://orgmode.org/>.
> Support Org development at <https://liberapay.com/org-mode>,
> or support my work at <https://liberapay.com/yantar92>

-- 
Alan Mackenzie (Nuremberg, Germany).



  parent reply	other threads:[~2023-07-20 13:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-20  7:08 Should `indirect-function' be preferred over `fboundp'? Ihor Radchenko
2023-07-20  7:42 ` Eli Zaretskii
2023-07-20  8:23   ` Ihor Radchenko
2023-07-20  7:47 ` Andreas Schwab
2023-07-20  8:25   ` Ihor Radchenko
2023-07-20 13:02 ` Alan Mackenzie [this message]
2023-07-20 13:08   ` Ihor Radchenko
2023-07-21  1:08 ` Michael Heerdegen
2023-07-21  6:07   ` Ihor Radchenko
2023-07-22  2:49     ` Michael Heerdegen
2023-07-22 10:51       ` Ihor Radchenko
2023-07-23  2:37         ` Michael Heerdegen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZLkwapYDzB9QwIli@ACM \
    --to=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.