From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#62339: cc-mode fontifies variables incorrectly when const follows type Date: Wed, 5 Apr 2023 15:53:47 +0000 Message-ID: References: <878rfqcez5.fsf@dancol.org> <837cva6m1e.fsf@gnu.org> <87y1no6f6d.fsf@dancol.org> <83ttyc6cqz.fsf@gnu.org> <87lejo1ldz.fsf@dancol.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37518"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62339@debbugs.gnu.org, Eli Zaretskii To: Daniel Colascione Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 05 17:54:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pk5Sm-0009UZ-C6 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Apr 2023 17:54:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pk5SV-0008Tc-JL; Wed, 05 Apr 2023 11:54:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pk5SU-0008TM-M3 for bug-gnu-emacs@gnu.org; Wed, 05 Apr 2023 11:54:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pk5SU-0007uR-Bx for bug-gnu-emacs@gnu.org; Wed, 05 Apr 2023 11:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pk5SU-0007yZ-2N for bug-gnu-emacs@gnu.org; Wed, 05 Apr 2023 11:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Apr 2023 15:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62339 X-GNU-PR-Package: emacs Original-Received: via spool by 62339-submit@debbugs.gnu.org id=B62339.168071003530643 (code B ref 62339); Wed, 05 Apr 2023 15:54:02 +0000 Original-Received: (at 62339) by debbugs.gnu.org; 5 Apr 2023 15:53:55 +0000 Original-Received: from localhost ([127.0.0.1]:52481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pk5SN-0007yA-GU for submit@debbugs.gnu.org; Wed, 05 Apr 2023 11:53:55 -0400 Original-Received: from mx3.muc.de ([193.149.48.5]:31856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pk5SM-0007xz-G9 for 62339@debbugs.gnu.org; Wed, 05 Apr 2023 11:53:55 -0400 Original-Received: (qmail 61716 invoked by uid 3782); 5 Apr 2023 17:53:48 +0200 Original-Received: from acm.muc.de (pd953aa63.dip0.t-ipconnect.de [217.83.170.99]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 05 Apr 2023 17:53:48 +0200 Original-Received: (qmail 32460 invoked by uid 1000); 5 Apr 2023 15:53:47 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259276 Archived-At: Hello, Daniel. On Thu, Mar 23, 2023 at 14:40:23 +0000, Alan Mackenzie wrote: > On Wed, Mar 22, 2023 at 18:17:05 -0400, Daniel Colascione wrote: > > >> > This problem reproduces for me on latest master with emacs -Q: > > >> > ``` > > >> > TEST(Foo, Bar) { > > >> > NamedTemporaryDirectory const test_directory; > > >> > } > > >> > ``` > > >> Thanks. What I see with Emacs built from master is that > > >> test_directory in the above example gets font-lock-type-face in > > >> c++-mode (but not in c-mode). With Emacs built from emacs-29, both > > >> modes produce correct fontification. > > >> Alan, can you please look into this? [ .... ] > It turned out that the bug was caused by a single missing line of code, a > (c-forward-syntactic-ws) in c-forward-type, so the fix wasn't too > difficult. I've taken the opportunity also to fix some minor other > innaccuracies in c-forward-type. > Please try the following patch, and either confirm to me that it appears > to fix the bug, or say what's still wrong. Thanks! Ping? -- Alan Mackenzie (Nuremberg, Germany).