From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Trent W. Buck" Newsgroups: gmane.emacs.bugs Subject: bug#62370: 28.1; sieve-mode: faces should inherit from font-lock-X-face faces Date: Thu, 23 Mar 2023 12:05:24 +1100 Message-ID: References: <875yatpclo.fsf@gmail.com> <83y1no6dtd.fsf@gnu.org> <13910d348d640c50ebdc@heytings.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UzDqwkHs7iqn01id" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17587"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Gregory Heytings , Eli Zaretskii , 62370@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 23 02:06:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pf9PK-0004M3-ER for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Mar 2023 02:06:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pf9P3-0002l5-Cl; Wed, 22 Mar 2023 21:06:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pf9P0-0002kc-Vx for bug-gnu-emacs@gnu.org; Wed, 22 Mar 2023 21:06:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pf9P0-0008H9-Lt for bug-gnu-emacs@gnu.org; Wed, 22 Mar 2023 21:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pf9P0-0002TA-H9 for bug-gnu-emacs@gnu.org; Wed, 22 Mar 2023 21:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Trent W. Buck" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Mar 2023 01:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62370 X-GNU-PR-Package: emacs Original-Received: via spool by 62370-submit@debbugs.gnu.org id=B62370.16795335369455 (code B ref 62370); Thu, 23 Mar 2023 01:06:02 +0000 Original-Received: (at 62370) by debbugs.gnu.org; 23 Mar 2023 01:05:36 +0000 Original-Received: from localhost ([127.0.0.1]:36948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pf9OZ-0002SQ-Od for submit@debbugs.gnu.org; Wed, 22 Mar 2023 21:05:36 -0400 Original-Received: from mail-pg1-f173.google.com ([209.85.215.173]:33749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pf9OY-0002SA-E0 for 62370@debbugs.gnu.org; Wed, 22 Mar 2023 21:05:34 -0400 Original-Received: by mail-pg1-f173.google.com with SMTP id s19so6333392pgi.0 for <62370@debbugs.gnu.org>; Wed, 22 Mar 2023 18:05:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679533528; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1hZ3iXfCivXYyCTRmm7bbp2u/SN3RXARapkRrz1h7f4=; b=AJI9rQptDv+Vi6xDDWOPpuTvVILPSeoNmGjkZtXVEyF94sdN8uWpeWMv0++BHGzLwq UO88rRR5TJLnCkOQD4069/9LSdIdis/uxmFJJhiYeMhi7y3f8+bMtMm8Q6mwhM35JTgv jFCQjkBQlFtYNImGkjPHJNzWndGObsqX2ER571Zano//oWTgym7lZCpm7WEX9SGb8yTZ j/L5a8Ib4UZmccyRpOYGcsIlvprqOl9M0Y5nV3LZxHHaMCuxJ4M0QY34GCcgLCazjK9N w/oiRnnzhcS1Rq+pb01CflD1lTWL4zzKtV7x3uC4cS0NQ8SvuqAcrdrnrD52NKbBx171 M3GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679533528; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1hZ3iXfCivXYyCTRmm7bbp2u/SN3RXARapkRrz1h7f4=; b=obVc4YwAuIpuzMSQOdaipnmIwkT2j3HMbFjii8UbW58CjM0PAZa5B8l7VQbm8lhQfK SxYGp4bxYB+5MJNkkR5wuu9M7QlP9O3Gk+PqeAfGD6herT3LCMIE8kRNZYhdQvlPXUdE dGwJu48OfInj0+w/dy8EKT5pLKtkobwe/8N0N/ll8Rng2zcVnhrJQ9mtpCpuRit2xKV6 Q9QELvSaBnXcefYqCzWH3HaH8pfUylTnFtiugRgNftDm4senokXgnzURtL+2rgCs55K8 PaFbDEOJeIohA1ELal3Q/OishRdilp5qnI+asFPNwn4qXblohe0OoEXXD6EfGrCsgSXT ZTIQ== X-Gm-Message-State: AO0yUKWPw1x5UOTS8eULQ9QRdyXPbfKS9BCLIuNydcSy7fFECX6LWszb V9H8QwYqrW36nxecD5k9mc0= X-Google-Smtp-Source: AK7set/JcnHWCh/itSp9LYwki08r60TYK1b7qfDB66XFuRJyeXIObv+T4km2U5TItMEa4G+U9NLN/w== X-Received: by 2002:a62:8442:0:b0:627:ec37:1e69 with SMTP id k63-20020a628442000000b00627ec371e69mr4453811pfd.8.1679533528341; Wed, 22 Mar 2023 18:05:28 -0700 (PDT) Original-Received: from localhost (2403-5804-c6--add.ip6.aussiebb.net. [2403:5804:c6::add]) by smtp.gmail.com with ESMTPSA id t13-20020a62ea0d000000b005a87d636c70sm10629326pfh.130.2023.03.22.18.05.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Mar 2023 18:05:27 -0700 (PDT) Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258423 Archived-At: --UzDqwkHs7iqn01id Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed 22 Mar 2023 14:22:45 -0700, Jim Porter wrote: > On 3/22/2023 1:10 PM, Gregory Heytings wrote: > > But the sieve-* faces have existed for twenty years, so it's now too > > late to change them. > > I think it might actually be ok to change this: the face attributes for each > of the 'sieve-*' faces closely correspond to one of the 'font-lock-*-face' > faces. They're not *identical*, but the differences are very slight. > > The mapping is: > > sieve-control-commands -> font-lock-builtin-face > sieve-action-commands -> font-lock-function-name-face > sieve-test-commands -> font-lock-constant-face > sieve-tagged-arguments -> font-lock-keyword-face > > (Note that this is a different mapping from Trent's proposal.) For the record, I'm fine with this mapping. I only just started using sieve seriously yesterday, so my initial mapping was a wild-ass guess. > If we mapped the 'sieve-*' faces like that, I doubt anyone using the default > theme would notice. Likewise, anyone using a theme that customizes the > 'sieve-*' faces wouldn't notice, since they're already explicitly-themed. I agree. > The only users who would see an impact would be those using non-default > themes that *didn't* have definitions for 'sieve-*' faces, and they'll > arguably have improved visuals: with the change, 'sieve-mode' will look > consistently-themed with the rest of Emacs. I agree. I don't think "I opened foo.sieve in Emacs 20 twenty years ago, and now I opened foo.sieve in Emacs 30 today, and the colors aren't identical, and now I'm mad" is a good argument for never changing the defaults. Emacs changes the defaults like that ALL THE TIME. If they piss me off, I just patch back in the old behaviour and forget about it. Choice examples: ;; Colour comment bodies in console mode. I tried to get this changed upstream, ;; but RMS decreed that it was a feature as (apparently) red is difficult to ;; read on eight-colour terminals. Hopefully a circular dependency is OK... ;; FFS, RMS, just configure your terminal, e.g. printf '\033]P1CC0000\033]P9EF2929' (eval-after-load "font-lock" '(if (< emacs-major-version 24) (put 'font-lock-comment-face 'face-alias 'font-lock-comment-delimiter-face) ;; UPDATE: it's not OK in Emacs 24. For now, just assume an 8-color tty. (set-face-attribute 'font-lock-comment-face nil :foreground "red"))) ;; Undo stupid feature where ^M means ^J and ^J means ^M. ;; Fixes copy-paste between terminals without bracketed paste mode (i.e. ALL of them). ;; http://emacsredux.com/blog/2014/01/19/a-peek-at-emacs-24-dot-4-auto-indentation-by-default/ (when (fboundp 'electric-indent-mode) (electric-indent-mode -1)) --UzDqwkHs7iqn01id Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQSa2DCDFKeGhLfn4PQv4DGKIStEDAUCZBul0AAKCRAv4DGKIStE DIdXAP9PemCoS9kTa8Q+WQpq3zt4NxopPk1CdpSknAENaZoXqwD/e11jwKBnKYil 2pfjyG9kMsyDfNy3Awzzab8qRIY8pAw= =poW/ -----END PGP SIGNATURE----- --UzDqwkHs7iqn01id--