From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#62339: cc-mode fontifies variables incorrectly when const follows type Date: Wed, 22 Mar 2023 22:14:12 +0000 Message-ID: References: <878rfqcez5.fsf@dancol.org> <837cva6m1e.fsf@gnu.org> <87y1no6f6d.fsf@dancol.org> <83ttyc6cqz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23311"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62339@debbugs.gnu.org, acm@muc.de, Daniel Colascione To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 23 00:12:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pf7d2-0005pU-JR for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Mar 2023 00:12:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pf6kZ-0006JA-E1; Wed, 22 Mar 2023 18:16:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pf6kW-0006Iz-3K for bug-gnu-emacs@gnu.org; Wed, 22 Mar 2023 18:16:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pf6kV-00063p-QQ for bug-gnu-emacs@gnu.org; Wed, 22 Mar 2023 18:16:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pf6kU-0005cO-0C for bug-gnu-emacs@gnu.org; Wed, 22 Mar 2023 18:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Mar 2023 22:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62339 X-GNU-PR-Package: emacs Original-Received: via spool by 62339-submit@debbugs.gnu.org id=B62339.167952334021567 (code B ref 62339); Wed, 22 Mar 2023 22:16:01 +0000 Original-Received: (at 62339) by debbugs.gnu.org; 22 Mar 2023 22:15:40 +0000 Original-Received: from localhost ([127.0.0.1]:36826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pf6k6-0005bl-D6 for submit@debbugs.gnu.org; Wed, 22 Mar 2023 18:15:40 -0400 Original-Received: from [193.149.48.5] (port=12877 helo=mx3.muc.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pf6jC-0005Zq-AB for 62339@debbugs.gnu.org; Wed, 22 Mar 2023 18:15:37 -0400 Original-Received: (qmail 1674 invoked by uid 3782); 22 Mar 2023 23:14:14 +0100 Original-Received: from acm.muc.de (pd953a9c8.dip0.t-ipconnect.de [217.83.169.200]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 22 Mar 2023 23:14:13 +0100 Original-Received: (qmail 20913 invoked by uid 1000); 22 Mar 2023 22:14:12 -0000 Content-Disposition: inline In-Reply-To: <83ttyc6cqz.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258415 Archived-At: Hello, Eli and Daniel. Thanks for the bug report! On Wed, Mar 22, 2023 at 17:12:52 +0200, Eli Zaretskii wrote: > > From: Daniel Colascione > > Cc: 62339@debbugs.gnu.org > > Date: Wed, 22 Mar 2023 10:19:55 -0400 > > This problem reproduces for me on latest master with emacs -Q: > > ``` > > TEST(Foo, Bar) { > > NamedTemporaryDirectory const test_directory; > > } > > ``` > Thanks. What I see with Emacs built from master is that > test_directory in the above example gets font-lock-type-face in > c++-mode (but not in c-mode). With Emacs built from emacs-29, both > modes produce correct fontification. > Alan, can you please look into this? I think this is caused by a faulty fix of bug #59267, where "typeless" C declarations like const foo; , which are implicit int, were not being recognised. In the current test case, in C Mode, NamedTemporaryDirectory ought to be getting fontified as a type, but isn't. In C++ Mode, test_directory gets spuriously fontified as a type, as already noted. Seeing as how the current bug affects only the master branch, not the emacs-29 branch, I think I'm going to take a bit of time to fix this bug in the hope of fixing it properly this time. -- Alan Mackenzie (Nuremberg, Germany).