c-font-lock-extra-types and friends

c-font-lock-extra-types and friends

[Eli Zaretskii]

Every time I visit etags.c, I need to confirm the application of the
file-local vars, because c-font-lock-extra-types doesn't have the
appropriate safe-local-variable-p property.  Is there any reason not
to consider its value safe by default if it is a list of strings?

Re: c-font-lock-extra-types and friends

[Alan Mackenzie]

Hello, Eli.

On Sun, Mar 05, 2023 at 08:57:35 +0200, Eli Zaretskii wrote:
> Every time I visit etags.c, I need to confirm the application of the
> file-local vars, because c-font-lock-extra-types doesn't have the
> appropriate safe-local-variable-p property.  Is there any reason not
> to consider its value safe by default if it is a list of strings?

I can't see any reason at all.

I'll have a look at adding the appropriate settings to CC Mode.

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: c-font-lock-extra-types and friends

[Francesco Potortì]

>On Sun, Mar 05, 2023 at 08:57:35 +0200, Eli Zaretskii wrote:
>> Every time I visit etags.c, I need to confirm the application of the
>> file-local vars, because c-font-lock-extra-types doesn't have the
>> appropriate safe-local-variable-p property.  Is there any reason not
>> to consider its value safe by default if it is a list of strings?

Alan:
>I can't see any reason at all.
>
>I'll have a look at adding the appropriate settings to CC Mode.

I suspect the problem is more general.  I'd say the same about font-lock-defaults

Re: c-font-lock-extra-types and friends

[Alan Mackenzie]

Hello, Eli.

On Sun, Mar 05, 2023 at 08:57:35 +0200, Eli Zaretskii wrote:
> Every time I visit etags.c, I need to confirm the application of the
> file-local vars, because c-font-lock-extra-types doesn't have the
> appropriate safe-local-variable-p property.  Is there any reason not
> to consider its value safe by default if it is a list of strings?

I've committed a fix for this to master.  Would you possibly give it a
quick test sometime, and confirm the job is done, please.

Thanks!

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: c-font-lock-extra-types and friends

[Eli Zaretskii]

> Date: Mon, 13 Mar 2023 16:54:55 +0000
> Cc: emacs-devel@gnu.org
> From: Alan Mackenzie <acm@muc.de>
> 
> Hello, Eli.
> 
> On Sun, Mar 05, 2023 at 08:57:35 +0200, Eli Zaretskii wrote:
> > Every time I visit etags.c, I need to confirm the application of the
> > file-local vars, because c-font-lock-extra-types doesn't have the
> > appropriate safe-local-variable-p property.  Is there any reason not
> > to consider its value safe by default if it is a list of strings?
> 
> I've committed a fix for this to master.  Would you possibly give it a
> quick test sometime, and confirm the job is done, please.

Thanks, but I think you forgot to push.

Re: c-font-lock-extra-types and friends

[Alan Mackenzie]

Hello, Eli.

On Mon, Mar 13, 2023 at 19:12:59 +0200, Eli Zaretskii wrote:
> > Date: Mon, 13 Mar 2023 16:54:55 +0000
> > Cc: emacs-devel@gnu.org
> > From: Alan Mackenzie <acm@muc.de>

> > Hello, Eli.

> > On Sun, Mar 05, 2023 at 08:57:35 +0200, Eli Zaretskii wrote:
> > > Every time I visit etags.c, I need to confirm the application of the
> > > file-local vars, because c-font-lock-extra-types doesn't have the
> > > appropriate safe-local-variable-p property.  Is there any reason not
> > > to consider its value safe by default if it is a list of strings?

> > I've committed a fix for this to master.  Would you possibly give it a
> > quick test sometime, and confirm the job is done, please.

> Thanks, but I think you forgot to push.

Sorry.  I installed git 2.39.2 yesterday evening, and think I've hit a
bug in it.  When I attempted to push, I got a message saying somebody
else had pushed.  So I did a git pull --rebase, and found I no longer
had any outstanding commits to push.  I assumed my push had somehow got
through.

At the moment, my main git repository has no outstanding commits to
push, and seems to think my latest (non-)push is already pushed.

Hopefully I can find a workaround for this discrepancy.

Sorry again.

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: c-font-lock-extra-types and friends

[Alan Mackenzie]

Hello, Eli.

On Mon, Mar 13, 2023 at 18:04:33 +0000, Alan Mackenzie wrote:
> On Mon, Mar 13, 2023 at 19:12:59 +0200, Eli Zaretskii wrote:
> > > Date: Mon, 13 Mar 2023 16:54:55 +0000
> > > Cc: emacs-devel@gnu.org
> > > From: Alan Mackenzie <acm@muc.de>

> > > Hello, Eli.

> > > On Sun, Mar 05, 2023 at 08:57:35 +0200, Eli Zaretskii wrote:
> > > > Every time I visit etags.c, I need to confirm the application of the
> > > > file-local vars, because c-font-lock-extra-types doesn't have the
> > > > appropriate safe-local-variable-p property.  Is there any reason not
> > > > to consider its value safe by default if it is a list of strings?

> > > I've committed a fix for this to master.  Would you possibly give it a
> > > quick test sometime, and confirm the job is done, please.

> > Thanks, but I think you forgot to push.

> Sorry.  I installed git 2.39.2 yesterday evening, and think I've hit a
> bug in it.  When I attempted to push, I got a message saying somebody
> else had pushed.  So I did a git pull --rebase, and found I no longer
> had any outstanding commits to push.  I assumed my push had somehow got
> through.

> At the moment, my main git repository has no outstanding commits to
> push, and seems to think my latest (non-)push is already pushed.

> Hopefully I can find a workaround for this discrepancy.

> Sorry again.

No, it was my fault.  For some reason, I was trying to push from the
wrong repository.  The commit should be in master now.

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: c-font-lock-extra-types and friends

[Eli Zaretskii]

> Date: Mon, 13 Mar 2023 18:37:58 +0000
> Cc: emacs-devel@gnu.org
> From: Alan Mackenzie <acm@muc.de>
> 
> No, it was my fault.  For some reason, I was trying to push from the
> wrong repository.  The commit should be in master now.

Thanks.  However, I have a couple of questions about that commit:

 . why did you add a new function c-list-of-strings, when we already
   had c-string-list-p there?
 . any reason not to backport this to the emacs-29 branch?

Re: c-font-lock-extra-types and friends

[Eli Zaretskii]

> Date: Tue, 14 Mar 2023 14:25:27 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-devel@gnu.org
> 
>  . why did you add a new function c-list-of-strings, when we already
>    had c-string-list-p there?
>  . any reason not to backport this to the emacs-29 branch?

Also, this change leads to

    ELC      ../lisp/loaddefs.elc
  Reloading stale loaddefs.el
  Loading d:/gnu/git/emacs/trunk/lisp/loaddefs.el (source)...
  Loading d:/gnu/git/emacs/trunk/lisp/theme-loaddefs.el (source)...

  In end of data:
  loaddefs.el:3784:55: Warning: the function `c-list-of-strings' is not known to be defined.

Re: c-font-lock-extra-types and friends

[Eli Zaretskii]

Ping!

Alan, with the pretest of Emacs 29 very near, I'd like to resolve
this issue.  TIA.

> Date: Tue, 14 Mar 2023 14:25:27 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-devel@gnu.org
> 
> > Date: Mon, 13 Mar 2023 18:37:58 +0000
> > Cc: emacs-devel@gnu.org
> > From: Alan Mackenzie <acm@muc.de>
> > 
> > No, it was my fault.  For some reason, I was trying to push from the
> > wrong repository.  The commit should be in master now.
> 
> Thanks.  However, I have a couple of questions about that commit:
> 
>  . why did you add a new function c-list-of-strings, when we already
>    had c-string-list-p there?
>  . any reason not to backport this to the emacs-29 branch?
> 
> Date: Tue, 14 Mar 2023 21:51:28 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> CC: emacs-devel@gnu.org
> 
> > Date: Tue, 14 Mar 2023 14:25:27 +0200
> > From: Eli Zaretskii <eliz@gnu.org>
> > Cc: emacs-devel@gnu.org
> > 
> >  . why did you add a new function c-list-of-strings, when we already
> >    had c-string-list-p there?
> >  . any reason not to backport this to the emacs-29 branch?
> 
> Also, this change leads to
> 
>     ELC      ../lisp/loaddefs.elc
>   Reloading stale loaddefs.el
>   Loading d:/gnu/git/emacs/trunk/lisp/loaddefs.el (source)...
>   Loading d:/gnu/git/emacs/trunk/lisp/theme-loaddefs.el (source)...
> 
>   In end of data:
>   loaddefs.el:3784:55: Warning: the function `c-list-of-strings' is not known to be defined.
> 
> 

Re: c-font-lock-extra-types and friends

[Alan Mackenzie]

Hello, Eli.

On Sat, Mar 18, 2023 at 08:40:38 +0200, Eli Zaretskii wrote:
> Ping!

Sorry, I got bogged down with something else, the last few days.

> Alan, with the pretest of Emacs 29 very near, I'd like to resolve
> this issue.  TIA.

OK, I'll backport it to Emacs 29.

[ .... ]

> > Thanks.  However, I have a couple of questions about that commit:

> >  . why did you add a new function c-list-of-strings, when we already
> >    had c-string-list-p there?
> >  . any reason not to backport this to the emacs-29 branch?

I'd forgotten about c-string-list.  How did you pick up the duplication,
just as a matter of interest?  I'll get rid of c-list-of-strings.

> > Date: Tue, 14 Mar 2023 21:51:28 +0200
> > From: Eli Zaretskii <eliz@gnu.org>
> > CC: emacs-devel@gnu.org

> > > Date: Tue, 14 Mar 2023 14:25:27 +0200
> > > From: Eli Zaretskii <eliz@gnu.org>
> > > Cc: emacs-devel@gnu.org

> > >  . why did you add a new function c-list-of-strings, when we already
> > >    had c-string-list-p there?
> > >  . any reason not to backport this to the emacs-29 branch?

> > Also, this change leads to

> >     ELC      ../lisp/loaddefs.elc
> >   Reloading stale loaddefs.el
> >   Loading d:/gnu/git/emacs/trunk/lisp/loaddefs.el (source)...
> >   Loading d:/gnu/git/emacs/trunk/lisp/theme-loaddefs.el (source)...

> >   In end of data:
> >   loaddefs.el:3784:55: Warning: the function `c-list-of-strings' is not known to be defined.

I'm working on this now.  Hopefully everything will be resolved today.

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: c-font-lock-extra-types and friends

[Eli Zaretskii]

> Date: Sat, 18 Mar 2023 09:14:54 +0000
> Cc: emacs-devel@gnu.org
> From: Alan Mackenzie <acm@muc.de>
> 
> On Sat, Mar 18, 2023 at 08:40:38 +0200, Eli Zaretskii wrote:
> > Ping!
> 
> Sorry, I got bogged down with something else, the last few days.
> 
> > Alan, with the pretest of Emacs 29 very near, I'd like to resolve
> > this issue.  TIA.
> 
> OK, I'll backport it to Emacs 29.

Great, thanks.

> > >  . why did you add a new function c-list-of-strings, when we already
> > >    had c-string-list-p there?
> > >  . any reason not to backport this to the emacs-29 branch?
> 
> I'd forgotten about c-string-list.  How did you pick up the duplication,
> just as a matter of interest?

I knew about it before I asked the original question about
c-font-lock-extra-types: I've seen that you use c-string-list for
other variables.  I expected you to use it for those I complained
about, and was surprised to see that you invented a new function,
basically identical to that one.

> I'll get rid of c-list-of-strings.

Thanks.

> I'm working on this now.  Hopefully everything will be resolved today.

Great.