From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#61962: 30.0.50; New trouble with symbols with positions Date: Sun, 12 Mar 2023 20:42:25 +0000 Message-ID: References: <877cvvqj5v.fsf@web.de> <877cvv0yv7.fsf@web.de> <87a60p4d5q.fsf@web.de> <83356g7lh7.fsf@gnu.org> <87o7p4pt3p.fsf@gmail.com> <0166B01B-96AA-4A7D-B7F1-13A34C768C41@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19404"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Michael Heerdegen , Robert Pluim , Eli Zaretskii , 61962@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 12 21:43:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pbSXG-0004si-N1 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Mar 2023 21:43:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pbSX4-0004br-0e; Sun, 12 Mar 2023 16:43:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pbSX0-0004bf-Pl for bug-gnu-emacs@gnu.org; Sun, 12 Mar 2023 16:43:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pbSX0-0003Er-DD for bug-gnu-emacs@gnu.org; Sun, 12 Mar 2023 16:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pbSX0-0000uu-37 for bug-gnu-emacs@gnu.org; Sun, 12 Mar 2023 16:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Mar 2023 20:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61962 X-GNU-PR-Package: emacs Original-Received: via spool by 61962-submit@debbugs.gnu.org id=B61962.16786537533475 (code B ref 61962); Sun, 12 Mar 2023 20:43:02 +0000 Original-Received: (at 61962) by debbugs.gnu.org; 12 Mar 2023 20:42:33 +0000 Original-Received: from localhost ([127.0.0.1]:33151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbSWX-0000tz-AO for submit@debbugs.gnu.org; Sun, 12 Mar 2023 16:42:33 -0400 Original-Received: from mx3.muc.de ([193.149.48.5]:32036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbSWV-0000tn-Uo for 61962@debbugs.gnu.org; Sun, 12 Mar 2023 16:42:32 -0400 Original-Received: (qmail 10172 invoked by uid 3782); 12 Mar 2023 21:42:26 +0100 Original-Received: from acm.muc.de (p4fe15624.dip0.t-ipconnect.de [79.225.86.36]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 12 Mar 2023 21:42:25 +0100 Original-Received: (qmail 22665 invoked by uid 1000); 12 Mar 2023 20:42:25 -0000 Content-Disposition: inline In-Reply-To: <0166B01B-96AA-4A7D-B7F1-13A34C768C41@acm.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257880 Archived-At: Hello, Mattias. On Sun, Mar 12, 2023 at 18:30:51 +0100, Mattias Engdegård wrote: > As promised earlier, I gave the safe-copy-tree code a good > working-through. Testing revealed bugs but the new implementation > shouldn't have them. It's internal for now as there seems to be no need > for it elsewhere, which also permitted some gold-plating to be removed. > The new code is also quite a bit faster. I'm not at all happy with the changes you've made. You've transformed a general purpose utility into a special purpose restricted one. It was me that put the work in in the first place, and I wonder why. It was a substantial amount of work, and it would appear to have been for nothing. Why did you not talk to me about the changes you were intending to make? You've simply overridden my judgment with your own in cutting the scope of the new function down. Why? I thoroughly disagree with you that no general purpose copy-tree is needed (I've lamented its lack before now), and I thoroughly disagree with you that vectors and records need never be copied. You say there were bugs with my version. OK, thanks for correcting them, but would you please identify exactly what the bugs were. How else am I supposed to learn? You say your new version is "quite a bit" faster. What does that mean? A factor of 10? A factor of 2? 20%? 10%? How did you measure this speed up, and what particular code change was responsible for it? Thanks. -- Alan Mackenzie (Nuremberg, Germany).