From: Alan Third <alan@idiocy.org>
To: Aaron Jensen <aaronjensen@gmail.com>
Cc: 59790@debbugs.gnu.org
Subject: bug#59790: 30.0.50; ns-use-native-fullscreen is not respected for first use of initial-frame-alist
Date: Sun, 24 Nov 2024 11:59:01 +0000 [thread overview]
Message-ID: <Z0MVBS64EMkt_NH0@breton.holly.idiocy.org> (raw)
In-Reply-To: <CAHyO48w9trVhb4eLRNyooNKBDWPBrBctcpjHTzOu-GokeZeQhQ@mail.gmail.com>
On Sun, Nov 17, 2024 at 12:00:07AM -0500, Aaron Jensen wrote:
> The bugged behavior is that `ns-use-native-fullscreen' set to nil is not read
> when launching emacs.
>
>
> The attached patch should fix this. The problem is that when the frame is
> made, the current value of ns-use-native-fullscreen is copied to a variable
> and that's only reset when the frame goes from fullscreen to windowed. I
> believe the original intent was to ensure that the mode could not change
> while the window was fullscreen already.
>
> This resets the value of fs_is_native if the frame is not already
> fullscreen, which allows it to respect the value at the time of the first
> fullscreen.
>
> Without this, the only way to get the behavior that Sean is expecting is to
> set ns-use-native-fullscreen in early-init, which should not be necessary.
Pushed to emacs-30 as 03ae07291e85fd353595806c3ce1ad3315c47649.
--
Alan Third
prev parent reply other threads:[~2024-11-24 11:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-03 2:43 bug#59790: 30.0.50; ns-use-native-fullscreen is not respected for first use of initial-frame-alist Sean Farley via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-17 5:00 ` Aaron Jensen
2024-11-20 21:27 ` Alan Third
2024-11-20 21:38 ` Aaron Jensen
2024-11-20 21:59 ` Alan Third
2024-11-20 22:18 ` Aaron Jensen
2024-11-21 6:23 ` Eli Zaretskii
2024-11-21 7:13 ` Aaron Jensen
2024-11-23 1:12 ` Aaron Jensen
2024-11-23 2:20 ` Aaron Jensen
2024-11-24 12:10 ` Alan Third
2024-11-24 16:18 ` Aaron Jensen
2024-11-24 11:59 ` Alan Third [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0MVBS64EMkt_NH0@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=59790@debbugs.gnu.org \
--cc=aaronjensen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.