From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#44502: Date: Sun, 14 Aug 2022 14:30:04 +0000 Message-ID: References: <5aa738a4-cfd8-6c4e-3174-4489a289cca9@gmail.com> <878rnwi60h.fsf@quad> <83mtccqetc.fsf@gnu.org> <87leruhcdh.fsf@quad> <83y1vuoc5s.fsf@gnu.org> <87edxmha0b.fsf@quad> <83mtcanfhy.fsf@gnu.org> <87y1vtg3ok.fsf@quad> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35119"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44502@debbugs.gnu.org, acm@muc.de, Eli Zaretskii To: andrei.elkin@pp.inet.fi Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 14 16:31:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oNEe0-00091S-3w for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Aug 2022 16:31:12 +0200 Original-Received: from localhost ([::1]:33898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oNEdy-0006rX-Ft for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Aug 2022 10:31:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45384) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNEdq-0006qe-Jb for bug-gnu-emacs@gnu.org; Sun, 14 Aug 2022 10:31:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49754) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oNEdq-0004IL-A8 for bug-gnu-emacs@gnu.org; Sun, 14 Aug 2022 10:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oNEdq-0006ix-4D for bug-gnu-emacs@gnu.org; Sun, 14 Aug 2022 10:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Aug 2022 14:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44502 X-GNU-PR-Package: emacs Original-Received: via spool by 44502-submit@debbugs.gnu.org id=B44502.166048741825773 (code B ref 44502); Sun, 14 Aug 2022 14:31:02 +0000 Original-Received: (at 44502) by debbugs.gnu.org; 14 Aug 2022 14:30:18 +0000 Original-Received: from localhost ([127.0.0.1]:39503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNEd8-0006hc-6y for submit@debbugs.gnu.org; Sun, 14 Aug 2022 10:30:18 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:57458 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1oNEd2-0006gf-DJ for 44502@debbugs.gnu.org; Sun, 14 Aug 2022 10:30:16 -0400 Original-Received: (qmail 56032 invoked by uid 3782); 14 Aug 2022 14:30:05 -0000 Original-Received: from acm.muc.de (p4fe15ca3.dip0.t-ipconnect.de [79.225.92.163]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 14 Aug 2022 16:30:05 +0200 Original-Received: (qmail 20852 invoked by uid 1000); 14 Aug 2022 14:30:04 -0000 Content-Disposition: inline In-Reply-To: <87y1vtg3ok.fsf@quad> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239652 Archived-At: Hello, Andrei. On Fri, Aug 12, 2022 at 13:24:27 +0300, andrei.elkin@pp.inet.fi wrote: > Salve Eli! > >> From: andrei.elkin@pp.inet.fi > >> Cc: 44502@debbugs.gnu.org > >> Date: Thu, 11 Aug 2022 22:10:12 +0300 > >> Eli Zaretskii writes: > >> >> From: andrei.elkin@pp.inet.fi > >> >> Cc: 44502@debbugs.gnu.org > >> >> Date: Thu, 11 Aug 2022 21:19:06 +0300 > >> >> (gdb) p window > >> >> $4 = XIL(0x55555b038855) > >> >> (gdb) xwindow > >> >> $5 = (struct window *) 0x55555b038850 > >> >> 124x1+0+80 > >> >> (gdb) print XWINDOW(window)->contents > >> >> $6 = XIL(0x7fffea1bd07d) > >> >> (gdb) xbuffer > >> >> $7 = (struct buffer *) 0x7fffea1bd078 > >> >> 0x7fffea4aedc1 " *Minibuf-0*" > >> >> (gdb) print selected_window > >> >> $8 = XIL(0x55555b038645) > >> >> (gdb) xwindow > >> >> $9 = (struct window *) 0x55555b038640 > >> >> 124x80+0+0 > >> >> (gdb) print XWINDOW(selected_window)->contents > >> >> $10 = XIL(0x5555577f9475) > >> >> (gdb) xbuffer > >> >> $11 = (struct buffer *) 0x5555577f9470 > >> >> 0x555559788ff0 "magit: A<10.6>" > >> > Do you remember what were you doing when this assertion violation > >> > happened? > >> Something like > >> C-u M-x shell I've tried quite a bit to reproduce the error, but haven't managed. > >> > Also, are you using a separate minibuffer frame? > There are still *two* asserted emacs' frames around with "Minibuffer-1" > (not 0!) around. I think I understand what has caused the breakage of this assertion, and as Eli suggested, it is something fairly harmless. > >> No > > Then I tend to think that the assertion there is simply wrong. > > Adding Alan to CC, since this seems to be related to the > I am holing on the gdb session for your colleague just in case. Thanks! I'm sorry it's taken me so long to get back to you, it's been a chaotic weekend. > > minibuffer-follows-selected-frame feature. Alan, this happens in > > Emacs 28, so trying to fix it on the release branch in a safe way is > > important. TIA. > Thanks over for so far! If the assert comes back to me, I'd just comment it > out :-). I think the following fix to the assert should indeed be a "safe" fix, suitable for Emacs-28. Could you possibly apply it, please, and try to recreate the error. If you don't manage to recreate the error, the bug is probably "fixed". diff --git a/src/window.c b/src/window.c index 2576b66a18..35ec2a1f90 100644 --- a/src/window.c +++ b/src/window.c @@ -554,7 +554,9 @@ select_window (Lisp_Object window, Lisp_Object norecord, frame is active. */ Fselect_frame (frame, norecord); /* Fselect_frame called us back so we've done all the work already. */ - eassert (EQ (window, selected_window)); + eassert (EQ (window, selected_window) + || (EQ (window, f->minibuffer_window) + && NILP (Fminibufferp (XWINDOW (window)->contents, Qt)))); return window; } else > Have a good day! And yourself, too! > Andrei -- Alan Mackenzie (Nuremberg, Germany).