From: Alan Mackenzie <acm@muc.de>
To: andrei.elkin@pp.inet.fi
Cc: 44502@debbugs.gnu.org, acm@muc.de, Eli Zaretskii <eliz@gnu.org>
Subject: bug#44502:
Date: Sun, 14 Aug 2022 14:30:04 +0000 [thread overview]
Message-ID: <YvkG7FyPs5cmFfui@ACM> (raw)
In-Reply-To: <87y1vtg3ok.fsf@quad>
Hello, Andrei.
On Fri, Aug 12, 2022 at 13:24:27 +0300, andrei.elkin@pp.inet.fi wrote:
> Salve Eli!
> >> From: andrei.elkin@pp.inet.fi
> >> Cc: 44502@debbugs.gnu.org
> >> Date: Thu, 11 Aug 2022 22:10:12 +0300
> >> Eli Zaretskii <eliz@gnu.org> writes:
> >> >> From: andrei.elkin@pp.inet.fi
> >> >> Cc: 44502@debbugs.gnu.org
> >> >> Date: Thu, 11 Aug 2022 21:19:06 +0300
> >> >> (gdb) p window
> >> >> $4 = XIL(0x55555b038855)
> >> >> (gdb) xwindow
> >> >> $5 = (struct window *) 0x55555b038850
> >> >> 124x1+0+80
> >> >> (gdb) print XWINDOW(window)->contents
> >> >> $6 = XIL(0x7fffea1bd07d)
> >> >> (gdb) xbuffer
> >> >> $7 = (struct buffer *) 0x7fffea1bd078
> >> >> 0x7fffea4aedc1 " *Minibuf-0*"
> >> >> (gdb) print selected_window
> >> >> $8 = XIL(0x55555b038645)
> >> >> (gdb) xwindow
> >> >> $9 = (struct window *) 0x55555b038640
> >> >> 124x80+0+0
> >> >> (gdb) print XWINDOW(selected_window)->contents
> >> >> $10 = XIL(0x5555577f9475)
> >> >> (gdb) xbuffer
> >> >> $11 = (struct buffer *) 0x5555577f9470
> >> >> 0x555559788ff0 "magit: A<10.6>"
> >> > Do you remember what were you doing when this assertion violation
> >> > happened?
> >> Something like
> >> C-u M-x shell
I've tried quite a bit to reproduce the error, but haven't managed.
> >> > Also, are you using a separate minibuffer frame?
> There are still *two* asserted emacs' frames around with "Minibuffer-1"
> (not 0!) around.
I think I understand what has caused the breakage of this assertion, and
as Eli suggested, it is something fairly harmless.
> >> No
> > Then I tend to think that the assertion there is simply wrong.
> > Adding Alan to CC, since this seems to be related to the
> I am holing on the gdb session for your colleague just in case.
Thanks! I'm sorry it's taken me so long to get back to you, it's been a
chaotic weekend.
> > minibuffer-follows-selected-frame feature. Alan, this happens in
> > Emacs 28, so trying to fix it on the release branch in a safe way is
> > important. TIA.
> Thanks over for so far! If the assert comes back to me, I'd just comment it
> out :-).
I think the following fix to the assert should indeed be a "safe" fix,
suitable for Emacs-28. Could you possibly apply it, please, and try to
recreate the error. If you don't manage to recreate the error, the bug
is probably "fixed".
diff --git a/src/window.c b/src/window.c
index 2576b66a18..35ec2a1f90 100644
--- a/src/window.c
+++ b/src/window.c
@@ -554,7 +554,9 @@ select_window (Lisp_Object window, Lisp_Object norecord,
frame is active. */
Fselect_frame (frame, norecord);
/* Fselect_frame called us back so we've done all the work already. */
- eassert (EQ (window, selected_window));
+ eassert (EQ (window, selected_window)
+ || (EQ (window, f->minibuffer_window)
+ && NILP (Fminibufferp (XWINDOW (window)->contents, Qt))));
return window;
}
else
> Have a good day!
And yourself, too!
> Andrei
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2022-08-14 14:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 13:27 bug#44502: 28.0.50; Emacs crash using new frame Andy Moreton
2020-11-07 13:51 ` Andy Moreton
2020-11-07 14:05 ` Eli Zaretskii
2020-11-08 13:37 ` Alan Mackenzie
2020-11-08 15:15 ` Eli Zaretskii
2020-11-08 15:36 ` Andy Moreton
2021-09-08 9:52 ` Lars Ingebrigtsen
2022-08-10 13:26 ` bug#44502: andrei.elkin--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-10 15:49 ` bug#44502: Eli Zaretskii
2022-08-11 18:19 ` bug#44502: andrei.elkin--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-11 18:41 ` bug#44502: Eli Zaretskii
2022-08-11 19:10 ` bug#44502: andrei.elkin--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-12 6:27 ` bug#44502: Eli Zaretskii
2022-08-12 8:34 ` bug#44502: Alan Mackenzie
2022-08-12 10:24 ` bug#44502: andrei.elkin--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-14 14:30 ` Alan Mackenzie [this message]
2022-08-19 10:45 ` bug#44502: Eli Zaretskii
2022-08-19 13:05 ` bug#44502: Alan Mackenzie
2022-08-19 13:20 ` bug#44502: Eli Zaretskii
2022-08-19 15:12 ` bug#44502: Alan Mackenzie
2022-08-19 16:10 ` bug#44502: andrei.elkin--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvkG7FyPs5cmFfui@ACM \
--to=acm@muc.de \
--cc=44502@debbugs.gnu.org \
--cc=andrei.elkin@pp.inet.fi \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.