From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#55684: 29.0.50; wrong-type-argument in minibuffer-only frames Date: Sat, 28 May 2022 10:51:25 +0000 Message-ID: References: <83h75amc97.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16886"; mail-complaints-to="usenet@ciao.gmane.io" Cc: martin rudalics , 55684@debbugs.gnu.org, Stefan Monnier , acm@muc.de To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 28 12:52:39 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nuu3j-0004Ez-Bq for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 May 2022 12:52:39 +0200 Original-Received: from localhost ([::1]:43666 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nuu3i-0006kj-2n for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 May 2022 06:52:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50058) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuu38-0006it-KK for bug-gnu-emacs@gnu.org; Sat, 28 May 2022 06:52:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42575) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nuu37-0000tn-Qb for bug-gnu-emacs@gnu.org; Sat, 28 May 2022 06:52:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nuu37-0002Cf-PX for bug-gnu-emacs@gnu.org; Sat, 28 May 2022 06:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 May 2022 10:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55684 X-GNU-PR-Package: emacs Original-Received: via spool by 55684-submit@debbugs.gnu.org id=B55684.16537350968439 (code B ref 55684); Sat, 28 May 2022 10:52:01 +0000 Original-Received: (at 55684) by debbugs.gnu.org; 28 May 2022 10:51:36 +0000 Original-Received: from localhost ([127.0.0.1]:36472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuu2i-0002C2-7B for submit@debbugs.gnu.org; Sat, 28 May 2022 06:51:36 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:37258 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1nuu2e-0002Bk-1Y for 55684@debbugs.gnu.org; Sat, 28 May 2022 06:51:34 -0400 Original-Received: (qmail 10305 invoked by uid 3782); 28 May 2022 10:51:26 -0000 Original-Received: from acm.muc.de (p2e5d51fd.dip0.t-ipconnect.de [46.93.81.253]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 28 May 2022 12:51:26 +0200 Original-Received: (qmail 4837 invoked by uid 1000); 28 May 2022 10:51:25 -0000 Content-Disposition: inline In-Reply-To: <83h75amc97.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:233250 Archived-At: Hello, Eli. On Sat, May 28, 2022 at 08:56:04 +0300, Eli Zaretskii wrote: > > Cc: Alan Mackenzie > > Date: Fri, 27 May 2022 16:09:13 -0400 > > From: Stefan Monnier via "Bug reports for GNU Emacs, > > the Swiss army knife of text editors" > > Package: Emacs > > Version: 29.0.50 > Doesn't the same problem exist on the emacs-28 branch? I can > reproduce it there. > > - Fset_frame_selected_window (frame, call1 (Qget_mru_window, frame), Qnil); > > + { > > + Lisp_Object w = call1 (Qget_mru_window, frame); > > + if (!NILP (w)) /* Can be nil in minibuffer-only frames. */ > > + Fset_frame_selected_window (frame, w, Qnil); > The NILP(w) test should probably be WINDOW_LIVE_P(w). Martin, do you > agree? I'm not Martin, but I think WINDOW_LIVE is safe, but might not be needed. I think get-mru-window will only return a live window or nil. -- Alan Mackenzie (Nuremberg, Germany).