From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#55414: 29.0.50; Byte compilation error for the modus-themes Date: Fri, 27 May 2022 09:52:30 +0000 Message-ID: References: <83ilpx7l8c.fsf@gnu.org> <87tu9gyki9.fsf@protesilaos.com> <83czg47bz7.fsf@gnu.org> <87v8tv7dht.fsf@protesilaos.com> <83mtf75grb.fsf@gnu.org> <87h75el2f5.fsf@protesilaos.com> <83r14h4uyi.fsf@gnu.org> <87tu9crg7f.fsf@protesilaos.com> <838rqopm0q.fsf@gnu.org> <875ylscxre.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29860"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acm@muc.de, Eli Zaretskii , Protesilaos Stavrou , 55414@debbugs.gnu.org, Stefan Monnier To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 27 11:53:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nuWeg-0007Tu-Gb for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 May 2022 11:53:14 +0200 Original-Received: from localhost ([::1]:40374 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nuWef-0004Sc-BW for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 May 2022 05:53:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48814) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuWeT-0004P7-Tv for bug-gnu-emacs@gnu.org; Fri, 27 May 2022 05:53:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38860) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nuWeT-0007ZG-JP for bug-gnu-emacs@gnu.org; Fri, 27 May 2022 05:53:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nuWeT-0004sc-IJ for bug-gnu-emacs@gnu.org; Fri, 27 May 2022 05:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 May 2022 09:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55414 X-GNU-PR-Package: emacs Original-Received: via spool by 55414-submit@debbugs.gnu.org id=B55414.165364517118743 (code B ref 55414); Fri, 27 May 2022 09:53:01 +0000 Original-Received: (at 55414) by debbugs.gnu.org; 27 May 2022 09:52:51 +0000 Original-Received: from localhost ([127.0.0.1]:60990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuWeI-0004sD-Kl for submit@debbugs.gnu.org; Fri, 27 May 2022 05:52:51 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:55291 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1nuWe5-0004rk-NX for 55414@debbugs.gnu.org; Fri, 27 May 2022 05:52:49 -0400 Original-Received: (qmail 84903 invoked by uid 3782); 27 May 2022 09:52:31 -0000 Original-Received: from acm.muc.de (p4fe15b6f.dip0.t-ipconnect.de [79.225.91.111]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 27 May 2022 11:52:30 +0200 Original-Received: (qmail 3476 invoked by uid 1000); 27 May 2022 09:52:30 -0000 Content-Disposition: inline In-Reply-To: <875ylscxre.fsf@gnus.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:233168 Archived-At: Hello, Lars. On Thu, May 26, 2022 at 13:57:09 +0200, Lars Ingebrigtsen wrote: > Eli Zaretskii writes: > > Lars, is it just me, or are you also concerned by a large increase in > > the default values of these variables? > I'm not really that concerned in general, but in this case, the entire > problem .... Which problem would that be, exactly? If it's the failure of modus-themes to compile without causing a stack overflow error, then ... > .... is apparently due to one function -- > byte-compile--first-symbol-with-pos -- that's very recursive. No, no, no, no. byte-compile--first-symbol-with-pos is NOT the cause of the stack overflow - it's part of the handling of that stack overflow, and unfortunately causes a second stack overflow. Having examined Prot's backtraces (around 16th May), I explained this in my post of 2022-05-16 as follows: ######################################################################### Looking a bit more carefully at the backtrace, it's evident there were two lisp eval depth overflows. The first was in the compilation of the library, where a condition-case was used to discard the diagnostic data (I hate it when this is done). This was in the macro displaying-byte-compile-warnings in .../lisp/emacs-lisp/bytecomp.el. This failure then called the byte compiler error routines, which caused the second overflow, in byte-compile--first-symbol-with-pos. This second overflow is "only just" happening - another few spare slots, and it would have succeeded; at least on this particular part of the program structure. ######################################################################### > It could be rewritten to not be recursive, and these problems would go > away (which we've seen in many contexts now), if I understand > correctly. You're saying byte-compile--first-symbol-with-pos could be reformulated to be non-recursive, I think. I don't understand that. It is a function working on an arbitrary tree structure. Such functions are always coded using recursion, aren't they? What am I missing here? > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no -- Alan Mackenzie (Nuremberg, Germany).