From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kelly Dean Newsgroups: gmane.emacs.bugs Subject: bug#19685: [PATCH] define-minor-mode docstring generation bug Date: Sun, 25 Jan 2015 08:52:42 +0000 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1422176054 9367 80.91.229.3 (25 Jan 2015 08:54:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 25 Jan 2015 08:54:14 +0000 (UTC) To: 19685@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 25 09:54:10 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YFIxO-00025i-18 for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Jan 2015 09:54:10 +0100 Original-Received: from localhost ([::1]:37152 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFIxN-0000eJ-H1 for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Jan 2015 03:54:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFIxJ-0000dr-Ve for bug-gnu-emacs@gnu.org; Sun, 25 Jan 2015 03:54:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YFIxG-0004ie-Km for bug-gnu-emacs@gnu.org; Sun, 25 Jan 2015 03:54:05 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36898) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFIxG-0004ia-Gv for bug-gnu-emacs@gnu.org; Sun, 25 Jan 2015 03:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YFIxG-00047R-94 for bug-gnu-emacs@gnu.org; Sun, 25 Jan 2015 03:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Kelly Dean Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Jan 2015 08:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 19685 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.142217603815822 (code B ref -1); Sun, 25 Jan 2015 08:54:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 25 Jan 2015 08:53:58 +0000 Original-Received: from localhost ([127.0.0.1]:55590 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YFIxC-000478-6B for submit@debbugs.gnu.org; Sun, 25 Jan 2015 03:53:58 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:34654) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YFIxA-00046v-W4 for submit@debbugs.gnu.org; Sun, 25 Jan 2015 03:53:57 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YFIx4-0004gW-VA for submit@debbugs.gnu.org; Sun, 25 Jan 2015 03:53:51 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:39906) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFIx4-0004gR-TE for submit@debbugs.gnu.org; Sun, 25 Jan 2015 03:53:50 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36368) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFIx3-0000bb-V2 for bug-gnu-emacs@gnu.org; Sun, 25 Jan 2015 03:53:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YFIx0-0004fd-Pd for bug-gnu-emacs@gnu.org; Sun, 25 Jan 2015 03:53:49 -0500 Original-Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:52379) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFIx0-0004fN-JL for bug-gnu-emacs@gnu.org; Sun, 25 Jan 2015 03:53:46 -0500 Original-Received: from mfilter27-d.gandi.net (mfilter27-d.gandi.net [217.70.178.155]) by relay3-d.mail.gandi.net (Postfix) with ESMTP id A72A1A80B6 for ; Sun, 25 Jan 2015 09:53:45 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mfilter27-d.gandi.net Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by mfilter27-d.gandi.net (mfilter27-d.gandi.net [10.0.15.180]) (amavisd-new, port 10024) with ESMTP id KnDhtn3KgLyt for ; Sun, 25 Jan 2015 09:53:44 +0100 (CET) X-Originating-IP: 66.220.3.179 Original-Received: from localhost (gm179.geneticmail.com [66.220.3.179]) (Authenticated sender: kelly@prtime.org) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id AA38AA80B1 for ; Sun, 25 Jan 2015 09:53:42 +0100 (CET) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98698 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Try this: (define-minor-mode foo "foo" :global t) The variable it creates includes a docstring with =E2=8C=9CSetting this variable directly does not take effect=E2=8C=9D. That's a bug. The attached dmm-docstring-gen-bug.patch fixes it. Also attached is dmm-docstring-clarification.patch. (Not a bug, but might= as well include it here.) --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=dmm-docstring-gen-bug.patch --- emacs-24.4/lisp/emacs-lisp/easy-mmode.el +++ emacs-24.4/lisp/emacs-lisp/easy-mmode.el @@ -158,7 +158,8 @@ ;; Allow skipping the first three args. (cond ((keywordp init-value) - (setq body `(,init-value ,lighter ,keymap ,@body) + (setq body (if keymap `(,init-value ,lighter ,keymap ,@body) + `(,init-value ,lighter)) init-value nil lighter nil keymap nil)) ((keywordp lighter) (setq body `(,lighter ,keymap ,@body) lighter nil keymap nil)) --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=dmm-docstring-clarification.patch --- emacs-24.4/lisp/emacs-lisp/easy-mmode.el +++ emacs-24.4/lisp/emacs-lisp/easy-mmode.el @@ -114,9 +114,11 @@ BODY contains code to execute each time the mode is enabled or disabled. It is executed after toggling the mode, and before running MODE-hook. Before the actual body code, you can write keyword arguments, i.e. - alternating keywords and values. These following special keywords - are supported (other keywords are passed to `defcustom' if the minor - mode is global): + alternating keywords and values. If you provide BODY, then you must + provide INIT-VALUE, LIGHTER, and KEYMAP, or provide at least one + keyword argument, or both; otherwise, BODY would be misinterpreted. + The following special keywords are supported (other keywords are passed + to `defcustom' if the minor mode is global): :group GROUP Custom group name to use in all generated `defcustom' forms. Defaults to MODE without the possible trailing \"-mode\". --=-=-=--