bug#55082: emacs-28.1-installer.exe not signed by Phillip Lord

bug#55082: emacs-28.1-installer.exe not signed by Phillip Lord

[Matthew James Kraai]

Hi,

https://www.gnu.org/software/emacs/download.html says that Windows
binaries are signed by Phillip Lord, but
http://ftp.gnu.org/gnu/emacs/windows/emacs-28/emacs-28.1-installer.exe
is signed by Corwin Brust <corwin@bru.st>.  Does the web page need to
be updated?

-- 
Matt

bug#55082: emacs-28.1-installer.exe not signed by Phillip Lord

[Corwin Brust]

On Sat, Apr 23, 2022 at 11:26 AM Matthew James Kraai <kraai@ftbfs.org> wrote:
>
> https://www.gnu.org/software/emacs/download.html says that Windows
> binaries are signed by Phillip Lord, but
> http://ftp.gnu.org/gnu/emacs/windows/emacs-28/emacs-28.1-installer.exe
> is signed by Corwin Brust <corwin@bru.st>.  Does the web page need to
> be updated?

Hi Matt,

Yes, thanks!

I'm not sure I know where these sources are; if I can figure it out
I'll prepare a patch but feel free to have a swing at it if you are so
inclined.

Thanks for reporting.
Corwin

bug#55082: emacs-28.1-installer.exe not signed by Phillip Lord

[Lars Ingebrigtsen]

Corwin Brust <corwin@bru.st> writes:

> I'm not sure I know where these sources are; if I can figure it out
> I'll prepare a patch but feel free to have a swing at it if you are so
> inclined.

It's in the CVS repo for the web pages.  I can update them (if you don't
have cvs installed) -- here's the current text, what should it be
updated to?

------------

                    <p>The Windows binaries are signed by Phillip
                      Lord <code>8E64 B119 FE4B AC58 C767 D5EC E095 C1A6 3FB1 EAD2</code>.</p>

                    <p>MSYS2 users can install Emacs (64bits build) with the following:</p>


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#55082: emacs-28.1-installer.exe not signed by Phillip Lord

[Corwin Brust]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

On Sat, Apr 23, 2022 at 1:34 PM Lars Ingebrigtsen <larsi@gnus.org> wrote:
>
> Corwin Brust <corwin@bru.st> writes:
>
> I can update them

I did manage to find them;  a patch is attached.

Thank you Lars.

[-- Attachment #2: update-win32-builder.patch --]
[-- Type: application/octet-stream, Size: 673 bytes --]

--- download.html.orig	2022-04-23 13:47:39.399196200 -0500
+++ download.html	2022-04-23 13:47:56.191567200 -0500
@@ -151,8 +151,8 @@
                       shortcut's icon.
                     </p>
 
-                    <p>The Windows binaries are signed by Phillip
-                      Lord <code>8E64 B119 FE4B AC58 C767 D5EC E095 C1A6 3FB1 EAD2</code>.</p>
+                    <p>The Windows binaries are signed by Corwin
+		      Brust <code>ECE7 7CF4 17C7 6C1A CFCE 7C2B 5B61 3551 1580 F007</code>.</p>
 
                     <p>MSYS2 users can install Emacs (64bits build) with the following:</p>
                     <pre>pacman -S mingw-w64-x86_64-emacs</pre>

bug#55082: emacs-28.1-installer.exe not signed by Phillip Lord

[Corwin Brust]

On Sat, Apr 23, 2022 at 1:51 PM Corwin Brust <corwin@bru.st> wrote:
>
> On Sat, Apr 23, 2022 at 1:34 PM Lars Ingebrigtsen <larsi@gnus.org> wrote:
> >
> > I can update them
>
> I did manage to find them;  a patch is attached.

Apropos, I notice there's no mention of the executable installer on
the page either.  Would it make sense for me to try preparing a second
patch to provide some information about the binary release versions we
currently produce for MS Windows?  If so, is it worth having a new bug
report to keep track of that seperately that work/discussion
separately?

bug#55082: emacs-28.1-installer.exe not signed by Phillip Lord

[Lars Ingebrigtsen]

Corwin Brust <corwin@bru.st> writes:

> Apropos, I notice there's no mention of the executable installer on
> the page either.  Would it make sense for me to try preparing a second
> patch to provide some information about the binary release versions we
> currently produce for MS Windows?

What kind of information did you have in mind?  I think that web page
should be kept as concise as possible, with the bare minimum of talk
beyond how to download things on various platforms.

> If so, is it worth having a new bug report to keep track of that
> seperately that work/discussion separately?

No, discussing that's fine here.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#55082: emacs-28.1-installer.exe not signed by Phillip Lord

[Corwin Brust]

[-- Attachment #1: Type: text/plain, Size: 2402 bytes --]

On Sat, Apr 23, 2022 at 3:06 PM Lars Ingebrigtsen <larsi@gnus.org> wrote:
>
> What kind of information did you have in mind?  I think that web page
> should be kept as concise as possible, with the bare minimum of talk
> beyond how to download things on various platforms.

Right, and I tend to agree FWIW.

Here's one option that reduces things further:

--- download.html.orig  2022-04-23 15:19:55.160069600 -0500
+++ download.html       2022-04-23 15:28:26.108068700 -0500
@@ -145,10 +145,9 @@
                         GNU mirror</a>; or the <a
href="http://ftp.gnu.org/gnu/emacs/windows/">main
                         GNU FTP server</a>.
                       <br/>
-                      Unzip the zip file preserving the directory
structure, and run
-                      <code>bin\runemacs.exe</code>.  Alternatively,
create a desktop shortcut to
-                      <code>bin\runemacs.exe</code>, and start Emacs
by double-clicking on that
-                      shortcut's icon.
+                      Binaries are provided in several forms.  Most
simply, download and run the
+                     emacs-<code>version</code>-installer.exe which
will install Emacs and
+                     create shortcuts for you.
                     </p>

                     <p>The Windows binaries are signed by Corwin

Here's a  less intrusive alternative, attempting to minimally add
mention of the self-installer:

--- download.html.orig  2022-04-23 15:19:55.160069600 -0500
+++ download.html       2022-04-23 15:31:50.015567900 -0500
@@ -146,9 +146,11 @@
                         GNU FTP server</a>.
                       <br/>
                       Unzip the zip file preserving the directory
structure, and run
-                      <code>bin\runemacs.exe</code>.  Alternatively,
create a desktop shortcut to
+                      <code>bin\runemacs.exe</code>.  You can create
a desktop shortcut to
                       <code>bin\runemacs.exe</code>, and start Emacs
by double-clicking on that
-                      shortcut's icon.
+                      shortcut's icon.  Alternately, download and run the
+                     emacs-<code>version</code>-installer.exe which
will install Emacs and
+                     create shortcuts for you.
                     </p>

                     <p>The Windows binaries are signed by Corwin

Patches for both versions are attached.

[-- Attachment #2: mention-win32-installer.patch --]
[-- Type: application/octet-stream, Size: 905 bytes --]

--- download.html.orig	2022-04-23 15:19:55.160069600 -0500
+++ download.html	2022-04-23 15:31:50.015567900 -0500
@@ -146,9 +146,11 @@
                         GNU FTP server</a>.
                       <br/>
                       Unzip the zip file preserving the directory structure, and run
-                      <code>bin\runemacs.exe</code>.  Alternatively, create a desktop shortcut to
+                      <code>bin\runemacs.exe</code>.  You can create a desktop shortcut to
                       <code>bin\runemacs.exe</code>, and start Emacs by double-clicking on that
-                      shortcut's icon.
+                      shortcut's icon.  Alternately, download and run the
+		      emacs-<code>version</code>-installer.exe which will install Emacs and
+		      create shortcuts for you.
                     </p>
 
                     <p>The Windows binaries are signed by Corwin

[-- Attachment #3: prefer-installer-for-win32.patch --]
[-- Type: application/octet-stream, Size: 937 bytes --]

--- download.html.orig	2022-04-23 15:19:55.160069600 -0500
+++ download.html	2022-04-23 15:28:26.108068700 -0500
@@ -145,10 +145,9 @@
                         GNU mirror</a>; or the <a href="http://ftp.gnu.org/gnu/emacs/windows/">main
                         GNU FTP server</a>.
                       <br/>
-                      Unzip the zip file preserving the directory structure, and run
-                      <code>bin\runemacs.exe</code>.  Alternatively, create a desktop shortcut to
-                      <code>bin\runemacs.exe</code>, and start Emacs by double-clicking on that
-                      shortcut's icon.
+                      Binaries are provided in several forms.  Most simply, download and run the
+		      emacs-<code>version</code>-installer.exe which will install Emacs and
+		      create shortcuts for you.
                     </p>
 
                     <p>The Windows binaries are signed by Corwin

bug#55082: emacs-28.1-installer.exe not signed by Phillip Lord

[Eli Zaretskii]

> From: Corwin Brust <corwin@bru.st>
> Date: Sat, 23 Apr 2022 15:34:16 -0500
> Cc: 55082@debbugs.gnu.org, Matthew James Kraai <kraai@ftbfs.org>
> 
> On Sat, Apr 23, 2022 at 3:06 PM Lars Ingebrigtsen <larsi@gnus.org> wrote:
> >
> > What kind of information did you have in mind?  I think that web page
> > should be kept as concise as possible, with the bare minimum of talk
> > beyond how to download things on various platforms.
> 
> Right, and I tend to agree FWIW.
> 
> Here's one option that reduces things further:
> 
> --- download.html.orig  2022-04-23 15:19:55.160069600 -0500
> +++ download.html       2022-04-23 15:28:26.108068700 -0500
> @@ -145,10 +145,9 @@
>                          GNU mirror</a>; or the <a
> href="http://ftp.gnu.org/gnu/emacs/windows/">main
>                          GNU FTP server</a>.
>                        <br/>
> -                      Unzip the zip file preserving the directory
> structure, and run
> -                      <code>bin\runemacs.exe</code>.  Alternatively,
> create a desktop shortcut to
> -                      <code>bin\runemacs.exe</code>, and start Emacs
> by double-clicking on that
> -                      shortcut's icon.
> +                      Binaries are provided in several forms.  Most
> simply, download and run the
> +                     emacs-<code>version</code>-installer.exe which
> will install Emacs and
> +                     create shortcuts for you.
>                      </p>
> 
>                      <p>The Windows binaries are signed by Corwin
> 
> Here's a  less intrusive alternative, attempting to minimally add
> mention of the self-installer:
> 
> --- download.html.orig  2022-04-23 15:19:55.160069600 -0500
> +++ download.html       2022-04-23 15:31:50.015567900 -0500
> @@ -146,9 +146,11 @@
>                          GNU FTP server</a>.
>                        <br/>
>                        Unzip the zip file preserving the directory
> structure, and run
> -                      <code>bin\runemacs.exe</code>.  Alternatively,
> create a desktop shortcut to
> +                      <code>bin\runemacs.exe</code>.  You can create
> a desktop shortcut to
>                        <code>bin\runemacs.exe</code>, and start Emacs
> by double-clicking on that
> -                      shortcut's icon.
> +                      shortcut's icon.  Alternately, download and run the
> +                     emacs-<code>version</code>-installer.exe which
> will install Emacs and
> +                     create shortcuts for you.
>                      </p>
> 
>                      <p>The Windows binaries are signed by Corwin
> 
> Patches for both versions are attached.

The second one is better, IMO, but please fix a minor stylistic nit:
saying "Alternately" twice in a row should be avoided.  How about
replacing the second on with "Or"?

bug#55082: emacs-28.1-installer.exe not signed by Phillip Lord

[Corwin Brust]

On Sun, Apr 24, 2022 at 12:15 AM Eli Zaretskii <eliz@gnu.org> wrote:
>
> The second one is better, IMO, but please fix a minor stylistic nit:
> saying "Alternately" twice in a row should be avoided.  How about
> replacing the second on with "Or"?

I believe I had reworded the prior occurrence to avoid using
"Alternately" twice.  Any chance you misread the patch?  In any event,
although I prefer the first/shorter version, I'm fine deferring to
your judgment (it's why I proffered two versions, after all).

Thanks for weighing in.

bug#55082: emacs-28.1-installer.exe not signed by Phillip Lord

[Eli Zaretskii]

> From: Corwin Brust <corwin@bru.st>
> Date: Sun, 24 Apr 2022 00:43:47 -0500
> Cc: Lars Ingebrigtsen <larsi@gnus.org>, 55082@debbugs.gnu.org, 
> 	Matthew James Kraai <kraai@ftbfs.org>
> 
> On Sun, Apr 24, 2022 at 12:15 AM Eli Zaretskii <eliz@gnu.org> wrote:
> >
> > The second one is better, IMO, but please fix a minor stylistic nit:
> > saying "Alternately" twice in a row should be avoided.  How about
> > replacing the second on with "Or"?
> 
> I believe I had reworded the prior occurrence to avoid using
> "Alternately" twice.  Any chance you misread the patch?

Yes, sorry.  But the rewording loses information: it makes it sound
like one must do the second step, whereas the original text correctly
explained that it is an alternative to the first method.

IOW, we now have 2.5 methods for installation, not just 2 as your text
hints.

> In any event, although I prefer the first/shorter version, I'm fine
> deferring to your judgment (it's why I proffered two versions, after
> all).

It might be shorter, but it says nothing about the zip file, and IMO
this is important, especially for people who are uneasy running
executables downloaded from Web sites, or running installers in
general.  (It is okay, IMO, to mention the installer version first and
the zip version second, though.)

bug#55082: emacs-28.1-installer.exe not signed by Phillip Lord

[Corwin Brust]

On Sun, Apr 24, 2022 at 1:16 AM Eli Zaretskii <eliz@gnu.org> wrote:
>
> It might be shorter, but it says nothing about the zip file, and IMO
> this is important, especially for people who are uneasy running
> executables downloaded from Web sites, or running installers in
> general.  (It is okay, IMO, to mention the installer version first and
> the zip version second, though.)

Thanks for these very helpful comments; I'll work up a new patch.

bug#55082: emacs-28.1-installer.exe not signed by Phillip Lord

[Corwin Brust]

[-- Attachment #1: Type: text/plain, Size: 1770 bytes --]

On Sun, Apr 24, 2022 at 1:22 AM Corwin Brust <corwin@bru.st> wrote:
>
> On Sun, Apr 24, 2022 at 1:16 AM Eli Zaretskii <eliz@gnu.org> wrote:
> >
> > It might be shorter, but it says nothing about the zip file, and IMO
> > this is important, especially for people who are uneasy running
> > executables downloaded from Web sites, or running installers in
> > general.  (It is okay, IMO, to mention the installer version first and
> > the zip version second, though.)
>
> Thanks for these very helpful comments; I'll work up a new patch.

A next patch attempt is quoted below and included as an attachment.

--- download.html.orig  2022-04-23 15:19:55.160069600 -0500
+++ download.html       2022-04-24 01:29:10.486570000 -0500
@@ -145,9 +145,11 @@
                         GNU mirror</a>; or the <a
href="http://ftp.gnu.org/gnu/emacs/windows/">main
                         GNU FTP server</a>.
                       <br/>
-                      Unzip the zip file preserving the directory
structure, and run
-                      <code>bin\runemacs.exe</code>.  Alternatively,
create a desktop shortcut to
-                      <code>bin\runemacs.exe</code>, and start Emacs
by double-clicking on that
+                      Mostly simply, download and run the
emacs-<code>version</code>-installer.exe
+                      which will install Emacs and create shortcuts
for you.  Alternately, download
+                      emacs-<code>version</code>.zip then unzip,
preserving the directory structure.
+                      You can then run <code>bin\runemacs.exe</code>
or create a desktop shortcut to
+                      <code>bin\runemacs.exe</code> and start Emacs
by double-clicking on that
                       shortcut's icon.
                     </p>

[-- Attachment #2: mention-win32-installer-first.patch --]
[-- Type: application/octet-stream, Size: 1160 bytes --]

--- download.html.orig	2022-04-23 15:19:55.160069600 -0500
+++ download.html	2022-04-24 01:29:10.486570000 -0500
@@ -145,9 +145,11 @@
                         GNU mirror</a>; or the <a href="http://ftp.gnu.org/gnu/emacs/windows/">main
                         GNU FTP server</a>.
                       <br/>
-                      Unzip the zip file preserving the directory structure, and run
-                      <code>bin\runemacs.exe</code>.  Alternatively, create a desktop shortcut to
-                      <code>bin\runemacs.exe</code>, and start Emacs by double-clicking on that
+                      Mostly simply, download and run the emacs-<code>version</code>-installer.exe
+                      which will install Emacs and create shortcuts for you.  Alternately, download
+                      emacs-<code>version</code>.zip then unzip, preserving the directory structure.
+                      You can then run <code>bin\runemacs.exe</code> or create a desktop shortcut to
+                      <code>bin\runemacs.exe</code> and start Emacs by double-clicking on that
                       shortcut's icon.
                     </p>
 

bug#55082: emacs-28.1-installer.exe not signed by Phillip Lord

[Lars Ingebrigtsen]

Corwin Brust <corwin@bru.st> writes:

> A next patch attempt is quoted below and included as an attachment.

Looks good to me; checked in now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#55082: emacs-28.1-installer.exe not signed by Phillip Lord

[Corwin Brust]

On Sun, Apr 24, 2022 at 6:18 AM Lars Ingebrigtsen <larsi@gnus.org> wrote:
>
> Looks good to me; checked in now.

I think things are looking good now so I'm marking this bug as done.
If there's more to do please reply to the debbugs address (the version
without the -done suffix) and we can re-open.

Thanks again for reporting.
Corwin

bug#55082: emacs-28.1-installer.exe not signed by Phillip Lord

[Matthew James Kraai]

On Sun, Apr 24, 2022 at 10:29:03AM -0500, Corwin Brust wrote:
> On Sun, Apr 24, 2022 at 6:18 AM Lars Ingebrigtsen <larsi@gnus.org> wrote:
> >
> > Looks good to me; checked in now.
> 
> I think things are looking good now so I'm marking this bug as done.
> If there's more to do please reply to the debbugs address (the version
> without the -done suffix) and we can re-open.
> 
> Thanks again for reporting.

Thank you for fixing it.

-- 
Matt

bug#55082: emacs-28.1-installer.exe not signed by Phillip Lord

[Lars Ingebrigtsen]

Corwin Brust <corwin@bru.st> writes:

> I did manage to find them;  a patch is attached.

Thanks; now checked in, so the web pages should update themselves within
some minutes.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no