From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: Emacs 28 on OSX: emacsclient.c:1415: warning: implicit declaration of function 'openat' Date: Thu, 21 Apr 2022 20:21:37 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12788"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , Mattias =?iso-8859-1?Q?Engdeg=E5rd?= , Paul Eggert , emacs-devel@gnu.org To: Keith David Bershatsky Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 21 21:23:30 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nhcOn-000394-4o for ged-emacs-devel@m.gmane-mx.org; Thu, 21 Apr 2022 21:23:29 +0200 Original-Received: from localhost ([::1]:47854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nhcOl-0008Qk-R5 for ged-emacs-devel@m.gmane-mx.org; Thu, 21 Apr 2022 15:23:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43500) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhcNJ-0007PW-NE for emacs-devel@gnu.org; Thu, 21 Apr 2022 15:21:57 -0400 Original-Received: from outbound.soverin.net ([116.202.126.228]:41267) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhcNH-0004FY-IT for emacs-devel@gnu.org; Thu, 21 Apr 2022 15:21:57 -0400 Original-Received: from smtp.soverin.net (unknown [10.10.3.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 02222298; Thu, 21 Apr 2022 19:21:51 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [10.10.4.99]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1650568910; bh=P+cN2jwNVKF440USB65VmfXkJYoDCR4wKhI158eHJEQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eVv8tkxpmT0cNM1IGyErZ+CCfEkrVuayrB4UEA0wh+/Ht4hXi4UqqB557ioKU6I3j oV4gw5mrMQNYzDshg1SMwJPISEd05MlgGpMlyhVsbiMEmIryENzvBFOMyc4PnJdW/I lOCGzFYMwqH8X+DCC8ClYwvq3x4UouaKueADPgTGSfuQVmLNSnCuojsFmY/0IxHqhI LQehNE+2iiGHpmLPDObBNAB73pyZKLq2azcS5Zf/Jy4egWdQoa+1NQcO1XKekG5lqi VOMmk8NAS8qi9lP5FWZ3on4ewfJCMTaJnFjZ3phUfDEXzThTzdrMeBYI8UMpB/mvtn 4nYW+OdQRHmEg== Original-Received: from alan by faroe.holly.idiocy.org with local (Exim 4.95) (envelope-from ) id 1nhcMz-000h6D-Bm; Thu, 21 Apr 2022 20:21:37 +0100 Mail-Followup-To: Alan Third , Keith David Bershatsky , emacs-devel@gnu.org, Po Lu , Mattias =?iso-8859-1?Q?Engdeg=E5rd?= , Paul Eggert Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=116.202.126.228; envelope-from=alan@idiocy.org; helo=outbound.soverin.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288774 Archived-At: On Thu, Apr 21, 2022 at 10:52:19AM -0700, Keith David Bershatsky wrote: > The gdb backtrace text file colorUsingDefaultColorSpace.txt relates > to _only_ the change of deviceRGBColorSpace to genericRGBColorSpace. > > The gdb backtrace text file unsignedlong.txt relates to _only_ the > change the change of [self getRed:&r green:&g blue:&b alpha:&a]; to > [[self colorUsingDefaultColorSpace] getRed:&r green:&g blue:&b > alpha:&a]; > > The gdb backtrace text file both_changes.txt relates to both of the > suggested changes. OK, thanks... Can you please try changing ns_query_color so that [((NSColor *)col) getRed: &r green: &g blue: &b alpha: &a]; is [[((NSColor *)col) colorUsingColorSpace:genericRGBColorSpace] getRed: &r green: &g blue: &b alpha: &a]; I'm not holding out much hope here. I can't see what change has caused this. There's been a lot of changes to the colour handling, but afaict the colour spaces should all be unchanged. Especially on 10.6... -- Alan Third