Re: Emacs 28 on OSX: emacsclient.c:1415: warning: implicit declaration of function 'openat'

[Alan Third <alan@idiocy.org>]

[-- Attachment #1: Type: text/plain, Size: 1432 bytes --]

On Wed, Apr 20, 2022 at 06:55:51AM -0700, Keith David Bershatsky wrote:
> Using the most recent patch by Alan permits the build to now proceed to macfont.m, where it stops:
> 
>   CC       macfont.o
> In file included from macfont.m:24:
> lisp.h:2156: warning: declaration does not declare anything
> macfont.m: In function 'mac_font_shape_1':
> macfont.m:425: warning: 'NSLayoutManager' may not respond to '-getGlyphsInRange:glyphs:properties:characterIndexes:bidiLevels:'
> macfont.m:425: warning: (Messages without a matching method signature
> macfont.m:425: warning: will be assumed to return 'id' and accept
> macfont.m:425: warning: '...' as arguments.)

This one is funny since he code's been there since 2017, and according
to Apple the method is supported in 10.6, so I'm leaving it for now
since there's no error.

> macfont.m: In function 'mac_font_create_preferred_family_for_attributes':
> macfont.m:3575: error: 'NSOperatingSystemVersion' undeclared (first use in this function)
> macfont.m:3575: error: (Each undeclared identifier is reported only once
> macfont.m:3575: error: for each function it appears in.)
> macfont.m:3575: error: expected ')' before '{' token
> macfont.m:3576: warning: 'NSProcessInfo' may not respond to '-isOperatingSystemAtLeastVersion:'
> make[1]: *** [macfont.o] Error 1
> make: *** [src] Error 2
> ~/Desktop/emacs $

Please try the attached and let us know what happens.
-- 
Alan Third

[-- Attachment #2: v4-0001-Fix-nsmenu-compilation-under-macOS-10.6.patch --]
[-- Type: text/x-diff, Size: 3776 bytes --]

From 6a778c018f0e444e2ee9b8694ac9dbac8387e32c Mon Sep 17 00:00:00 2001
From: Alan Third <alan@idiocy.org>
Date: Tue, 19 Apr 2022 05:05:17 +0100
Subject: [PATCH v4] Fix nsmenu compilation under macOS 10.6

* src/nsmenu.m ([EmacsMenu fillWithWidgetValue:]): Replace modern
shorthand dictionary and array definitions.
* src/nsterm.h (NSTextAlignmentRight): Redefine if necessary.
* src/macfont.m (mac_font_create_preferred_family_for_attributes):
isOperatingSystemAtLeastVersion is new in macOS 10.10, so it's
probably wrong to use it to check whether we're below 10.9.
---
 src/macfont.m | 11 +++++------
 src/nsmenu.m  | 10 ++++++----
 src/nsterm.h  |  2 +-
 3 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/src/macfont.m b/src/macfont.m
index 34e48afb98..eaac47edb8 100644
--- a/src/macfont.m
+++ b/src/macfont.m
@@ -3570,18 +3570,17 @@ So we use CTFontDescriptorCreateMatchingFontDescriptor (no
 
       if (languages && CFArrayGetCount (languages) > 0)
         {
-          if ([[NSProcessInfo processInfo]
-                isOperatingSystemAtLeastVersion:
-                  ((NSOperatingSystemVersion){
-                    .majorVersion = 10, .minorVersion = 9})])
-            values[num_values++] = CFArrayGetValueAtIndex (languages, 0);
-          else
+#if MAC_OS_X_VERSION_MIN_REQUIRED < 10900
+          if (CTGetCoreTextVersion () < kCTVersionNumber10_9)
             {
               CFCharacterSetRef charset =
                 CFDictionaryGetValue (attributes, kCTFontCharacterSetAttribute);
 
               result = mac_font_copy_default_name_for_charset_and_languages (charset, languages);
             }
+          else
+#endif
+            values[num_values++] = CFArrayGetValueAtIndex (languages, 0);
         }
       if (result == NULL)
         {
diff --git a/src/nsmenu.m b/src/nsmenu.m
index 81d7cd2da1..0f7d1fb98f 100644
--- a/src/nsmenu.m
+++ b/src/nsmenu.m
@@ -649,7 +649,8 @@ - (void)fillWithWidgetValue: (void *)wvptr
      work around it by using tabs to split the title into two
      columns.  */
   NSFont *menuFont = [NSFont menuFontOfSize:0];
-  NSDictionary *font_attribs = @{NSFontAttributeName: menuFont};
+  NSDictionary *font_attribs = [NSDictionary dictionaryWithObjectsAndKeys:
+                                               menuFont, NSFontAttributeName, nil];
   CGFloat maxNameWidth = 0;
   CGFloat maxKeyWidth = 0;
 
@@ -677,11 +678,12 @@ - (void)fillWithWidgetValue: (void *)wvptr
   NSTextTab *tab =
     [[[NSTextTab alloc] initWithTextAlignment: NSTextAlignmentRight
                                      location: maxWidth
-                                      options: @{}] autorelease];
+                                      options: [NSDictionary dictionary]] autorelease];
   NSMutableParagraphStyle *pstyle = [[[NSMutableParagraphStyle alloc] init]
                                       autorelease];
-  [pstyle setTabStops: @[tab]];
-  attributes = @{NSParagraphStyleAttributeName: pstyle};
+  [pstyle setTabStops: [NSArray arrayWithObject:tab]];
+  attributes = [NSDictionary dictionaryWithObjectsAndKeys:
+                               pstyle, NSParagraphStyleAttributeName, nil];
 #endif
 
   /* clear existing contents */
diff --git a/src/nsterm.h b/src/nsterm.h
index 4cba5c0be8..4cb7475235 100644
--- a/src/nsterm.h
+++ b/src/nsterm.h
@@ -1290,8 +1290,8 @@ #define NSWindowStyleMaskUtilityWindow     NSUtilityWindowMask
 #define NSAlertStyleCritical               NSCriticalAlertStyle
 #define NSControlSizeRegular               NSRegularControlSize
 #define NSCompositingOperationCopy         NSCompositeCopy
+#define NSTextAlignmentRight               NSRightTextAlignment
 
-/* And adds NSWindowStyleMask.  */
 #ifdef __OBJC__
 typedef NSUInteger NSWindowStyleMask;
 #endif
-- 
2.35.1