Re: Emacs 28 on OSX: emacsclient.c:1415: warning: implicit declaration of function 'openat'

[Alan Third <alan@idiocy.org>]

[-- Attachment #1: Type: text/plain, Size: 1511 bytes --]

On Tue, Apr 19, 2022 at 10:35:38AM +0800, Po Lu wrote:
> Keith David Bershatsky <esq@lawlist.com> writes:
> 
> > I located just one instance of 1060 and changed it to 1068 per your
> > suggestion.  The build generated one warning during the nsterm.m
> > section, and then moved on to nsfns.m, where the build stopped.
> 
> I think you meant nsmenu.m.
> 
> >   CC       nsmenu.o
> > In file included from nsmenu.m:28:
> > lisp.h:2156: warning: declaration does not declare anything
> > nsmenu.m: In function '-[EmacsMenu fillWithWidgetValue:]':
> > nsmenu.m:652: error: stray '@' in program
> > nsmenu.m:652: error: field name not in record or union initializer
> > nsmenu.m:652: error: (near initialization for 'font_attribs')
> > nsmenu.m:652: warning: incompatible Objective-C types initializing 'struct NSFont *', expected 'struct NSDictionary *'
> 
> I don't know what "@" means in Objective-C, and it seems that GCC
> doesn't support such a feature.  Would someone please explain this piece
> of code?
> 
>   NSDictionary *font_attribs = @{NSFontAttributeName: menuFont};

Welcome to the wonderful world of Objective C under GCC.

The attached should fix this particular error.

These problems will need to be fixed in the emacs-28 branch, assuming
we're going to continue supporting macOS 10.6.

FWIW, I've moved away from trying to hide warnings generated on older
versions of macOS to try and avoid the difficult to understand #if
constructions we've previously used throughout the code.
-- 
Alan Third

[-- Attachment #2: 0001-Fix-nsmenu-compilation-under-macOS-10.6.patch --]
[-- Type: text/x-diff, Size: 1827 bytes --]

From f11340a5a5d234b57022908483979dfa0a9ccb99 Mon Sep 17 00:00:00 2001
From: Alan Third <alan@idiocy.org>
Date: Tue, 19 Apr 2022 05:05:17 +0100
Subject: [PATCH] Fix nsmenu compilation under macOS 10.6

* src/nsmenu.m ([EmacsMenu fillWithWidgetValue:]): Replace modern
shorthand dictionary and array definitions.
---
 src/nsmenu.m | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/nsmenu.m b/src/nsmenu.m
index 81d7cd2da1..0f7d1fb98f 100644
--- a/src/nsmenu.m
+++ b/src/nsmenu.m
@@ -649,7 +649,8 @@ - (void)fillWithWidgetValue: (void *)wvptr
      work around it by using tabs to split the title into two
      columns.  */
   NSFont *menuFont = [NSFont menuFontOfSize:0];
-  NSDictionary *font_attribs = @{NSFontAttributeName: menuFont};
+  NSDictionary *font_attribs = [NSDictionary dictionaryWithObjectsAndKeys:
+                                               menuFont, NSFontAttributeName, nil];
   CGFloat maxNameWidth = 0;
   CGFloat maxKeyWidth = 0;
 
@@ -677,11 +678,12 @@ - (void)fillWithWidgetValue: (void *)wvptr
   NSTextTab *tab =
     [[[NSTextTab alloc] initWithTextAlignment: NSTextAlignmentRight
                                      location: maxWidth
-                                      options: @{}] autorelease];
+                                      options: [NSDictionary dictionary]] autorelease];
   NSMutableParagraphStyle *pstyle = [[[NSMutableParagraphStyle alloc] init]
                                       autorelease];
-  [pstyle setTabStops: @[tab]];
-  attributes = @{NSParagraphStyleAttributeName: pstyle};
+  [pstyle setTabStops: [NSArray arrayWithObject:tab]];
+  attributes = [NSDictionary dictionaryWithObjectsAndKeys:
+                               pstyle, NSParagraphStyleAttributeName, nil];
 #endif
 
   /* clear existing contents */
-- 
2.35.1