all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#53770: [PATCH] woman.el: remove kerning escapes
@ 2022-02-04  5:42 Brendan O'Dea
  2022-02-05  6:51 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 2+ messages in thread
From: Brendan O'Dea @ 2022-02-04  5:42 UTC (permalink / raw)
  To: 53770

[-- Attachment #1: Type: text/plain, Size: 562 bytes --]

Severity: wishlist
Tags: patch

Some manual pages use kerning escapes* to correctly handle adjacent
roman and italic characters.  The woman function doesn't interpret them,
resulting in output such as the following from `ls'.

  ls [\,OPTION\/]... [\,FILE\/]...

  --color[=\,WHEN\/]
          colorize the  output; WHEN can be  'always' (default if
          omitted), 'auto', or 'never'; more info below

Attached is a trivial patch to remove them.

--bod

* https://www.gnu.org/software/groff/manual/html_node/Ligatures-and-Kerning.html#Ligatures-and-Kerning

[-- Attachment #2: woman.patch --]
[-- Type: text/x-diff, Size: 632 bytes --]

--- woman.el.orig	2022-02-04 14:08:54.188622150 +1100
+++ woman.el	2022-02-04 14:08:51.254677185 +1100
@@ -2299,9 +2299,9 @@
       (replace-match woman-unpadded-space-string t t))
 
     ;; Discard optional hyphen \%; concealed newlines \<newline>;
-    ;; point-size change function \sN,\s+N, \s-N:
+    ;; kerning \/, \,; point-size change function \sN,\s+N, \s-N:
     (goto-char from)
-    (while (re-search-forward "\\\\\\([%\n]\\|s[-+]?[0-9]+\\)" nil t)
+    (while (re-search-forward "\\\\\\([%\n/,]\\|s[-+]?[0-9]+\\)" nil t)
       (woman-delete-match 0))
 
     ;; BEWARE: THIS SHOULD PROBABLY ALL BE DONE MUCH LATER!!!!!

^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#53770: [PATCH] woman.el: remove kerning escapes
  2022-02-04  5:42 bug#53770: [PATCH] woman.el: remove kerning escapes Brendan O'Dea
@ 2022-02-05  6:51 ` Lars Ingebrigtsen
  0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2022-02-05  6:51 UTC (permalink / raw)
  To: Brendan O'Dea; +Cc: 53770

Brendan O'Dea <bod@debian.org> writes:

> Attached is a trivial patch to remove them.

Thanks; pushed to Emacs 29.

This change was small enough to apply without assigning copyright to the
FSF, but for future patches you want to submit, it might make sense to
get the paperwork started now, so that subsequent patches can be applied
speedily. Would you be willing to sign such paperwork?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-02-05  6:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-04  5:42 bug#53770: [PATCH] woman.el: remove kerning escapes Brendan O'Dea
2022-02-05  6:51 ` Lars Ingebrigtsen

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.