From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: [PATCH]: Re: Early backtrace. Date: Tue, 1 Feb 2022 19:14:49 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17127"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 01 22:55:07 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nF17D-0004KU-K0 for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Feb 2022 22:55:07 +0100 Original-Received: from localhost ([::1]:38562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nF17C-0001qF-1x for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Feb 2022 16:55:06 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56892) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEycC-0001ox-7m for emacs-devel@gnu.org; Tue, 01 Feb 2022 14:15:01 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:19216 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1nEyc9-0008Pk-W1 for emacs-devel@gnu.org; Tue, 01 Feb 2022 14:14:55 -0500 Original-Received: (qmail 83249 invoked by uid 3782); 1 Feb 2022 19:14:50 -0000 Original-Received: from acm.muc.de (p4fe1570f.dip0.t-ipconnect.de [79.225.87.15]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 01 Feb 2022 20:14:50 +0100 Original-Received: (qmail 25501 invoked by uid 1000); 1 Feb 2022 19:14:49 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285740 Archived-At: Hello, Stefan. On Sun, Jan 30, 2022 at 11:31:30 -0500, Stefan Monnier wrote: > Alan Mackenzie [2022-01-30 11:07:32] wrote: [ .... ] > > Are there any objections to me committing this to master? > See my comments below. [ .... dealt with by your subsequent post .... ] > > (defalias 'debug-early-backtrace > > #'(lambda () > > "Print a trace of Lisp function calls currently active. > > The output stream used is the value of `standard-output'. > > This is a simplified version of the standard `backtrace' > > function, intended for use in debugging the early parts > > of the build process." > > (princ "\n") > > (mapbacktrace > > #'(lambda (evald func args _flags) > > (let ((args args)) > > (if evald > > (progn > > (princ " ") > > (prin1 func) > > (princ " (") > > (while args > > (prin1 (car args)) > > (setq args (cdr args)) > > (if args > > (princ " "))) > > (princ ")\n")) > > (while args > > (princ " ") > > (prin1 (car args)) > > (princ "\n") > > (setq args (cdr args))))))))) > > (defalias 'debug-early > > #'(lambda (&rest args) > > "Print a trace of Lisp function calls currently active. > > The output stream used is the value of `standard-output'. > > There should be two ARGS, the symbol `error' and a cons of > > the error symbol and its data. > > This is a simplified version of `debug', intended for use > > in debugging the early parts of the build process." > > (princ "\nError: ") > > (prin1 (car (car (cdr args)))) ; The error symbol. > > (princ " ") > > (prin1 (cdr (car (cdr args)))) ; The error data. > > (debug-early-backtrace))) > I'm curious: why did you split this into two functions? Since debug-early-backtrace is potentially useful in its own right, just as backtrace is. > > (setq debugger #'debug-early) > Could we make `debug-early` the default/initial value of `debugger` in > the C code, so that reloading `debug-early.el` can be done safely? I'm not sure what you're asking here. Do you mean set Vdebugger to debug-early in syms_of_eval? How would that make reloading debug-early.el safe? > Stefan -- Alan Mackenzie (Nuremberg, Germany).