From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: make check error in native compiler resulting from commit 1cd188799f86bcb13ad76e82e3436b1b7e9f9e9f on 2021-12-30. Date: Tue, 1 Feb 2022 17:17:56 +0000 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38848"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen To: Andrea Corallo , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 01 21:55:38 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nF0Be-0009t5-27 for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Feb 2022 21:55:38 +0100 Original-Received: from localhost ([::1]:60662 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nF0Bc-0005UW-8a for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Feb 2022 15:55:36 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55572) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEwnF-0002Fo-Jy for emacs-devel@gnu.org; Tue, 01 Feb 2022 12:18:13 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:15921 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1nEwnD-00075h-Dj for emacs-devel@gnu.org; Tue, 01 Feb 2022 12:18:13 -0500 Original-Received: (qmail 40962 invoked by uid 3782); 1 Feb 2022 17:17:56 -0000 Original-Received: from acm.muc.de (p4fe1570f.dip0.t-ipconnect.de [79.225.87.15]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 01 Feb 2022 18:17:56 +0100 Original-Received: (qmail 10554 invoked by uid 1000); 1 Feb 2022 17:17:56 -0000 Content-Disposition: inline X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285736 Archived-At: Hello, Andrea. In that patch, I made the following change so that a comparison involving Qnil would not go through the (newly) expensive emit_EQ: diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el index 0a10505257..8581fe8066 100644 --- a/lisp/emacs-lisp/comp.el +++ b/lisp/emacs-lisp/comp.el @@ -1829,9 +1829,7 @@ comp-limplify-lap-inst (byte-listp auto) (byte-eq auto) (byte-memq auto) - (byte-not - (comp-emit-set-call (comp-call 'eq (comp-slot-n (comp-sp)) - (make-comp-mvar :constant nil)))) + (byte-not null) (byte-car auto) (byte-cdr auto) (byte-cons auto) .. Since then, there has been a mismatch in test/lisp/emacs-lisp/comp-tests.log, comp-tests-ret-type-spec-55, where the returned ret-type has now become t, whereas previously it was (not integer). I don't really understand what ret-type is. The mismatch between what this ret-type "should" be, and what it now is doesn't seem to be causing any problems. Would you please say whether this is, in fact, true. Would you also please advise on the best way to fix this bug in make check. Thanks! -- Alan Mackenzie (Nuremberg, Germany).