all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Philipp Stephani <p.stephani2@gmail.com>,
	monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: [PATCH]: Re: Early backtrace.
Date: Mon, 31 Jan 2022 16:54:09 +0000	[thread overview]
Message-ID: <YfgUMQnSLI0wANLJ@ACM> (raw)
In-Reply-To: <83pmo884b3.fsf@gnu.org>

Hello, Eli.

On Mon, Jan 31, 2022 at 14:42:24 +0200, Eli Zaretskii wrote:
> > From: Philipp Stephani <p.stephani2@gmail.com>
> > Date: Mon, 31 Jan 2022 10:30:35 +0100
> > Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
> >  Emacs developers <emacs-devel@gnu.org>

> > Am So., 30. Jan. 2022 um 12:08 Uhr schrieb Alan Mackenzie <acm@muc.de>:

> > > It also fixes a bug in signal_or_quit (eval.c) where previously there
> > > was:

> > >       specbind (Vdebugger, Qdebug);

> > > , which had the effect of binding the contents of Vdebugger (namely
> > > Qdebug) to itself.  Correct would have been:

> > >       specbind (Qdebugger, Qdebug);

> > > , binding the symbol Qdebugger to Qdebug.



> > Good find, thanks. Independent of the rest of the patch, should we
> > install this one-character fix on the release branch?

> Yes, please.

OK, I'll do that, but it's slightly more than one character to change.
A DEFSYM for Qdebugger is also needed in syms_of_eval.

> > Maybe that would even make commit
> > 07edc28bdbfeeaeb1008b4fe21bfda586feae562 unnecessary? (Haven't
> > checked, though.)

> I wouldn't touch that part, as it cannot possibly do any harm.

-- 
Alan Mackenzie (Nuremberg, Germany).



  reply	other threads:[~2022-01-31 16:54 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-10 20:34 Early backtrace Alan Mackenzie
2022-01-10 21:54 ` Stefan Monnier
2022-01-11 11:36   ` Alan Mackenzie
2022-01-11 14:47     ` Stefan Monnier
2022-01-30 11:07       ` [PATCH]: " Alan Mackenzie
2022-01-30 16:31         ` Stefan Monnier
2022-01-31 14:04           ` Stefan Monnier
2022-02-01 19:14           ` Alan Mackenzie
2022-02-02  3:36             ` Stefan Monnier
2022-02-02 20:38               ` Alan Mackenzie
2022-02-02 20:59                 ` Stefan Monnier
2022-02-03  8:38                   ` Eli Zaretskii
2022-02-03 21:35                     ` Alan Mackenzie
2022-02-04  7:24                       ` Eli Zaretskii
2022-02-04 21:01                         ` Alan Mackenzie
2022-02-05  7:12                           ` Eli Zaretskii
2022-02-05 10:48                             ` Alan Mackenzie
2022-02-04 13:31                     ` Stefan Monnier
2022-02-04 14:02                       ` Eli Zaretskii
2022-01-31  9:30         ` Philipp Stephani
2022-01-31 12:42           ` Eli Zaretskii
2022-01-31 16:54             ` Alan Mackenzie [this message]
2022-01-31 17:24               ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YfgUMQnSLI0wANLJ@ACM \
    --to=acm@muc.de \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=p.stephani2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.