Re: Time to merge scratch/correct-warning-pos into master, perhaps?

[Alan Mackenzie <acm@muc.de>]

Hello, Gregory.

On Wed, Jan 26, 2022 at 18:59:39 +0000, Gregory Heytings wrote:


> > What you reported was more educated guesses than results.


> No, these are results.


> > Why don't you actually _measure_ some hopefully typical Emacs use, and 
> > tell us exactly how you got these measurements.  Start off saying how 
> > you configured your build, followed by calling emacs -Q, with all the 
> > other detailed steps needed to duplicate your measurements.


> This information is all upthread, but in case you missed it, I'll repeat 
> it here.  I built Emacs with its standard configuration options (IOW I 
> just typed "make" in a fresh clone of the repository), on an up-to-date 
> and unloaded Debian bookworm machine.  To split the time of make check 
> between compilation and execution, I used the attached patch (which I 
> already sent upthread).

Apologies, I had missed it.

> >> You may have seen that this optimization has no effect without 
> >> --with-native-compilation.  This may explain that.

> > The bootstrap time without native compilation is much shorter in any 
> > case.


> This is an unrelated question, but no, it is not.  With just "make" (IOW 
> without --with-native-compilation) I do not see a significant difference 
> between 10083e788f and 808917b3fc.

Mistake of ambiguity on my part.  What I meant was that the bootstrap
time without NC is much shorter than that with NC.

So, the picture we're seeing is that "real world" timings are showing the
new master ~1% - 3.2% slower than the old, with building and test suites
in the low to mid teens of percent slower.

> From 7ad5a5eb008315bf40061e5aad8a8d001787f2bf Mon Sep 17 00:00:00 2001
> From: Gregory Heytings <gregory@heytings.org>
> Date: Sun, 23 Jan 2022 21:45:21 +0000
> Subject: [PATCH] Add a target to byte-compile all tests without running them

> * test/Makefile.in: Add a check-byte-compile target.
> * Makefile.in: Add the check-byte-compile target to CHECK_TARGETS.
> ---
>  Makefile.in      | 2 +-
>  test/Makefile.in | 3 +++
>  2 files changed, 4 insertions(+), 1 deletion(-)

> diff --git a/Makefile.in b/Makefile.in
> index 8ac6f52746..e1acf13551 100644
> --- a/Makefile.in
> +++ b/Makefile.in
> @@ -1014,7 +1014,7 @@ TAGS tags:
>  	$(MAKE) -C doc/lispref tags
>  	$(MAKE) -C doc/misc tags

> -CHECK_TARGETS = check check-maybe check-expensive check-all
> +CHECK_TARGETS = check check-maybe check-expensive check-all check-byte-compile
>  .PHONY: $(CHECK_TARGETS)
>  $(CHECK_TARGETS): all
>  	$(MAKE) -C test $@
> diff --git a/test/Makefile.in b/test/Makefile.in
> index 9ad994e110..85e1e0c5e5 100644
> --- a/test/Makefile.in
> +++ b/test/Makefile.in
> @@ -327,6 +327,9 @@ .PHONY:
>  check-maybe: check-no-automated-subdir
>  	@${MAKE} check-doit SELECTOR="${SELECTOR_ACTUAL}"

> +check-byte-compile:
> +	@${MAKE} $(ELFILES:.el=.elc)
> +
>  ## Run the tests.
>  .PHONY: check-doit
>  ## We can't put LOGFILES as prerequisites, because that would stop the
> -- 
> 2.34.1

-- 
Alan Mackenzie (Nuremberg, Germany).