all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Andrea Corallo <akrl@sdf.org>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, emacs-devel@gnu.org
Subject: Re: make check error in native compiler resulting from commit 1cd188799f86bcb13ad76e82e3436b1b7e9f9e9f on 2021-12-30.
Date: Sat, 5 Feb 2022 15:15:39 +0000	[thread overview]
Message-ID: <Yf6Um+LBvxjn05T5@ACM> (raw)
In-Reply-To: <xjffsoyvftk.fsf@ma.sdf.org>

Hello, Andrea.

On Fri, Feb 04, 2022 at 14:58:47 +0000, Andrea Corallo wrote:
> Andrea Corallo <akrl@sdf.org> writes:

> > Alan Mackenzie <acm@muc.de> writes:
> >> In that patch, I made the following change so that a comparison
> >> involving Qnil would not go through the (newly) expensive emit_EQ:

> >> diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
> >> index 0a10505257..8581fe8066 100644
> >> --- a/lisp/emacs-lisp/comp.el
> >> +++ b/lisp/emacs-lisp/comp.el
> >> @@ -1829,9 +1829,7 @@ comp-limplify-lap-inst
> >>        (byte-listp auto)
> >>        (byte-eq auto)
> >>        (byte-memq auto)
> >> -      (byte-not
> >> -       (comp-emit-set-call (comp-call 'eq (comp-slot-n (comp-sp))
> >> -                                      (make-comp-mvar :constant nil))))
> >> +      (byte-not null)
> >>        (byte-car auto)
> >>        (byte-cdr auto)
> >>        (byte-cons auto)

> Yeah, I think reverting this hunk and keeping the `eq' explicit in
> LIMPLE is the right thing to do, it solves this specific issue and we
> get back null and not inlined for free.

> The explicit `eq' gets already nicely handled by the logic you have
> added in comp.c:2244 so we emit libgccjit IR using emit_BASE_EQ in this
> case.

> I've pushed dcf30f14f9 to do that as it works here.

OK, thank you!

> Thanks

>   Andrea

-- 
Alan Mackenzie (Nuremberg, Germany).



      reply	other threads:[~2022-02-05 15:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-01 17:17 make check error in native compiler resulting from commit 1cd188799f86bcb13ad76e82e3436b1b7e9f9e9f on 2021-12-30 Alan Mackenzie
2022-02-01 17:47 ` Andrea Corallo
2022-02-04 14:11 ` Andrea Corallo
2022-02-04 14:58   ` Andrea Corallo
2022-02-05 15:15     ` Alan Mackenzie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yf6Um+LBvxjn05T5@ACM \
    --to=acm@muc.de \
    --cc=akrl@sdf.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.