From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Time to merge scratch/correct-warning-pos into master, perhaps? Date: Sat, 22 Jan 2022 18:30:43 +0000 Message-ID: References: <83mtjwzwkb.fsf@gnu.org> <87r198ytog.fsf@gnus.org> <87zgnvyb5y.fsf@gnus.org> <87bl03j10s.fsf@gnus.org> <87bl03dc64.fsf@gnus.org> <83bl03n5or.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33174"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii , Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 22 19:59:03 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nBLbL-0008RE-Md for ged-emacs-devel@m.gmane-mx.org; Sat, 22 Jan 2022 19:59:03 +0100 Original-Received: from localhost ([::1]:59448 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nBLbK-0008Kv-MK for ged-emacs-devel@m.gmane-mx.org; Sat, 22 Jan 2022 13:59:02 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35524) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nBLAS-0002ca-UW for emacs-devel@gnu.org; Sat, 22 Jan 2022 13:31:19 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:18705 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1nBLAD-0000LD-AC for emacs-devel@gnu.org; Sat, 22 Jan 2022 13:31:02 -0500 Original-Received: (qmail 83785 invoked by uid 3782); 22 Jan 2022 18:30:47 -0000 Original-Received: from acm.muc.de (p2e5d54f8.dip0.t-ipconnect.de [46.93.84.248]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 22 Jan 2022 19:30:46 +0100 Original-Received: (qmail 16957 invoked by uid 1000); 22 Jan 2022 18:30:43 -0000 Content-Disposition: inline In-Reply-To: <83bl03n5or.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285224 Archived-At: Hello, Eli and Lars. On Sat, Jan 22, 2022 at 17:36:20 +0200, Eli Zaretskii wrote: > > From: Lars Ingebrigtsen > > Cc: Stefan Monnier , Eli Zaretskii > > , emacs-devel@gnu.org > > Date: Sat, 22 Jan 2022 16:26:27 +0100 > > Alan Mackenzie writes: > > > Each of the following two sets of results was obtained from my machine > > > starting emacs --no-desktop, and represents the second run of > > > elisp-benchmarks on each build. The state of master was merged into the > > > branch this morning, and both builds were redone this morning, too. > > Looks good to me, then, so unless Eli has any objections, merging the > > branch is fine by me. > No objections. Many thanks, both of you. I've now merged the branch into master, and closed the six merged bugs about it. Just a small point, Lars. The change you made to byte-compile-from-buffer earlier on today, I had to revert. That function now needs to call read-positioning-symbols. But if load-read-function gets bound to r-p-s, a function in a subsidiary place gets symbols with position, and doesn't know what to do with them. This breaks the bootstrap. Anyhow, I'm having a beer this evening! This is the most difficult bug I've ever fixed, anywhere. -- Alan Mackenzie (Nuremberg, Germany).